doc: Add missed cmake package to build depends #30582

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240803-mimgw-cmake changing 1 files +1 −1
  1. hebasto commented at 1:35 pm on August 3, 2024: member

    CMake is used to build the following packages in depends when cross-compiling for Windows:

  2. doc: Add missed cmake package to build depends ee934d093d
  3. hebasto added the label Docs on Aug 3, 2024
  4. hebasto added the label Windows on Aug 3, 2024
  5. DrahtBot commented at 1:35 pm on August 3, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan, tdb3, vostrnad, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  6. TheCharlatan approved
  7. TheCharlatan commented at 2:11 pm on August 3, 2024: contributor
    ACK ee934d093d207f9478c03a3e1ce3f40ef4be6b80
  8. tdb3 approved
  9. tdb3 commented at 7:21 pm on August 3, 2024: contributor
    cr ut ACK ee934d093d207f9478c03a3e1ce3f40ef4be6b80
  10. vostrnad commented at 1:29 pm on August 4, 2024: none

    ACK ee934d093d207f9478c03a3e1ce3f40ef4be6b80

    nit: PR description could explain why it was missing. I’ve used these build instructions before and I know they worked.

  11. hebasto commented at 3:05 pm on August 4, 2024: member

    @vostrnad

    nit: PR description could explain why it was missing.

    The list of packages that use CMake has been added to the PR description.

    I’ve used these build instructions before and I know they worked.

    Your system might already have CMake installed. However, this is generally not a safe assumption, for instance, for Docker images.

  12. vostrnad commented at 3:13 pm on August 4, 2024: none
    @hebasto That might be it, I previously used these instructions successfully with Ubuntu WSL and only had cmake missing after switching to Debian WSL. I guess Ubuntu had it preinstalled.
  13. achow101 commented at 9:21 pm on August 5, 2024: member
    ACK ee934d093d207f9478c03a3e1ce3f40ef4be6b80
  14. achow101 merged this on Aug 5, 2024
  15. achow101 closed this on Aug 5, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-26 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me