docs: doc update for mempoolfullrbf default + log deprecation #30594

1. 
   glozow commented at 8:58 am on August 6, 2024: member

   Followup to #30493. Update bips.md and policy/*.md to reflect new default rules around signaling requirements in RBF. Also, log a warning when -mempoolfullrbf=0 that this config option is deprecated and will be removed in a future release.
2. glozow added the label Docs on Aug 6, 2024
3. 
   DrahtBot commented at 8:58 am on August 6, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	petertodd, tdb3, instagibbs

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30592 (Remove mempoolfullrbf by instagibbs)
   • #29520 (add -limitdummyscriptdatasize option by Retropex)
   • #29309 (Add a -permitbarepubkey option by vostrnad)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   petertodd commented at 9:33 am on August 6, 2024: contributor

   ACK 1f93e3c360f3da38a02fe6c01551f424a2d63dc9
5. fanquake added this to the milestone 28.0 on Aug 6, 2024
6. glozow renamed this:
   docs: update documentation for new mempoolfullrbf default
   docs: doc update for mempoolfullrbf default + log deprecation
   on Aug 6, 2024
7. in doc/policy/mempool-replacements.md:13 in 7168b45ba2 outdated

    9@@ -10,14 +10,12 @@ A transaction ("replacement transaction") may replace its directly conflicting t
   10 their in-mempool descendants (together, "original transactions") if, in addition to passing all
   11 other consensus and policy rules, each of the following conditions are met:
   12 
   13-1. The directly conflicting transactions all signal replaceability explicitly. A transaction is
   14+1. If `-mempoolfullrbf=0` (not true by default), the directly conflicting transactions all signal replaceability explicitly. A transaction is
   

   ---

   ---

   

   instagibbs commented at 2:53 pm on August 6, 2024:

   01. If `-mempoolfullrbf=0` (the value is 1 by default), the directly conflicting transactions all signal replaceability explicitly. A transaction is
   1Comment
   

   ---

   

   glozow commented at 9:20 am on August 7, 2024:

   done
8. in doc/policy/packages.md:41 in 7168b45ba2 outdated

   37@@ -38,7 +38,7 @@ The following rules are enforced for all packages:
   38 
   39 * Only limited package replacements are currently considered. (#28984)
   40 
   41-   - All direct conflicts must signal replacement (or the node must have `-mempoolfullrbf=1` set).
   42+   - If `-mempoolfullrbf=0` (not true by default), all direct conflicts must signal replacement.
   

   ---

   ---

   

   instagibbs commented at 2:54 pm on August 6, 2024:

   0    - If `-mempoolfullrbf=0` (the value is 1 by default), all direct conflicts must signal replacement.
   

   ---

   

   glozow commented at 9:20 am on August 7, 2024:

   done
9. in src/node/mempool_args.cpp:97 in ac6b8c3829 outdated

   92@@ -93,6 +93,9 @@ util::Result<void> ApplyArgsManOptions(const ArgsManager& argsman, const CChainP
   93     }
   94 
   95     mempool_opts.full_rbf = argsman.GetBoolArg("-mempoolfullrbf", mempool_opts.full_rbf);
   96+    if (!mempool_opts.full_rbf) {
   97+        LogPrintf("Warning: mempoolfullrbf=0 set but deprecated and will be removed in a future release\n");
   

   ---

   ---

   

   tdb3 commented at 1:34 am on August 7, 2024:

   Maybe we can use LogInfo here?

   ---

   

   glozow commented at 9:20 am on August 7, 2024:

   right of course! done, thanks
10. 
    tdb3 commented at 1:41 am on August 7, 2024: contributor

    Approach ACK
11. DrahtBot requested review from tdb3 on Aug 7, 2024
12. [doc] update documentation for new mempoolfullrbf default 4400c979a3
13. add deprecation warning for mempoolfullrbf 1f93e3c360
14. glozow force-pushed on Aug 7, 2024
15. tdb3 approved
16. 
    tdb3 commented at 11:10 am on August 7, 2024: contributor

    ACK 1f93e3c360f3da38a02fe6c01551f424a2d63dc9
17. 
    instagibbs commented at 1:49 pm on August 7, 2024: member

    ACK https://github.com/bitcoin/bitcoin/pull/30594/commits/1f93e3c360f3da38a02fe6c01551f424a2d63dc9
18. glozow merged this on Aug 7, 2024
19. glozow closed this on Aug 7, 2024

    ---

20. glozow deleted the branch on Aug 7, 2024

Contributors
glozow DrahtBot petertodd instagibbs tdb3

Labels
Docs

Milestone
28.0