I think these should be added to the build-unix file, I had to install them in addition to what was listed.
autoconf pkg-config libprotobuf-dev
I think these should be added to the build-unix file, I had to install them in addition to what was listed.
autoconf pkg-config libprotobuf-dev
I've added libprotobuf-dev to that file recently. Mind that it is a GUI-only dependency.
The other two don't really fit into the 'dependency' as they're not libraries and only needed for the build system. But mentioning them in the doc in some other way may be nice...
Well they are built-time dependencies, and afaik we only list built-time dependencies, not run-time ones. For example libdb5.1++-dev (the corresponding runtime dependency is libdb5.1++).
Yes, but what I mean, for example see the initial list of build-unit.md under "Dependencies":
Library Purpose Description
------- ------- -----------
libssl SSL Support Secure communications
libdb4.8 Berkeley DB Blockchain & wallet storage
libboost Boost C++ Library
miniupnpc UPnP Support Optional firewall-jumping support
qt GUI GUI toolkit
protobuf Payments in GUI Data interchange format used for payment protocol
libqrencode QR codes in GUI Optional for generating QR codes
autoconf and pkg-config do not fit into here.
It would fit under "Dependency Build Instructions: Ubuntu & Debian", which are distribution specific instructions.
what's happening with this? It doesn't seem very ideal that one has to google "bitcoin libprotobuf" in order to find this github issue in order to find the solution, as I just have.
Feel free to add autoconf and pkg-config somewhere.
The libprotobuf-dev package now has been in there for ages, please don't complain without even reading the docs.