The following bitcoind parameters / RPC calls still missed the “testnet4” network string:
- -chain= parameter
- getblockchaininfo RPC, "chain" result
- getmininginfo RPC, "chain" result
The occurences were found via $ git grep \".*main.*test.*\".
The following bitcoind parameters / RPC calls missed the "testnet4"
network string:
- `-chain=` parameter
- `getblockchaininfo` RPC, "chain" result
- `getmininginfo` RPC, "chain" result
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | maflcko, glozow, tdb3, BrandonOdiwuor, danielabrozzoni |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
1272@@ -1273,7 +1273,7 @@ RPCHelpMan getblockchaininfo()
1273 RPCResult{
1274 RPCResult::Type::OBJ, "", "",
1275 {
1276- {RPCResult::Type::STR, "chain", "current network name (main, test, signet, regtest)"},
1277+ {RPCResult::Type::STR, "chain", "current network name (main, test, testnet4, signet, regtest)"},
Would it make sense to have a #define LIST_CHAIN_NAMES "main, test, testnet4, signet, regtest" in src/chainparamsbase.h? Otherwise, the lines of code will have to be touched again when testnet3 is removed.
0 {RPCResult::Type::STR, "chain", "current network name (" LIST_CHAIN_NAMES ")"},
std::string ListChainTypes() (perhaps in src/util/chaintypes.h/cpp, src/chainparamsbase.h/cpp, src/common/messages.h/cpp, etc. or where appropriate).
ACK 701530045553f2b9671a3fffea301bf4dc954514
Good finds.
Ran bitcoin-cli help getblockchaininfo and help getmininginfo and confirmed presence of testnet4.
Left a non-blocking comment. Would be beneficial to de-deplicate.
