feat(build): improve dependency error reporting in autogen.sh #30646

pull epiccurious wants to merge 1 commits into bitcoin:master from epiccurious:autogen-print-error-to-stderr changing 1 files +1 −1
  1. epiccurious commented at 3:10 PM on August 13, 2024: contributor

    Improve error reporting in autogen.sh by redirecting the autoreconf dependency check's error message to stderr.

    Impact

    This PR modifies autogen.sh in the root directory.

    • No change to the functional behavior of these files.
    • Enhances error reporting by directing error messages to stderr, aligning with best practices.

    Background

    1. 9 years ago: Added the check for the autoreconf dependency to the autogen.sh build script. This check avoids a not found error because the next line runs autoreconf.

      • Original error message: ./autogen.sh: 9: ./autogen.sh: autoreconf: not found
      • Updated error message: configuration failed, please install autoconf first
      • Link to commit to the commit.
    2. 5 years ago: Updated the check from which to command -v to improve portability and reliability as part of a large lint refactor.

  2. refactor(build): redirect error msg to stderr in autogen.sh
    Improve error reporting in `autogen.sh` by redirecting the autoreconf dependency check's error message to stderr.
    74e1e26232
  3. DrahtBot commented at 3:10 PM on August 13, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept NACK maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. epiccurious commented at 3:12 PM on August 13, 2024: contributor

    Please let me know if it's preferred to squash the three commits.

  5. sipa commented at 3:20 PM on August 13, 2024: member

    The changes to secp256k1 should be done in https://github.com/bitcoin-core/secp256k1, and the changes to minisketch should be done in https://github.com/sipa/minisketch.

    I assume the autogen.sh will go away with the imminent cmake migration?

  6. epiccurious marked this as a draft on Aug 13, 2024
  7. epiccurious commented at 3:23 PM on August 13, 2024: contributor

    @sipa understood about secp256k1 and minisketch.

    Setting as draft to remove those changes from this PR.

  8. epiccurious force-pushed on Aug 13, 2024
  9. DrahtBot commented at 3:36 PM on August 13, 2024: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. <sub>Debug: https://github.com/bitcoin/bitcoin/runs/28715049878</sub>

    <details><summary>Hints</summary>

    Make sure to run all tests locally, according to the documentation.

    The failure may happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

  10. DrahtBot added the label CI failed on Aug 13, 2024
  11. epiccurious renamed this:
    feat(build): improve dependency error reporting in autogen scripts
    feat(build): improve dependency error reporting in autogen script
    on Aug 13, 2024
  12. epiccurious renamed this:
    feat(build): improve dependency error reporting in autogen script
    feat(build): improve dependency error reporting in autogen.sh
    on Aug 13, 2024
  13. DrahtBot removed the label CI failed on Aug 13, 2024
  14. epiccurious marked this as ready for review on Aug 13, 2024
  15. epiccurious commented at 5:30 PM on August 13, 2024: contributor

    Taking back out of draft. PR is now the single change to the main autogen.sh.

  16. maflcko commented at 7:22 AM on August 14, 2024: member

    Tend toward NACK. No need to apply style fixes to a file that will be deleted in 10 days (or whenever the branch-off happens and the cmake pull is reviewed sufficiently)

  17. epiccurious commented at 1:04 PM on August 14, 2024: contributor

    Thanks for reviewing. I'll close the PR as won't do.

  18. epiccurious closed this on Aug 14, 2024

  19. bitcoin locked this on Aug 14, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me