test: Fix test log file name #30654

1. 
   hebasto commented at 2:16 pm on August 14, 2024: member

   #19385 dropped .cpp infix (see #19385 (comment) and #19385 (comment)). However, src/test/README.md still refers to the foo_tests.cpp.log pattern: https://github.com/bitcoin/bitcoin/blob/e682e7db7e399ce888e492eab8f99c389aae05b5/src/test/README.md?plain=1#L113

   This PR restores the pre-PR19385 behaviour, as appending is easier to implement than replacing when porting this functionality to CMake.

2. test: Fix test log file name

   https://github.com/bitcoin/bitcoin/pull/19385 dropped `.cpp` infix.
   However, `src/test/README.md` still refers to the `foo_tests.cpp.log`
   pattern.

   704046a13f
3. hebasto added the label Bug on Aug 14, 2024
4. hebasto added the label Build system on Aug 14, 2024
5. hebasto added the label Tests on Aug 14, 2024
6. 
   DrahtBot commented at 2:16 pm on August 14, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

7. 
   fanquake commented at 3:23 pm on August 14, 2024: member

   However, src/test/README.md still refer This PR restores the pre-PR19385 behaviour,

   Not sure this PR should be called a “fix”? As it seems the fix would be to just update the docs to match the current (intended) behaviour.

   This instead seems to be a reversion to prior behaviour to facilitate something CMake related. I’m curious why this has only become an issue now, given we’ve already got the tests in CMake? Or is this something that was missing and is being ported now?

8. 
   maflcko commented at 3:28 pm on August 14, 2024: member

   Not sure about changing the test-only behavior here. Seems fine to just adjust the readme in the cmake pull, as the line has to be touched anyway. No need to be exact in porting this edge case?
9. 
   hebasto commented at 5:49 pm on August 14, 2024: member

   This instead seems to be a reversion to prior behaviour to facilitate something CMake related. I’m curious why this has only become an issue now, given we’ve already got the tests in CMake? Or is this something that was missing and is being ported now?

   I had some concerns while documenting CTest behaviour in https://github.com/hebasto/bitcoin/pull/329.

10. hebasto closed this on Aug 15, 2024

    ---

Contributors
hebasto DrahtBot fanquake maflcko

Labels
Bug Build system Tests