The flags SECP256K1_CONTEXT_{SIGN,VERIFY} have been marked as deprecated since libsecp256k1 version 0.2 (released in December 2022), with the recommendation to use SECP256K1_CONTEXT_NONE instead, see https://github.com/bitcoin-core/secp256k1/pull/1126 and https://github.com/bitcoin-core/secp256k1/blob/1988855079fa8161521b86515e77965120fdc734/CHANGELOG.md?plain=1#L132. Note that in contrast to other deprecated functions/variables, these defines don't have a deprecated attribute and hence don't lead to a compiler warning (see https://github.com/bitcoin-core/secp256k1/pull/1126#discussion_r922105271), so they are not easily detected.
test: replace deprecated secp256k1 context flags usage #30687
pull theStack wants to merge 1 commits into bitcoin:master from theStack:remove_deprecated_secp256k1_context_flags changing 2 files +2 −2-
theStack commented at 12:11 AM on August 21, 2024: contributor
-
60055f1abc
test: replace deprecated secp256k1 context flags usage
The flags SECP256K1_CONTEXT_{SIGN,VERIFY} have been deprecated since libsecp256k1 version 0.2 (released in December 2022), with the recommendation to use SECP256K1_CONTEXT_NONE instead. -
DrahtBot commented at 12:11 AM on August 21, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK TheCharlatan, ismaelsadeeq, tdb3 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Aug 21, 2024
- TheCharlatan approved
-
TheCharlatan commented at 8:39 AM on August 21, 2024: contributor
ACK 60055f1abc4b4ad5f66a2fcf2e61c65efc777036
-
ismaelsadeeq commented at 4:25 PM on August 22, 2024: member
utACK 60055f1abc4b4ad5f66a2fcf2e61c65efc777036
- tdb3 approved
-
tdb3 commented at 8:15 PM on August 22, 2024: contributor
light CR and test ACK 60055f1abc4b4ad5f66a2fcf2e61c65efc777036
Thanks for finding/fixing. Ran unit tests locally (including
key_tests) (passed). grep'edsrc/for other (nonsrc/secp256k1/*) instances ofSECP256K1_CONTEXT_SIGNbut didn't see any. - fanquake merged this on Aug 24, 2024
- fanquake closed this on Aug 24, 2024
- theStack deleted the branch on Aug 24, 2024
- bitcoin locked this on Aug 24, 2025
Contributors
Labels