fuzz: Add missing fuzz targets to cmake build #30712

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2408-fuzz-cmake changing 2 files +2 −0

maflcko commented at 12:21 PM on August 25, 2024: member

Can be tested via:

PRINT_ALL_FUZZ_TARGETS_AND_ABORT=1 ./bld-autot/src/test/fuzz/fuzz > /tmp/f_autot
PRINT_ALL_FUZZ_TARGETS_AND_ABORT=1 ./bld-cmake/src/test/fuzz/fuzz > /tmp/f_cmake
diff --unified /tmp/{f_autot,f_cmake}

DrahtBot commented at 12:21 PM on August 25, 2024: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #30717 (rpc: Add test-only RPCs under -test=<option> flag by Prabhat1308)
- #30685 (build: Mark x86_64-linux-gnu release binaries as CET-enabled by hebasto)
- #30634 (ci: Use clang-19 from apt.llvm.org by maflcko)
- #30619 (doc: Change nproc in docs to getconf _NPROCESSORS_ONLN by l0rinc)
- #30527 (Bump python minimum supported version to 3.10 by maflcko)
- #30465 (depends: Set CMAKE_SYSTEM_VERSION for CMake builds by hebasto)
- #30043 (net: Replace libnatpmp with built-in PCP+NATPMP implementation by laanwj)
- #29881 (guix: use GCC 13 to builds releases by fanquake)
- #29868 (Reintroduce external signer support for Windows by hebasto)
- #25573 ([POC] guix: produce a fully -static-pie bitcoind by fanquake)
- #19461 (multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky)
- #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
- #10102 (Multiprocess bitcoin by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot renamed this:
~~fuzz: Add missing fuzz targets to cmake build~~
fuzz: Add missing fuzz targets to cmake build
on Aug 25, 2024
DrahtBot added the label Tests on Aug 25, 2024
hebasto commented at 3:33 PM on August 25, 2024: member

Looks correct.

Type	Reviewers
ACK	hebasto

hebasto commented at 1:46 PM on August 27, 2024: member

Can be tested via:

PRINT_ALL_FUZZ_TARGETS_AND_ABORT=1 ./bld-autot/src/test/fuzz/fuzz > /tmp/f_autot
PRINT_ALL_FUZZ_TARGETS_AND_ABORT=1 ./bld-cmake/src/test/fuzz/fuzz > /tmp/f_cmake
diff --unified /tmp/{f_autot,f_cmake}

Such a check can be automated: https://github.com/hebasto/bitcoin/commits/pr30712_amended.

in cmake/script/Coverage.cmake:8 in 41a5479145 outdated
```
   4 | @@ -5,6 +5,7 @@
   5 |  include(${CMAKE_CURRENT_LIST_DIR}/CoverageInclude.cmake)
   6 |  
   7 |  set(functional_test_runner test/functional/test_runner.py)
   8 | +list(APPEND functional_test_runner --timeout-factor=8)  # Required, because coverage builds are slower
```
hebasto commented at 3:06 PM on August 27, 2024:

I've noticed the same -- https://github.com/hebasto/bitcoin/issues/341#issuecomment-2310510852:

However, on my machine, I had to add --timeout-factor=4.

maflcko commented at 10:04 AM on August 28, 2024:

dropped from this pull for now
maflcko force-pushed on Aug 27, 2024
maflcko force-pushed on Aug 27, 2024
maflcko force-pushed on Aug 28, 2024
DrahtBot commented at 9:55 AM on August 28, 2024: contributor



🐙 This pull request conflicts with the target branch and needs rebase.
DrahtBot added the label Needs rebase on Aug 28, 2024
maflcko marked this as ready for review on Aug 28, 2024
fuzz: Add missing fuzz targets to cmake build fa0e1e4f3c
maflcko force-pushed on Aug 28, 2024
maflcko commented at 10:03 AM on August 28, 2024: member

Rebased.

Should probably be merged before switching any fuzzing over to cmake.
maflcko commented at 10:04 AM on August 28, 2024: member

@hebasto I see your comments, but I am not sure if you approve this pull request, or if you want to open an alternative.
hebasto approved
hebasto commented at 10:05 AM on August 28, 2024: member

ACK fa0e1e4f3c2ede723554d10b6596d89955441373
fanquake merged this on Aug 28, 2024
fanquake closed this on Aug 28, 2024
maflcko deleted the branch on Aug 28, 2024
maflcko removed the label Needs rebase on Aug 28, 2024
bitcoin locked this on Aug 28, 2025

Contributors

Labels

Linked (view graph)

#30454 build: Introduce CMake-based build system

fuzz: Add missing fuzz targets to cmake build #30712

Code Coverage

Reviews

Conflicts