build: remove old MSVC build system #30731

1. 
   fanquake commented at 11:16 am on August 28, 2024: member

   This has been superseded by CMake, and should not be blocked on anything for removal.
2. 
   DrahtBot commented at 11:16 am on August 28, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, laanwj, TheCharlatan, vasild

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Build system on Aug 28, 2024
4. in .gitignore:4 in b5448999d8 outdated

   0@@ -1,7 +1,6 @@
   1 # Build subdirectories.
   2 /*build*
   3 !/build-aux
   4-!/build_msvc
   

   ---

   ---

   

   hebasto commented at 11:27 am on August 28, 2024:

   I’d keep this line. Otherwise, on Windows, build artifacts from pre-CMake branches, such as 28.x, will linger and be ignored by git.

   ---

   

   laanwj commented at 11:48 am on August 28, 2024:

   Isn’t the point to ignore build artifacts though? Sure, they might linger but better than accidentally checking them into git. (this was previously avoided by the nested gitignore, which is removed)

   ---

   

   hebasto commented at 11:56 am on August 28, 2024:

   I’m not sure if “accidentally checking them into git” is a concern we should worry about. However, after two years of switching between CMake and non-CMake branch, I’ve been convinced to keep the source tree clean.

   ---

   

   laanwj commented at 12:02 pm on August 28, 2024:

   But build directories that aren’t called build_msvc can still linger aorund in the same way. i think it’s strange to keep this around but ok.

   ---

   

   fanquake commented at 12:05 pm on August 28, 2024:

   @laanwj fwiw I agree with you, and think it should be dropped. Just couldn’t be bothered having the argument.

   ---

   

   laanwj commented at 12:08 pm on August 28, 2024:

   I’m not sure if “accidentally checking them into git” is a concern we should worry about

   i mean i personally use git add . sometimes to check all changes and additions in, relying that the .gitignore prevents any build artifacts from being checked in (because otherwise they’re ignored all over the tree). So for some people it’s probably a concern. Sure i check before pushing to github but sometimes it could result in extra work.

   @laanwj fwiw I agree with you, and think it should be dropped. Just couldn’t be bothered having the argument.

   Fair enough.

   ---

   

   hebasto commented at 12:11 pm on August 28, 2024:

   I’m fine with any approach as well.

   ---

   

   hebasto commented at 12:14 pm on August 28, 2024:

   But build directories that aren’t called build_msvc can still linger aorund in the same way. i think it’s strange to keep this around but ok.

   Other build* directories are created by the user explicitly, and the user is aware of them. However, the presence of the build_msvc directory might be unxepected.

5. 
   hebasto commented at 11:28 am on August 28, 2024: member

   Concept ACK, obviously :)
6. build: remove old MSVC build system

   This has been superseded by CMake.

   04fb085f6b
7. fanquake force-pushed on Aug 28, 2024
8. hebasto approved
9. 
   hebasto commented at 11:42 am on August 28, 2024: member

   ACK 04fb085f6bddc90e806deefd90c72104763f055a.
10. 
    laanwj commented at 11:42 am on August 28, 2024: member

    There’s a mention left in the top level gitignore:

    0.gitignore:!/build_msvc
    

11. 
    hebasto commented at 11:45 am on August 28, 2024: member

    There’s a mention left in the top level gitignore:

    0.gitignore:!/build_msvc
    

    #30731 (review)

12. 
    laanwj commented at 12:16 pm on August 28, 2024: member

    ACK 04fb085f6bddc90e806deefd90c72104763f055a
13. TheCharlatan approved
14. 
    TheCharlatan commented at 12:20 pm on August 28, 2024: contributor

    ACK 04fb085f6bddc90e806deefd90c72104763f055a

    Good riddance.

15. vasild approved
16. 
    vasild commented at 12:28 pm on August 28, 2024: contributor

    ACK 04fb085f6b, except:

    01:  ad12ccc5d1 ! 1:  04fb085f6b build: Remove legacy MSVC build system
    1    @@
    2      ## Metadata ##
    3    -Author: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
    4    +Author: fanquake <fanquake@gmail.com>
    

    I already reviewed this at https://github.com/hebasto/bitcoin/pull/166

17. fanquake merged this on Aug 28, 2024
18. fanquake closed this on Aug 28, 2024

    ---

19. fanquake deleted the branch on Aug 28, 2024

Contributors
fanquake DrahtBot hebasto laanwj TheCharlatan vasild

Labels
Build system