fanquake
commented at 4:43 pm on August 28, 2024:
member
Currently, builds of libevent in depends, using CMake, fail on some systems, like Alpine, with the following:
0/bitcoin/depends/work/build/aarch64-unknown-linux-musl/libevent/2.1.12-stable-1516ed47ea8/evmap.c: In function'evmap_signal_add_':
1/bitcoin/depends/work/build/aarch64-unknown-linux-musl/libevent/2.1.12-stable-1516ed47ea8/evmap.c:456:31: error: 'NSIG' undeclared (first use in this function)2456 | if(sig < 0|| sig >= NSIG)
From what I can tell the GNU_SOURCE “detection” in libevents CMake build system, never? really worked, primarily relies on looking for a deprecated define, and it’s not clear what a nice fix is. For now, always build with _GNU_SOURCE, to match the autotools behaviour.
fanquake added the label
Needs backport (28.x)
on Aug 28, 2024
fanquake added this to the milestone 28.0
on Aug 28, 2024
DrahtBot
commented at 4:43 pm on August 28, 2024:
contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
DrahtBot removed the label
DrahtBot Guix build requested
on Aug 29, 2024
depends: build libevent with -D_GNU_SOURCE
Currently, builds of libevent in depends, using CMake, fail on some
systems, like Alpine, with the following:
```bash
/bitcoin/depends/work/build/aarch64-unknown-linux-musl/libevent/2.1.12-stable-1516ed47ea8/evmap.c: In function 'evmap_signal_add_':
/bitcoin/depends/work/build/aarch64-unknown-linux-musl/libevent/2.1.12-stable-1516ed47ea8/evmap.c:456:31: error: 'NSIG' undeclared (first use in this function)
456 | if (sig < 0 || sig >= NSIG)
```
From what I can tell the `_GNU_SOURCE` "detection" in libevents CMake build
system, never? really worked, and it's not clear what a nice fix is.
For now, always use `_GNU_SOURCE` when building libevent in depends.
5567754087
fanquake force-pushed
on Sep 3, 2024
fanquake marked this as ready for review
on Sep 3, 2024
fanquake
commented at 9:20 am on September 3, 2024:
member
For now I’ve opted with matching the prior Autotools behaviour, and always building with -D_GNU_SOURCE, which is also easy to backport to 28.x.
fanquake added the label
DrahtBot Guix build requested
on Sep 3, 2024
fanquake
commented at 10:39 am on September 3, 2024:
member
0@@ -832,15 +832,15 @@
1 F8CD33 Uncompressed Length 0000064D
2 F8CD37 Filename Length 0022
3 F8CD39 Extra Length 0000
4 F8CD3B Comment Length 0000
5 F8CD3D Disk Start 0000
6 F8CD3F Int File Attributes 0001
7 [Bit 0] 1 Text Data
8-F8CD41 Ext File Attributes 81B40000
9+F8CD41 Ext File Attributes 81A40000
10 F8CD45 Local Header Offset 0000006311 F8CD49 Filename 'XXXXXXXXXXXXXX/XXXXXXXX/XXXXXXXXXX'
1213 F8CD6B CENTRAL HEADER [#4](/bitcoin-bitcoin/4/) 02014B50
14 F8CD6F Created Zip Spec 1E '3.0'
15 F8CD70 Created OS 03 'Unix'
16 F8CD71 Extract Zip Spec 0A '1.0'
17@@ -988,15 +988,15 @@
18 F8CF89 Uncompressed Length 000E06E9
19 F8CF8D Filename Length 002E
20 F8CF8F Extra Length 0000
21 F8CF91 Comment Length 0000
22 F8CF93 Disk Start 0000
23 F8CF95 Int File Attributes 0000
24 [Bit 0] 0 'Binary Data'
25-F8CF97 Ext File Attributes 81B40000
26+F8CF97 Ext File Attributes 81A40000
27 F8CF9B Local Header Offset 00E74C26
28 F8CF9F Filename 'XXXXXXXXXXXXXX/XXXXXXXX/XXXXXXXXX/XXXXX
29 XXXXXXX'
3031 F8CFCD CENTRAL HEADER #B 02014B50
32 F8CFD1 Created Zip Spec 1E '3.0'
33 F8CFD2 Created OS 03 'Unix'
Note that this shouldn’t be related to the change here, so if you’re happy with this change, I’d like to try move forward with it, so we can backport it to 28.x. I’ll open a new issue to track the macOS zipping non-determinism we seem to be seeing, if we don’t have it fixed before that.
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me
