This PR implements https://github.com/hebasto/bitcoin/pull/294.
From https://github.com/hebasto/bitcoin/pull/294#issuecomment-2317292100:
I think guix was already bumped to cmake, so this can be done in a separate pull already today?
This PR implements https://github.com/hebasto/bitcoin/pull/294.
From https://github.com/hebasto/bitcoin/pull/294#issuecomment-2317292100:
I think guix was already bumped to cmake, so this can be done in a separate pull already today?
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | fanquake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
What’s the reason for separating this from #30664?
https://github.com/hebasto/bitcoin/pull/294#issuecomment-2317292100
https://github.com/hebasto/bitcoin/pull/294#issuecomment-2317292100
Yes, I saw, but why not include it in the removal PR - do we expect it to take long time to merge?
Yes, I saw, but why not include it in the removal PR - do we expect it to take long time to merge?
We need to address https://github.com/hebasto/bitcoin/issues/341 first.
My Guix build:
0x86_64
1162558bde37d72fe208df3475706774347ca4558daca61f2eccf230f144ecbe6 guix-build-8b355c0bb212/output/aarch64-linux-gnu/SHA256SUMS.part
2fe01ee54a0d19ecdee4001d13600332b6304e97a49e62633cf13904add205250 guix-build-8b355c0bb212/output/aarch64-linux-gnu/bitcoin-8b355c0bb212-aarch64-linux-gnu-debug.tar.gz
321303b65ffe66f5521b1e049fb296c27761333add36149e92984fc5a456421fa guix-build-8b355c0bb212/output/aarch64-linux-gnu/bitcoin-8b355c0bb212-aarch64-linux-gnu.tar.gz
497cc03384e1c90c97294205ce013086b1ffc750f4b065775e3d595c8f235b054 guix-build-8b355c0bb212/output/arm-linux-gnueabihf/SHA256SUMS.part
5acee06367c912ee2dfc5339a8c61d8093b461a72e922b3db78c89ff315034322 guix-build-8b355c0bb212/output/arm-linux-gnueabihf/bitcoin-8b355c0bb212-arm-linux-gnueabihf-debug.tar.gz
6d250b129e8d1abd97ee1167982c41bda3382e8f38ecd9349331ccfb8d6827d96 guix-build-8b355c0bb212/output/arm-linux-gnueabihf/bitcoin-8b355c0bb212-arm-linux-gnueabihf.tar.gz
7b4fdc604b54dd638c8622635a9b2a4f850f752366775007988dd9c554c9a50ae guix-build-8b355c0bb212/output/arm64-apple-darwin/SHA256SUMS.part
8de7906780eefee0dd7eb6a40d140792a95c138265043d84501781d6fb46a301a guix-build-8b355c0bb212/output/arm64-apple-darwin/bitcoin-8b355c0bb212-arm64-apple-darwin-unsigned.tar.gz
97b82def1e7fd2a6f6ac533f055c62e55b0fe9dca7312b4a863995ba50b7c26f7 guix-build-8b355c0bb212/output/arm64-apple-darwin/bitcoin-8b355c0bb212-arm64-apple-darwin-unsigned.zip
10545e179a5f93d45c94d296b35a06ed41c176d3d00d926eab03d64a5a27e57957 guix-build-8b355c0bb212/output/arm64-apple-darwin/bitcoin-8b355c0bb212-arm64-apple-darwin.tar.gz
116a3c9a7916f7cdd42ec40a124c611c25858b2377b82b7140248572221442f39f guix-build-8b355c0bb212/output/dist-archive/bitcoin-8b355c0bb212.tar.gz
127d694d18050a96aa9bdbe5214ff559b18fa0a472d927f8e520055ccef64f31d0 guix-build-8b355c0bb212/output/powerpc64-linux-gnu/SHA256SUMS.part
135f5724e99f4da966626be6d62aa7d2b399a7dc57fbda646434073a93dce94d54 guix-build-8b355c0bb212/output/powerpc64-linux-gnu/bitcoin-8b355c0bb212-powerpc64-linux-gnu-debug.tar.gz
141653e58aea479ff820aa7cfabfe729377f555b539602505c06fc9b50004ece5e guix-build-8b355c0bb212/output/powerpc64-linux-gnu/bitcoin-8b355c0bb212-powerpc64-linux-gnu.tar.gz
15436b008d782d1c7453082966696ff162c17e7d0924af31d4f2bb718974e5b276 guix-build-8b355c0bb212/output/riscv64-linux-gnu/SHA256SUMS.part
16bb07f0b5d3c9765935d6a77772c499dcaee2ed6f38af7d3dc80ae238ea175c4f guix-build-8b355c0bb212/output/riscv64-linux-gnu/bitcoin-8b355c0bb212-riscv64-linux-gnu-debug.tar.gz
179228f20136ebe9292936fa151c25b04cf10af7a7ead3cd65a9b09a75636201a7 guix-build-8b355c0bb212/output/riscv64-linux-gnu/bitcoin-8b355c0bb212-riscv64-linux-gnu.tar.gz
181561eb165e9453be51d285191f133e7f5247c98f760cf5728059775a047fc455 guix-build-8b355c0bb212/output/x86_64-apple-darwin/SHA256SUMS.part
19651acd1d68f3d6b64cea39b288131dc3f965ccdc90e686a98eb7ef3b44e2e211 guix-build-8b355c0bb212/output/x86_64-apple-darwin/bitcoin-8b355c0bb212-x86_64-apple-darwin-unsigned.tar.gz
207a442b7eb0848a0379683069632f940e452d6ee1b5bea002e4134633f77eef5a guix-build-8b355c0bb212/output/x86_64-apple-darwin/bitcoin-8b355c0bb212-x86_64-apple-darwin-unsigned.zip
21fae467ae55385d7643f37051433e5df41ab5b3585e038b981e074ef1f005f35d guix-build-8b355c0bb212/output/x86_64-apple-darwin/bitcoin-8b355c0bb212-x86_64-apple-darwin.tar.gz
22a0e375e56801d037490afa1fe0027ab459b2bccf325d8f6258153ef5949a9ced guix-build-8b355c0bb212/output/x86_64-linux-gnu/SHA256SUMS.part
23c4db06dea76707ebbc7503b08094a718785bf0ea5eea0d25d558d910ac67e941 guix-build-8b355c0bb212/output/x86_64-linux-gnu/bitcoin-8b355c0bb212-x86_64-linux-gnu-debug.tar.gz
24988d8140fef1f0fcdeeea8fb2ccb171b0154ecf4cccf827fdd3614d0a8c7aba1 guix-build-8b355c0bb212/output/x86_64-linux-gnu/bitcoin-8b355c0bb212-x86_64-linux-gnu.tar.gz
25621d35b760ce2ce517c30a75ba6eee95e966d70bdc271e659f39c4531fde5cb2 guix-build-8b355c0bb212/output/x86_64-w64-mingw32/SHA256SUMS.part
2642883d8b6527e697103eca9c97482ba8f448a8bb949ecfe8b717e832e289daeb guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64-debug.zip
27e6dfb81cdf910bf77c7642c290abcb748aa7183f290102fd9f5d5d20818f5752 guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64-setup-unsigned.exe
2864cad0e4275b95456c8a681c157ab85fac2d42fad63120a77ecbfc1bd9ef29d7 guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64-unsigned.tar.gz
29c8affd59df0d3823a35adf39591826de00062bb8d52d9c3e90b182a0a6a7038d guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64.zip
ACK 8b355c0bb21232862a7c2834fcc3376adf7ca0f7
Guix Build (aarch64)
0162558bde37d72fe208df3475706774347ca4558daca61f2eccf230f144ecbe6 guix-build-8b355c0bb212/output/aarch64-linux-gnu/SHA256SUMS.part
1fe01ee54a0d19ecdee4001d13600332b6304e97a49e62633cf13904add205250 guix-build-8b355c0bb212/output/aarch64-linux-gnu/bitcoin-8b355c0bb212-aarch64-linux-gnu-debug.tar.gz
221303b65ffe66f5521b1e049fb296c27761333add36149e92984fc5a456421fa guix-build-8b355c0bb212/output/aarch64-linux-gnu/bitcoin-8b355c0bb212-aarch64-linux-gnu.tar.gz
397cc03384e1c90c97294205ce013086b1ffc750f4b065775e3d595c8f235b054 guix-build-8b355c0bb212/output/arm-linux-gnueabihf/SHA256SUMS.part
4acee06367c912ee2dfc5339a8c61d8093b461a72e922b3db78c89ff315034322 guix-build-8b355c0bb212/output/arm-linux-gnueabihf/bitcoin-8b355c0bb212-arm-linux-gnueabihf-debug.tar.gz
5d250b129e8d1abd97ee1167982c41bda3382e8f38ecd9349331ccfb8d6827d96 guix-build-8b355c0bb212/output/arm-linux-gnueabihf/bitcoin-8b355c0bb212-arm-linux-gnueabihf.tar.gz
6f1030398774d5daf5bade613271ff1f029127ea796a1d86a3f9b23086976f77b guix-build-8b355c0bb212/output/arm64-apple-darwin/SHA256SUMS.part
7de7906780eefee0dd7eb6a40d140792a95c138265043d84501781d6fb46a301a guix-build-8b355c0bb212/output/arm64-apple-darwin/bitcoin-8b355c0bb212-arm64-apple-darwin-unsigned.tar.gz
8f3e9f7bca95611bc9043aac81cec2db285f43459172ee8318de9c457c542a370 guix-build-8b355c0bb212/output/arm64-apple-darwin/bitcoin-8b355c0bb212-arm64-apple-darwin-unsigned.zip
9545e179a5f93d45c94d296b35a06ed41c176d3d00d926eab03d64a5a27e57957 guix-build-8b355c0bb212/output/arm64-apple-darwin/bitcoin-8b355c0bb212-arm64-apple-darwin.tar.gz
106a3c9a7916f7cdd42ec40a124c611c25858b2377b82b7140248572221442f39f guix-build-8b355c0bb212/output/dist-archive/bitcoin-8b355c0bb212.tar.gz
117d694d18050a96aa9bdbe5214ff559b18fa0a472d927f8e520055ccef64f31d0 guix-build-8b355c0bb212/output/powerpc64-linux-gnu/SHA256SUMS.part
125f5724e99f4da966626be6d62aa7d2b399a7dc57fbda646434073a93dce94d54 guix-build-8b355c0bb212/output/powerpc64-linux-gnu/bitcoin-8b355c0bb212-powerpc64-linux-gnu-debug.tar.gz
131653e58aea479ff820aa7cfabfe729377f555b539602505c06fc9b50004ece5e guix-build-8b355c0bb212/output/powerpc64-linux-gnu/bitcoin-8b355c0bb212-powerpc64-linux-gnu.tar.gz
14436b008d782d1c7453082966696ff162c17e7d0924af31d4f2bb718974e5b276 guix-build-8b355c0bb212/output/riscv64-linux-gnu/SHA256SUMS.part
15bb07f0b5d3c9765935d6a77772c499dcaee2ed6f38af7d3dc80ae238ea175c4f guix-build-8b355c0bb212/output/riscv64-linux-gnu/bitcoin-8b355c0bb212-riscv64-linux-gnu-debug.tar.gz
169228f20136ebe9292936fa151c25b04cf10af7a7ead3cd65a9b09a75636201a7 guix-build-8b355c0bb212/output/riscv64-linux-gnu/bitcoin-8b355c0bb212-riscv64-linux-gnu.tar.gz
17d9e38f2a06e885032b6138205d42e39606ebb5b99ba30e94122264c723152d28 guix-build-8b355c0bb212/output/x86_64-apple-darwin/SHA256SUMS.part
18651acd1d68f3d6b64cea39b288131dc3f965ccdc90e686a98eb7ef3b44e2e211 guix-build-8b355c0bb212/output/x86_64-apple-darwin/bitcoin-8b355c0bb212-x86_64-apple-darwin-unsigned.tar.gz
19ef4ccc9ca7f0088537e54bbc77ae250e203b582f75dfca65c3aa4c380fe3362f guix-build-8b355c0bb212/output/x86_64-apple-darwin/bitcoin-8b355c0bb212-x86_64-apple-darwin-unsigned.zip
20fae467ae55385d7643f37051433e5df41ab5b3585e038b981e074ef1f005f35d guix-build-8b355c0bb212/output/x86_64-apple-darwin/bitcoin-8b355c0bb212-x86_64-apple-darwin.tar.gz
21a0e375e56801d037490afa1fe0027ab459b2bccf325d8f6258153ef5949a9ced guix-build-8b355c0bb212/output/x86_64-linux-gnu/SHA256SUMS.part
22c4db06dea76707ebbc7503b08094a718785bf0ea5eea0d25d558d910ac67e941 guix-build-8b355c0bb212/output/x86_64-linux-gnu/bitcoin-8b355c0bb212-x86_64-linux-gnu-debug.tar.gz
23988d8140fef1f0fcdeeea8fb2ccb171b0154ecf4cccf827fdd3614d0a8c7aba1 guix-build-8b355c0bb212/output/x86_64-linux-gnu/bitcoin-8b355c0bb212-x86_64-linux-gnu.tar.gz
24621d35b760ce2ce517c30a75ba6eee95e966d70bdc271e659f39c4531fde5cb2 guix-build-8b355c0bb212/output/x86_64-w64-mingw32/SHA256SUMS.part
2542883d8b6527e697103eca9c97482ba8f448a8bb949ecfe8b717e832e289daeb guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64-debug.zip
26e6dfb81cdf910bf77c7642c290abcb748aa7183f290102fd9f5d5d20818f5752 guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64-setup-unsigned.exe
2764cad0e4275b95456c8a681c157ab85fac2d42fad63120a77ecbfc1bd9ef29d7 guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64-unsigned.tar.gz
28c8affd59df0d3823a35adf39591826de00062bb8d52d9c3e90b182a0a6a7038d guix-build-8b355c0bb212/output/x86_64-w64-mingw32/bitcoin-8b355c0bb212-win64.zip
Can you rebase this on master.
Rebased.
ACK 0004dcc7b136424e5c84c3750e9d6af336b674ed I’ve done complete rebuilds and they look deterministic:
08ed754df1e92d8ffc60cd407f009f6e352eacb5413f9c094feee6991775acff0 guix-build-0004dcc7b136/output/aarch64-linux-gnu/SHA256SUMS.part
1780089965418bdb5fbc37813746f7bf81b16cff7424f0aebe0aeee903a77d0a2 guix-build-0004dcc7b136/output/aarch64-linux-gnu/bitcoin-0004dcc7b136-aarch64-linux-gnu-debug.tar.gz
2a5b702a92b8be730836e0b78b58ffdfa83f623087950d2d0396025945e2df5cf guix-build-0004dcc7b136/output/aarch64-linux-gnu/bitcoin-0004dcc7b136-aarch64-linux-gnu.tar.gz
33dd8ac9ecdcc9ac58f50f9fc2fe62a1b84264841566b157c8fdf9b0140b05a27 guix-build-0004dcc7b136/output/arm-linux-gnueabihf/SHA256SUMS.part
4db6b7a207f8c3f69b2fda2cf58521de3c4f3f371c7ed87a52fad9b4aa2ff8211 guix-build-0004dcc7b136/output/arm-linux-gnueabihf/bitcoin-0004dcc7b136-arm-linux-gnueabihf-debug.tar.gz
565b7a838e1368006232a424a8c811380a46da2fc650b9059f3423a30f36fee8f guix-build-0004dcc7b136/output/arm-linux-gnueabihf/bitcoin-0004dcc7b136-arm-linux-gnueabihf.tar.gz
6718ad3e3526aeb984ca0f01167ea3aa190daa312f134485038fe78453ef16a1d guix-build-0004dcc7b136/output/arm64-apple-darwin/SHA256SUMS.part
76d3b5ef7a04ff98d6e149cbd5adaf40ff8f4ec2afdf52a653414c6a68abb2597 guix-build-0004dcc7b136/output/arm64-apple-darwin/bitcoin-0004dcc7b136-arm64-apple-darwin-unsigned.tar.gz
827b5f4f62107e22499ce3201ea017804cb4f16f6e45c0ad6ff7b04c6aacbfba6 guix-build-0004dcc7b136/output/arm64-apple-darwin/bitcoin-0004dcc7b136-arm64-apple-darwin-unsigned.zip
940a68f09c5bc8d70714038ca21c93eee9836f0d212871b8037ac165b70dd4f62 guix-build-0004dcc7b136/output/arm64-apple-darwin/bitcoin-0004dcc7b136-arm64-apple-darwin.tar.gz
10ce9788fda9dc8e6d929a85e982c145adc6c4c169fd13848dfa6558fe9ac8cf18 guix-build-0004dcc7b136/output/dist-archive/bitcoin-0004dcc7b136.tar.gz
11b47ffc03c23b3c24f2c736f68c099e7cc7b7aecd36311cc79f5eeb92f62c8b81 guix-build-0004dcc7b136/output/powerpc64-linux-gnu/SHA256SUMS.part
12d55667dcdb05665a10fc3e114cf073a163f029f93a806e317d09bf1071e0a8c2 guix-build-0004dcc7b136/output/powerpc64-linux-gnu/bitcoin-0004dcc7b136-powerpc64-linux-gnu-debug.tar.gz
13faf57cd1b7150883c4162f905b564799846ca47d6658a652130fa1e579361395 guix-build-0004dcc7b136/output/powerpc64-linux-gnu/bitcoin-0004dcc7b136-powerpc64-linux-gnu.tar.gz
14eee73be101aee8843c1316ca6f738ecc8238bda9ac8d90c879a710760c2d5256 guix-build-0004dcc7b136/output/riscv64-linux-gnu/SHA256SUMS.part
1507afc1dd58df0d0e5de3f6017a1ec608d1f698bbb36066175b2c7f761adac072 guix-build-0004dcc7b136/output/riscv64-linux-gnu/bitcoin-0004dcc7b136-riscv64-linux-gnu-debug.tar.gz
168c48bfb2ad4484cef33eeb526e9aaa21b60d4f3a43edb134c58af95e9dde491b guix-build-0004dcc7b136/output/riscv64-linux-gnu/bitcoin-0004dcc7b136-riscv64-linux-gnu.tar.gz
177ad09d443be29665ac3c315d6bf384fc94612375c5faa0fef737fa08e02b76d8 guix-build-0004dcc7b136/output/x86_64-apple-darwin/SHA256SUMS.part
189a1c0fbdf2d2ddbefb0aad7f2d1e9598cfce85535943f8d7c6f6caa0d2369db7 guix-build-0004dcc7b136/output/x86_64-apple-darwin/bitcoin-0004dcc7b136-x86_64-apple-darwin-unsigned.tar.gz
194023894c7b5d3fa37a270e1d5cc856ea6bba4148ffc7bcd72ce7a13bcdf0a52c guix-build-0004dcc7b136/output/x86_64-apple-darwin/bitcoin-0004dcc7b136-x86_64-apple-darwin-unsigned.zip
2027d6e677d507b87c560769681233690ea13eb3f1de825896b26ca21d1cca8c31 guix-build-0004dcc7b136/output/x86_64-apple-darwin/bitcoin-0004dcc7b136-x86_64-apple-darwin.tar.gz
2175c3a91bcf6b23137ea7c2591989174476921fd721b2f39af7691211fc61ff32 guix-build-0004dcc7b136/output/x86_64-linux-gnu/SHA256SUMS.part
22ee4b13a7a61e53b650a4ecffedcdf089b6910f87c23d2358b0829c2877e23fc9 guix-build-0004dcc7b136/output/x86_64-linux-gnu/bitcoin-0004dcc7b136-x86_64-linux-gnu-debug.tar.gz
233e7bde371516e6f3088b950f14c1fdcdf63138e5a66d1f23297d2bd0befe01d6 guix-build-0004dcc7b136/output/x86_64-linux-gnu/bitcoin-0004dcc7b136-x86_64-linux-gnu.tar.gz
247ce87abc29f0214765ce367b24dec25f17fc2bedf87e05f9e46fa802accdbdf2 guix-build-0004dcc7b136/output/x86_64-w64-mingw32/SHA256SUMS.part
25436873c4b7254b4a9c715659b6b1122de6345da2a80f3edbf4e176d3f28bc4ef guix-build-0004dcc7b136/output/x86_64-w64-mingw32/bitcoin-0004dcc7b136-win64-debug.zip
2618e2f244fc2bb48450a933b147ae69045cb5a142310e10f03a67bc0754f9511c guix-build-0004dcc7b136/output/x86_64-w64-mingw32/bitcoin-0004dcc7b136-win64-setup-unsigned.exe
273d509f7d68a1d0e2ddc1370ca90fa94cb392d1ac3e40faafc16063fd128067f8 guix-build-0004dcc7b136/output/x86_64-w64-mingw32/bitcoin-0004dcc7b136-win64-unsigned.tar.gz
286dfc539d2898a53cec88f2ddacc1d08d65e70722fb780fd32a6bc188dad71ee0 guix-build-0004dcc7b136/output/x86_64-w64-mingw32/bitcoin-0004dcc7b136-win64.zip