siphash improvement #30759

1. 
   ioavv commented at 7:20 am on August 30, 2024: none
2. 
   DrahtBot commented at 7:20 am on August 30, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept NACK	l0rinc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30442 (optimization: Precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher by l0rinc)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. 
   l0rinc commented at 9:44 am on August 30, 2024: contributor

   NACK 527a217c5ec04d5616b0562e026d6040ef97c3cf

   The change looks arbitrary, isn’t backed by any explanation, measurement, or test, just extracting some common parts for some reason, ignoring why the methods were inlined in the first place.

4. 
   glozow commented at 1:33 pm on August 30, 2024: member

   Thanks for your interest in contributing! I recommend reading the contributing guidelines and developer notes, particularly the section about refactoring.

   As we have hundreds of PRs open right now, I’m closing this to focus review on the others.

5. glozow closed this on Aug 30, 2024

   ---

6. siphash improvement 527a217c5e

Contributors
ioavv DrahtBot l0rinc glozow