Contains a handful of miscellaneous bug fixes. We can drop a few of our patches.
See https://github.com/qt/qtbase/compare/v5.15.14-lts-lgpl...v5.15.16-lts-lgpl.
Contains a handful of miscellaneous bug fixes. We can drop a few of our patches.
See https://github.com/qt/qtbase/compare/v5.15.14-lts-lgpl...v5.15.16-lts-lgpl.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/30774.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | hebasto, TheCharlatan |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
The release announcement says “From now on, the Qt 5.15 patch releases will only be available to subscription license holders.”
But the linked git tree still has open source licenses in the root directory.
Anyone know for sure if we can use it or not?
v5.15.15-lts-lgpl
. It seems to follow the pattern of previous commercial 5.15.x point releases.
Seems fine to do, but wasn’t the idea to use qt6 once cmake was done? IIRC there was a tracking/meta issue, but I can’t find it?
I’m working on migration to Qt 6. I’ll post a few updates soon.
Explicit intention to open source 5.15.16: https://lists.qt-project.org/pipermail/announce/2024-November/000526.html
Probably should reopen this for backports at least?
Guix build (x86_64):
0e80422975315244b3365bf9eddb9e6e5d9da08f4b1a5fba34430c6f3021c6b8a guix-build-31a0e5f0905b/output/aarch64-linux-gnu/SHA256SUMS.part
1db53cd0057bf0048534e3daea2e39130cdf64a140becaa5c6ff4f98fdfa5936a guix-build-31a0e5f0905b/output/aarch64-linux-gnu/bitcoin-31a0e5f0905b-aarch64-linux-gnu-debug.tar.gz
2fa061afbd1dac25c739a63a1644f2af1ad5dab36ea5e4245a7b0bb9008ca4f79 guix-build-31a0e5f0905b/output/aarch64-linux-gnu/bitcoin-31a0e5f0905b-aarch64-linux-gnu.tar.gz
3f286a7442a6fefa036248215c1f2f5a2288bb15d2eee868ee9c7a03a05ac5469 guix-build-31a0e5f0905b/output/arm-linux-gnueabihf/SHA256SUMS.part
41c02128bdbf9d12eda9de96c2d718938d3036c3eed3072069f618e48d0963f8e guix-build-31a0e5f0905b/output/arm-linux-gnueabihf/bitcoin-31a0e5f0905b-arm-linux-gnueabihf-debug.tar.gz
58054b92cd34e86a082e57ed3edaf5742b848779e8845462f47aefcbe79aaa641 guix-build-31a0e5f0905b/output/arm-linux-gnueabihf/bitcoin-31a0e5f0905b-arm-linux-gnueabihf.tar.gz
62a18a632d64ea99b8009a0f9ca6be473fddd7b6d8508a1f94251fe9f32ade8cb guix-build-31a0e5f0905b/output/arm64-apple-darwin/SHA256SUMS.part
7676bea2119ef9b26917b1b67631f3e74ff8d81ca67029b93772bfa1a21991fe7 guix-build-31a0e5f0905b/output/arm64-apple-darwin/bitcoin-31a0e5f0905b-arm64-apple-darwin-unsigned.tar.gz
8bf630880bc1fcf2ad3121ffdc13f1563372e5dd6e59a51db0e7e259a44d11a8b guix-build-31a0e5f0905b/output/arm64-apple-darwin/bitcoin-31a0e5f0905b-arm64-apple-darwin-unsigned.zip
90e6ce2e86098356cc43f3147648bb220b85d89c5039194eb6be1159637be295d guix-build-31a0e5f0905b/output/arm64-apple-darwin/bitcoin-31a0e5f0905b-arm64-apple-darwin.tar.gz
1043603d6758e6c9fd2eb76c934975c0e5083f8e51508ff20a1119a67251d61e0a guix-build-31a0e5f0905b/output/dist-archive/bitcoin-31a0e5f0905b.tar.gz
11006ab0def18d9f91a686a62c96dfdb094d19c5c996c39e8a880eb8c09bf09945 guix-build-31a0e5f0905b/output/powerpc64-linux-gnu/SHA256SUMS.part
1234cfc1c7c4926eeb235b32237d14cea0d7623e858e402eee9b62ce84321b07af guix-build-31a0e5f0905b/output/powerpc64-linux-gnu/bitcoin-31a0e5f0905b-powerpc64-linux-gnu-debug.tar.gz
13251a86bda832ebb3b31aa1b97b0338d5015d1029edfb6ca4f74a1f4bbef5bfd5 guix-build-31a0e5f0905b/output/powerpc64-linux-gnu/bitcoin-31a0e5f0905b-powerpc64-linux-gnu.tar.gz
146dd6e271edecfb216069bc0e102cc2263c94096c47a038ef7861ff6f8bc4c862 guix-build-31a0e5f0905b/output/riscv64-linux-gnu/SHA256SUMS.part
151fa4991c95d2dc4c34541c7ec61c092bdbdc7d04ba3c29c44588288775767514 guix-build-31a0e5f0905b/output/riscv64-linux-gnu/bitcoin-31a0e5f0905b-riscv64-linux-gnu-debug.tar.gz
16c57ddf45d9a1d155574ab788b8734177dc371167406c2a3b5c2373ce0570f242 guix-build-31a0e5f0905b/output/riscv64-linux-gnu/bitcoin-31a0e5f0905b-riscv64-linux-gnu.tar.gz
17b05917146f3a4c0a84f0db7816700b8b90a7eeabe09b33452b9b3c52d93feaa6 guix-build-31a0e5f0905b/output/x86_64-apple-darwin/SHA256SUMS.part
1824188a877353b84a516ccf155b8c1ad6591d190dc6a17944032f6ee7420780e6 guix-build-31a0e5f0905b/output/x86_64-apple-darwin/bitcoin-31a0e5f0905b-x86_64-apple-darwin-unsigned.tar.gz
1952b79cfb958c239e62abd964b8de8eefd0b009330457b21af86c46f03c7e7c03 guix-build-31a0e5f0905b/output/x86_64-apple-darwin/bitcoin-31a0e5f0905b-x86_64-apple-darwin-unsigned.zip
20e636b76d45521ef262449a698aa123164f545b637c621ecd0897d2599425354e guix-build-31a0e5f0905b/output/x86_64-apple-darwin/bitcoin-31a0e5f0905b-x86_64-apple-darwin.tar.gz
21e06597b74c2af88888751573b70d804d5f667e0b97100e61cb84f4317021c696 guix-build-31a0e5f0905b/output/x86_64-linux-gnu/SHA256SUMS.part
223052c419c64ce9c31c68fc715df98e5e068d62baa6291b33a42fe2238e396a69 guix-build-31a0e5f0905b/output/x86_64-linux-gnu/bitcoin-31a0e5f0905b-x86_64-linux-gnu-debug.tar.gz
23f874a8f0592454c13758b7e2bda4f9e36156a33bbb08ed74efbe194beda05539 guix-build-31a0e5f0905b/output/x86_64-linux-gnu/bitcoin-31a0e5f0905b-x86_64-linux-gnu.tar.gz
2433d60285cef11e971017827532743cafae25335a09c862726d5c83a3aa15631c guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/SHA256SUMS.part
25ada14aa9523bbc294ef55f0d73e0f9bd5a7a3aed30b2ef84c9be3a223725c4c9 guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64-debug.zip
2630058ff0240123ff30fbf10b59e4e2c206c2ab946771222e25d81112ea047009 guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64-setup-unsigned.exe
27cfe14230945073e707d5685dc9dc3d4179cec1bff2eb0a6989e38e52f445eb1c guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64-unsigned.tar.gz
28bdf65ea9ecaed6e26a57716810f1ea464200145e04d09373d81886860f02a772 guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64.zip
Guix build (aarch64):
0e80422975315244b3365bf9eddb9e6e5d9da08f4b1a5fba34430c6f3021c6b8a guix-build-31a0e5f0905b/output/aarch64-linux-gnu/SHA256SUMS.part
1db53cd0057bf0048534e3daea2e39130cdf64a140becaa5c6ff4f98fdfa5936a guix-build-31a0e5f0905b/output/aarch64-linux-gnu/bitcoin-31a0e5f0905b-aarch64-linux-gnu-debug.tar.gz
2fa061afbd1dac25c739a63a1644f2af1ad5dab36ea5e4245a7b0bb9008ca4f79 guix-build-31a0e5f0905b/output/aarch64-linux-gnu/bitcoin-31a0e5f0905b-aarch64-linux-gnu.tar.gz
3f286a7442a6fefa036248215c1f2f5a2288bb15d2eee868ee9c7a03a05ac5469 guix-build-31a0e5f0905b/output/arm-linux-gnueabihf/SHA256SUMS.part
41c02128bdbf9d12eda9de96c2d718938d3036c3eed3072069f618e48d0963f8e guix-build-31a0e5f0905b/output/arm-linux-gnueabihf/bitcoin-31a0e5f0905b-arm-linux-gnueabihf-debug.tar.gz
58054b92cd34e86a082e57ed3edaf5742b848779e8845462f47aefcbe79aaa641 guix-build-31a0e5f0905b/output/arm-linux-gnueabihf/bitcoin-31a0e5f0905b-arm-linux-gnueabihf.tar.gz
62a18a632d64ea99b8009a0f9ca6be473fddd7b6d8508a1f94251fe9f32ade8cb guix-build-31a0e5f0905b/output/arm64-apple-darwin/SHA256SUMS.part
7676bea2119ef9b26917b1b67631f3e74ff8d81ca67029b93772bfa1a21991fe7 guix-build-31a0e5f0905b/output/arm64-apple-darwin/bitcoin-31a0e5f0905b-arm64-apple-darwin-unsigned.tar.gz
8bf630880bc1fcf2ad3121ffdc13f1563372e5dd6e59a51db0e7e259a44d11a8b guix-build-31a0e5f0905b/output/arm64-apple-darwin/bitcoin-31a0e5f0905b-arm64-apple-darwin-unsigned.zip
90e6ce2e86098356cc43f3147648bb220b85d89c5039194eb6be1159637be295d guix-build-31a0e5f0905b/output/arm64-apple-darwin/bitcoin-31a0e5f0905b-arm64-apple-darwin.tar.gz
1043603d6758e6c9fd2eb76c934975c0e5083f8e51508ff20a1119a67251d61e0a guix-build-31a0e5f0905b/output/dist-archive/bitcoin-31a0e5f0905b.tar.gz
11006ab0def18d9f91a686a62c96dfdb094d19c5c996c39e8a880eb8c09bf09945 guix-build-31a0e5f0905b/output/powerpc64-linux-gnu/SHA256SUMS.part
1234cfc1c7c4926eeb235b32237d14cea0d7623e858e402eee9b62ce84321b07af guix-build-31a0e5f0905b/output/powerpc64-linux-gnu/bitcoin-31a0e5f0905b-powerpc64-linux-gnu-debug.tar.gz
13251a86bda832ebb3b31aa1b97b0338d5015d1029edfb6ca4f74a1f4bbef5bfd5 guix-build-31a0e5f0905b/output/powerpc64-linux-gnu/bitcoin-31a0e5f0905b-powerpc64-linux-gnu.tar.gz
146dd6e271edecfb216069bc0e102cc2263c94096c47a038ef7861ff6f8bc4c862 guix-build-31a0e5f0905b/output/riscv64-linux-gnu/SHA256SUMS.part
151fa4991c95d2dc4c34541c7ec61c092bdbdc7d04ba3c29c44588288775767514 guix-build-31a0e5f0905b/output/riscv64-linux-gnu/bitcoin-31a0e5f0905b-riscv64-linux-gnu-debug.tar.gz
16c57ddf45d9a1d155574ab788b8734177dc371167406c2a3b5c2373ce0570f242 guix-build-31a0e5f0905b/output/riscv64-linux-gnu/bitcoin-31a0e5f0905b-riscv64-linux-gnu.tar.gz
17b05917146f3a4c0a84f0db7816700b8b90a7eeabe09b33452b9b3c52d93feaa6 guix-build-31a0e5f0905b/output/x86_64-apple-darwin/SHA256SUMS.part
1824188a877353b84a516ccf155b8c1ad6591d190dc6a17944032f6ee7420780e6 guix-build-31a0e5f0905b/output/x86_64-apple-darwin/bitcoin-31a0e5f0905b-x86_64-apple-darwin-unsigned.tar.gz
1952b79cfb958c239e62abd964b8de8eefd0b009330457b21af86c46f03c7e7c03 guix-build-31a0e5f0905b/output/x86_64-apple-darwin/bitcoin-31a0e5f0905b-x86_64-apple-darwin-unsigned.zip
20e636b76d45521ef262449a698aa123164f545b637c621ecd0897d2599425354e guix-build-31a0e5f0905b/output/x86_64-apple-darwin/bitcoin-31a0e5f0905b-x86_64-apple-darwin.tar.gz
21e06597b74c2af88888751573b70d804d5f667e0b97100e61cb84f4317021c696 guix-build-31a0e5f0905b/output/x86_64-linux-gnu/SHA256SUMS.part
223052c419c64ce9c31c68fc715df98e5e068d62baa6291b33a42fe2238e396a69 guix-build-31a0e5f0905b/output/x86_64-linux-gnu/bitcoin-31a0e5f0905b-x86_64-linux-gnu-debug.tar.gz
23f874a8f0592454c13758b7e2bda4f9e36156a33bbb08ed74efbe194beda05539 guix-build-31a0e5f0905b/output/x86_64-linux-gnu/bitcoin-31a0e5f0905b-x86_64-linux-gnu.tar.gz
2433d60285cef11e971017827532743cafae25335a09c862726d5c83a3aa15631c guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/SHA256SUMS.part
25ada14aa9523bbc294ef55f0d73e0f9bd5a7a3aed30b2ef84c9be3a223725c4c9 guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64-debug.zip
2630058ff0240123ff30fbf10b59e4e2c206c2ab946771222e25d81112ea047009 guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64-setup-unsigned.exe
27cfe14230945073e707d5685dc9dc3d4179cec1bff2eb0a6989e38e52f445eb1c guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64-unsigned.tar.gz
28bdf65ea9ecaed6e26a57716810f1ea464200145e04d09373d81886860f02a772 guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64.zip
Approach ACK 31a0e5f0905bfc6b22ceaaeca53466dfd74967ab.
I’ve verified changes in patches/qt
, and they look correct.
Building…
My Guix build:
0aarch64
1e80422975315244b3365bf9eddb9e6e5d9da08f4b1a5fba34430c6f3021c6b8a guix-build-31a0e5f0905b/output/aarch64-linux-gnu/SHA256SUMS.part
2db53cd0057bf0048534e3daea2e39130cdf64a140becaa5c6ff4f98fdfa5936a guix-build-31a0e5f0905b/output/aarch64-linux-gnu/bitcoin-31a0e5f0905b-aarch64-linux-gnu-debug.tar.gz
3fa061afbd1dac25c739a63a1644f2af1ad5dab36ea5e4245a7b0bb9008ca4f79 guix-build-31a0e5f0905b/output/aarch64-linux-gnu/bitcoin-31a0e5f0905b-aarch64-linux-gnu.tar.gz
4f286a7442a6fefa036248215c1f2f5a2288bb15d2eee868ee9c7a03a05ac5469 guix-build-31a0e5f0905b/output/arm-linux-gnueabihf/SHA256SUMS.part
51c02128bdbf9d12eda9de96c2d718938d3036c3eed3072069f618e48d0963f8e guix-build-31a0e5f0905b/output/arm-linux-gnueabihf/bitcoin-31a0e5f0905b-arm-linux-gnueabihf-debug.tar.gz
68054b92cd34e86a082e57ed3edaf5742b848779e8845462f47aefcbe79aaa641 guix-build-31a0e5f0905b/output/arm-linux-gnueabihf/bitcoin-31a0e5f0905b-arm-linux-gnueabihf.tar.gz
72a18a632d64ea99b8009a0f9ca6be473fddd7b6d8508a1f94251fe9f32ade8cb guix-build-31a0e5f0905b/output/arm64-apple-darwin/SHA256SUMS.part
8676bea2119ef9b26917b1b67631f3e74ff8d81ca67029b93772bfa1a21991fe7 guix-build-31a0e5f0905b/output/arm64-apple-darwin/bitcoin-31a0e5f0905b-arm64-apple-darwin-unsigned.tar.gz
9bf630880bc1fcf2ad3121ffdc13f1563372e5dd6e59a51db0e7e259a44d11a8b guix-build-31a0e5f0905b/output/arm64-apple-darwin/bitcoin-31a0e5f0905b-arm64-apple-darwin-unsigned.zip
100e6ce2e86098356cc43f3147648bb220b85d89c5039194eb6be1159637be295d guix-build-31a0e5f0905b/output/arm64-apple-darwin/bitcoin-31a0e5f0905b-arm64-apple-darwin.tar.gz
1143603d6758e6c9fd2eb76c934975c0e5083f8e51508ff20a1119a67251d61e0a guix-build-31a0e5f0905b/output/dist-archive/bitcoin-31a0e5f0905b.tar.gz
12006ab0def18d9f91a686a62c96dfdb094d19c5c996c39e8a880eb8c09bf09945 guix-build-31a0e5f0905b/output/powerpc64-linux-gnu/SHA256SUMS.part
1334cfc1c7c4926eeb235b32237d14cea0d7623e858e402eee9b62ce84321b07af guix-build-31a0e5f0905b/output/powerpc64-linux-gnu/bitcoin-31a0e5f0905b-powerpc64-linux-gnu-debug.tar.gz
14251a86bda832ebb3b31aa1b97b0338d5015d1029edfb6ca4f74a1f4bbef5bfd5 guix-build-31a0e5f0905b/output/powerpc64-linux-gnu/bitcoin-31a0e5f0905b-powerpc64-linux-gnu.tar.gz
156dd6e271edecfb216069bc0e102cc2263c94096c47a038ef7861ff6f8bc4c862 guix-build-31a0e5f0905b/output/riscv64-linux-gnu/SHA256SUMS.part
161fa4991c95d2dc4c34541c7ec61c092bdbdc7d04ba3c29c44588288775767514 guix-build-31a0e5f0905b/output/riscv64-linux-gnu/bitcoin-31a0e5f0905b-riscv64-linux-gnu-debug.tar.gz
17c57ddf45d9a1d155574ab788b8734177dc371167406c2a3b5c2373ce0570f242 guix-build-31a0e5f0905b/output/riscv64-linux-gnu/bitcoin-31a0e5f0905b-riscv64-linux-gnu.tar.gz
18b05917146f3a4c0a84f0db7816700b8b90a7eeabe09b33452b9b3c52d93feaa6 guix-build-31a0e5f0905b/output/x86_64-apple-darwin/SHA256SUMS.part
1924188a877353b84a516ccf155b8c1ad6591d190dc6a17944032f6ee7420780e6 guix-build-31a0e5f0905b/output/x86_64-apple-darwin/bitcoin-31a0e5f0905b-x86_64-apple-darwin-unsigned.tar.gz
2052b79cfb958c239e62abd964b8de8eefd0b009330457b21af86c46f03c7e7c03 guix-build-31a0e5f0905b/output/x86_64-apple-darwin/bitcoin-31a0e5f0905b-x86_64-apple-darwin-unsigned.zip
21e636b76d45521ef262449a698aa123164f545b637c621ecd0897d2599425354e guix-build-31a0e5f0905b/output/x86_64-apple-darwin/bitcoin-31a0e5f0905b-x86_64-apple-darwin.tar.gz
22e06597b74c2af88888751573b70d804d5f667e0b97100e61cb84f4317021c696 guix-build-31a0e5f0905b/output/x86_64-linux-gnu/SHA256SUMS.part
233052c419c64ce9c31c68fc715df98e5e068d62baa6291b33a42fe2238e396a69 guix-build-31a0e5f0905b/output/x86_64-linux-gnu/bitcoin-31a0e5f0905b-x86_64-linux-gnu-debug.tar.gz
24f874a8f0592454c13758b7e2bda4f9e36156a33bbb08ed74efbe194beda05539 guix-build-31a0e5f0905b/output/x86_64-linux-gnu/bitcoin-31a0e5f0905b-x86_64-linux-gnu.tar.gz
2533d60285cef11e971017827532743cafae25335a09c862726d5c83a3aa15631c guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/SHA256SUMS.part
26ada14aa9523bbc294ef55f0d73e0f9bd5a7a3aed30b2ef84c9be3a223725c4c9 guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64-debug.zip
2730058ff0240123ff30fbf10b59e4e2c206c2ab946771222e25d81112ea047009 guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64-setup-unsigned.exe
28cfe14230945073e707d5685dc9dc3d4179cec1bff2eb0a6989e38e52f445eb1c guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64-unsigned.tar.gz
29bdf65ea9ecaed6e26a57716810f1ea464200145e04d09373d81886860f02a772 guix-build-31a0e5f0905b/output/x86_64-w64-mingw32/bitcoin-31a0e5f0905b-win64.zip