depends: Qt 5.15.15 #30774

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends_qt_5_15_15 changing 1 files +4 −4

fanquake commented at 5:03 pm on August 30, 2024: member

Contains a handful of miscellaneous bug fixes. Looks like we can’t actually drop any of our current patchset.

See https://github.com/qt/qtbase/commit/ca725ad9c5331a657c328bf624f2b0b713623276#diff-4b24dab5fb18745d42d7a3ab3fdd4e75d57493f5f14c761629aec6c44d72444b for the full diff.
DrahtBot commented at 5:03 pm on August 30, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
DrahtBot added the label Build system on Aug 30, 2024
fanquake added the label DrahtBot Guix build requested on Aug 30, 2024

DrahtBot commented at 2:48 am on August 31, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 96b0a8f858ab24f3672360b8c830553b963de726(master)	commit 1162eb553ca88adfc11cbf00dd88b4fd6207216d(master and this pull)
SHA256SUMS.part	`27365d9d56b05cce...`	`6cf9903817762dd6...`
*-aarch64-linux-gnu-debug.tar.gz	`04a5bb232114f782...`	`a96ded9b8e3d1929...`
*-aarch64-linux-gnu.tar.gz	`bd5d23a64ab7d779...`	`76ae59ea7d900233...`
*-arm-linux-gnueabihf-debug.tar.gz	`0021ca776f7dcc8b...`	`65a82aed7280c385...`
*-arm-linux-gnueabihf.tar.gz	`2340d1119a1ec632...`	`2568315da339a634...`
*-arm64-apple-darwin-unsigned.tar.gz	`ab00b80f00cd09b8...`	`59c5931aefb67bb4...`
*-arm64-apple-darwin-unsigned.zip	`cb84320f60e26fed...`	`fb90d217321200bf...`
*-arm64-apple-darwin.tar.gz	`a1a2786cfcecd350...`	`9464d99379e13f44...`
*-powerpc64-linux-gnu-debug.tar.gz	`9544adef5060dfab...`	`8269ed5bca681269...`
*-powerpc64-linux-gnu.tar.gz	`faf390f38f51cc68...`	`e5051a4d2d9e80be...`
*-riscv64-linux-gnu-debug.tar.gz	`67b921646742efc8...`	`792d7ae33028786b...`
*-riscv64-linux-gnu.tar.gz	`c4759b761c171f92...`	`5e8cd437d58bbfb0...`
*-x86_64-apple-darwin-unsigned.tar.gz	`459ba0d98d89d678...`	`cb1defebe712a0e6...`
*-x86_64-apple-darwin-unsigned.zip	`d19b0e188ac78eb6...`	`7c30f14061d7d1d7...`
*-x86_64-apple-darwin.tar.gz	`7b3f41e90375e361...`	`8592b9cdc63be69d...`
*-x86_64-linux-gnu-debug.tar.gz	`a1c953af5210e0d6...`	`a399b520fc736ce1...`
*-x86_64-linux-gnu.tar.gz	`5d74858c83c440f2...`	`a2ee09c1ad4331a5...`
*.tar.gz	`b3128d336e5c9680...`	`0b61c69bebb10c1e...`
guix_build.log	`3e54d141b4a84788...`	`69b076b65b69a5b9...`
guix_build.log.diff		`59e738642df05542...`

DrahtBot removed the label DrahtBot Guix build requested on Aug 31, 2024
maflcko commented at 8:26 am on September 2, 2024: member

Seems fine to do, but wasn’t the idea to use qt6 once cmake was done? IIRC there was a tracking/meta issue, but I can’t find it?
luke-jr commented at 7:14 pm on September 2, 2024: member

The release announcement says “From now on, the Qt 5.15 patch releases will only be available to subscription license holders.”

But the linked git tree still has open source licenses in the root directory.

Anyone know for sure if we can use it or not?
tobtoht commented at 8:28 pm on September 2, 2024: none
@luke-jr Due to an agreement with KDE, Qt is required to license releases under LGPL within one year. I can imagine they do not like reminding paying subscribers of this.

See:
- https://www.qt.io/faq/3.2.-why-do-you-have-an-agreement-with-kde-about-your-licensing-what-kde-is-and-whats-the-history-of-qt-and-kde
- https://kde.org/community/whatiskde/Software_License_Agreement_2015_Text.pdf (Specifically section 3 II)
luke-jr commented at 8:34 pm on September 2, 2024: member

My understanding is that the agreement relaxes the license on the existing public version (in this context, 5.15.14) in the event that Qt does not release the next version (5.15.15) under the GPL. It is not a guarantee that 5.15.15 will be itself be released under the GPL, and certainly not immediately upon release of 5.15.15.
tobtoht commented at 9:02 pm on September 2, 2024: none

5.15.15 was released last year on August 31, 2023. The git tag for this release is v5.15.15-lts-lgpl. It seems to follow the pattern of previous commercial 5.15.x point releases.
DrahtBot added the label CI failed on Sep 7, 2024
DrahtBot removed the label CI failed on Sep 13, 2024
depends: Qt 5.15.15 acf8b52a59
fanquake marked this as ready for review on Sep 17, 2024
fanquake force-pushed on Sep 17, 2024
fanquake commented at 9:33 am on September 17, 2024: member

but wasn’t the idea to use qt6 once cmake was done? IIRC there was a tracking/meta issue, but I can’t find it?

Maybe #24798? It’s not really clear what the status of any migration is.
fanquake added the label DrahtBot Guix build requested on Sep 17, 2024

DrahtBot commented at 1:09 am on September 18, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 6fc4692797121b54de0c54e5b09ee47f322c038a(master)	commit eab3b1e01653931fb53461ebfb1e0438a4c35456(master and this pull)
SHA256SUMS.part	`9e989cdafbceebeb...`	`c00ee9aa5d10f7d7...`
*-aarch64-linux-gnu-debug.tar.gz	`f3254cc7cf92d258...`	`6112be44525fae39...`
*-aarch64-linux-gnu.tar.gz	`e14c6b51123636a9...`	`7c333d50126496b3...`
*-arm-linux-gnueabihf-debug.tar.gz	`ce38e5b5c8bf2cc7...`	`2a8e712681450c76...`
*-arm-linux-gnueabihf.tar.gz	`196aa0730c393d64...`	`0516c86a00a0f51d...`
*-arm64-apple-darwin-unsigned.tar.gz	`a0db5d2981514b9c...`	`4885ed5d9ad5132f...`
*-arm64-apple-darwin-unsigned.zip	`7aa95aa40988c1d3...`	`968b86e6a78a383e...`
*-arm64-apple-darwin.tar.gz	`196b2d4a5cd3d1bc...`	`72a917d3eef01ae1...`
*-powerpc64-linux-gnu-debug.tar.gz	`9cbc8740919d2b90...`	`65f18caae5fe7f77...`
*-powerpc64-linux-gnu.tar.gz	`893e4b2909eff3af...`	`c9138a039b0a8983...`
*-riscv64-linux-gnu-debug.tar.gz	`6256fe7c347eb389...`	`c50ffacba2744099...`
*-riscv64-linux-gnu.tar.gz	`cfb564bad3bae138...`	`e69d964054d7bc4b...`
*-x86_64-apple-darwin-unsigned.tar.gz	`45ed54046a2bb856...`	`aee1735b6f3f8bb8...`
*-x86_64-apple-darwin-unsigned.zip	`1de15863b17ec133...`	`4eb6389c14c65d51...`
*-x86_64-apple-darwin.tar.gz	`705bfd0dfd6ec616...`	`9777bc7c12f1d830...`
*-x86_64-linux-gnu-debug.tar.gz	`16a140f4e260b926...`	`e6a95d593a8f9005...`
*-x86_64-linux-gnu.tar.gz	`3139f3559eb6c55b...`	`1b5d14d2783af9e0...`
*.tar.gz	`a93f0fce40a63735...`	`9f59b3e4c473225c...`
guix_build.log	`4cca6ba221212578...`	`dd0288dac0a31adf...`
guix_build.log.diff		`485e8ee749e43497...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 18, 2024
hebasto commented at 8:15 am on September 18, 2024: member

Seems fine to do, but wasn’t the idea to use qt6 once cmake was done? IIRC there was a tracking/meta issue, but I can’t find it?

I’m working on migration to Qt 6. I’ll post a few updates soon.
fanquake closed this on Sep 20, 2024

Contributors
fanquake DrahtBot maflcko luke-jr tobtoht hebasto

Labels
Build system

depends: Qt 5.15.15 #30774

Code Coverage

Reviews

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]