doc: add -DWITH_BDB=ON to unix build docs #30779

1. 
   tdb3 commented at 9:06 pm on August 31, 2024: contributor

   Existing instructions for building legacy wallet support omit -DWITH_BDB=ON, which results in:

   0CMake Warning:
   1  Manually-specified variables were not used by the project:
   2
   3    BerkeleyDB_INCLUDE_DIR
   

   and a build without BDB support.

   This PR updates the docs to include -DWITH_BDB=ON. Also adds a minor correction to the OpenBSD build doc.

   Checked by building on Linux (Debian 12.7), FreeBSD 14.1, and OpenBSD 7.5 and attempting to create a legacy wallet with the createwallet rpc (with -deprecatedrpc=create_bdb).

2. doc: add with_bdb to unix build docs bc532c915e
3. 
   DrahtBot commented at 9:06 pm on August 31, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	l0rinc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Docs on Aug 31, 2024
5. tdb3 marked this as ready for review on Aug 31, 2024
6. doc: remove extraneous install statement ddef914bbb
7. tdb3 force-pushed on Aug 31, 2024
8. l0rinc approved
9. 
   l0rinc commented at 4:28 pm on September 1, 2024: contributor

   utACK ddef914bbb1e4fe87e8a85f17e4e839639fd97da

   Should we maybe warn in FindBerkeleyDB.cmake when BerkeleyDB_INCLUDE_DIR was set?

10. 
    hebasto commented at 4:35 pm on September 1, 2024: member

    Should we maybe warn in FindBerkeleyDB.cmake when BerkeleyDB_INCLUDE_DIR was set?

    The <Package>_INCLUDE_DIR are standard CMake variables. And other package Find Modules do not print any warnings. So, introducing any new warning for the BerkeleyDB package would be inconsistent with others.

11. fanquake approved
12. 
    fanquake commented at 1:53 pm on September 2, 2024: member

    ACK ddef914bbb1e4fe87e8a85f17e4e839639fd97da
13. fanquake merged this on Sep 2, 2024
14. fanquake closed this on Sep 2, 2024

    ---

Contributors
tdb3 DrahtBot l0rinc hebasto fanquake

Labels
Docs