Improve loadwallet doc #30780

pull AleJunior-Git wants to merge 2 commits into bitcoin:master from AleJunior-Git:improve-loadwallet-doc changing 1 files +4 −2
  1. AleJunior-Git commented at 10:11 pm on August 31, 2024: none

    Title: Improve documentation of the filename parameter in loadwallet RPC

    This PR addresses issue #30269 . The documentation for the loadwallet RPC has been improved to clarify that the filename parameter should be provided as a relative path from the wallet directory (~/.bitcoin/regtest/wallets). Additionally, two examples were added to demonstrate how to load a wallet from a different directory.

    These changes aim to make the usage of the filename parameter more intuitive and prevent potential confusion for users. Please review the modifications and let me know if any further adjustments are needed. Thanks!

  2. rpc: Improve description of filename parameter in loadwallet 7ae92bd7ee
  3. rpc: Improve description of filename parameter in loadwallet 40ea9ebc23
  4. DrahtBot commented at 10:11 pm on August 31, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30302 (doc: clarify loadwallet path loading for wallets by am-sq)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. DrahtBot added the label CI failed on Aug 31, 2024
  6. DrahtBot commented at 11:27 pm on August 31, 2024: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/29517871492

    Make sure to run all tests locally, according to the documentation.

    The failure may happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  7. maflcko commented at 6:21 am on September 2, 2024: member
    Looks like this is a duplicate of #30269 (comment), also mentioned here: #30780 (comment). So I’ll close this for now.
  8. maflcko closed this on Sep 2, 2024

  9. AleJunior-Git deleted the branch on Sep 3, 2024
  10. AleJunior-Git restored the branch on Sep 3, 2024
  11. AleJunior-Git deleted the branch on Sep 3, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me