bench: Remove redundant logging benchmarks #30790

1. 
   maflcko commented at 3:01 pm on September 2, 2024: member

   LogPrint*ThreadNames is redundant with LogWith(out)ThreadNames, because they all measure toggling the thread names (and check that it has no effect on performance).

   Fix it by removing the redundant ones. This also allows to drop a deprecated logging alias.

2. 
   DrahtBot commented at 11:13 pm on September 2, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

3. bench: Use LogInfo instead of the deprecated alias LogPrintf fa8dd952e2
4. bench: Remove redundant logging benchmarks

   LogPrint*ThreadNames is redundant with LogWith(out)ThreadNames, because
   they all measure toggling the thread names (and check that it has no
   effect on performance).
   
   This also allows to remove unused and deprecated macros.

   fadbcd51fc
5. maflcko force-pushed on Sep 5, 2024
6. fanquake requested review from stickies-v on Sep 5, 2024
7. stickies-v approved
8. 
   stickies-v commented at 4:31 pm on September 5, 2024: contributor

   ACK fadbcd51fc77a3f4e877851463f3c7425fb751d2

   Logging conditionality is orthogonal to the performance effect of logging threadnames, so just keeping the unconditional one makes sense. Removing the now unused LogPrintfCategory is a nice cleanup.

9. fanquake merged this on Sep 6, 2024
10. fanquake closed this on Sep 6, 2024

    ---

11. maflcko deleted the branch on Sep 6, 2024

Contributors
maflcko DrahtBot stickies-v