doc: Clarify libbitcoin_consensus in design/libraries.md #30802

1. 
   maflcko commented at 5:07 pm on September 3, 2024: member

   Now that the shared library has been removed in commit 80f8b92f4f2311b9e9a25361c9dd973244e6f95c, update the documentation to drop the no-longer applicable prefix “Stable…”.
2. 
   DrahtBot commented at 5:07 pm on September 3, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, fanquake
   Stale ACK	TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28690 (build: Introduce internal kernel library by TheCharlatan)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Docs on Sep 3, 2024
4. TheCharlatan approved
5. 
   TheCharlatan commented at 5:20 pm on September 3, 2024: contributor

   ACK fad22fcc83bc009a8c3892cac3570cd399ae28f7
6. in doc/design/libraries.md:7 in fad22fcc83 outdated

   3@@ -4,7 +4,7 @@
   4 |--------------------------|-------------|
   5 | *libbitcoin_cli*         | RPC client functionality used by *bitcoin-cli* executable |
   6 | *libbitcoin_common*      | Home for common functionality shared by different executables and libraries. Similar to *libbitcoin_util*, but higher-level (see [Dependencies](#dependencies)). |
   7-| *libbitcoin_consensus*   | Stable, backwards-compatible consensus functionality used by *libbitcoin_node* and *libbitcoin_wallet*. |
   8+| *libbitcoin_consensus*   | Consensus functionality used by *libbitcoin_common* and *libbitcoin_kernel*. |
   

   ---

   ---

   

   hebasto commented at 5:26 pm on September 3, 2024:

   Why libbitcoin_node removed? The diagram below still shows this dependency.

   ---

   

   maflcko commented at 5:31 pm on September 3, 2024:

   Well, it is used by everything that uses common. Probably best to just refer to the diagram.

   Let me know if I should remove the “used by” completely.

   ---

   

   maflcko commented at 5:36 pm on September 3, 2024:

   Actually, reverted. Can be changed in the future, if there is need to.
7. 
   hebasto commented at 5:26 pm on September 3, 2024: member

   Concept ACK.
8. doc: Clarify libbitcoin_consensus in design/libraries.md fa78ed83be
9. maflcko force-pushed on Sep 3, 2024
10. hebasto approved
11. 
    hebasto commented at 5:53 pm on September 3, 2024: member

    ACK fa78ed83be1f6831416a6f6632e2161f12d359e4.
12. DrahtBot requested review from TheCharlatan on Sep 3, 2024
13. fanquake approved
14. 
    fanquake commented at 9:12 am on September 4, 2024: member

    ACK fa78ed83be1f6831416a6f6632e2161f12d359e4
15. fanquake merged this on Sep 4, 2024
16. fanquake closed this on Sep 4, 2024

    ---

17. maflcko deleted the branch on Sep 4, 2024

Contributors
maflcko DrahtBot TheCharlatan hebasto fanquake

Review Requested
TheCharlatan

Labels
Docs