build: Unify `-logsourcelocations` format

hebasto commented at 7:02 am on September 4, 2024: member

0$ ./build/src/bitcoind -logsourcelocations -asmap=/tmp/no_file 2>&1 | head -1
12024-11-04T11:40:36Z [init/common.cpp:149] [LogPackageVersion] Bitcoin Core version v28.99.0-788c1324f3d8 (release build)

hebasto added the label Build system on Sep 4, 2024

DrahtBot commented at 7:02 am on September 4, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/30811.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	maflcko, fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#31053 (RFC: build: support for pre-compiled headers. by theuni)
#30861 (build: Improve ccache performance for different build directories by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

in CMakeLists.txt:469 in b94fe85fbe outdated

465@@ -466,6 +466,11 @@ configure_file(contrib/filter-lcov.py filter-lcov.py COPYONLY)
466 # Don't allow extended (non-ASCII) symbols in identifiers. This is easier for code review.
467 try_append_cxx_flags("-fno-extended-identifiers" TARGET core_interface SKIP_LINK)
468 
469+# Unify -logsourcelocations format.

maflcko commented at 7:11 am on September 4, 2024:

This isn’t the only reason. The other is ccache, see commit 7abac98d3e3c1bc8ad66cb5c05184b9c5cc674d5. It would be good to mention this.

Ref: https://gcc.gnu.org/onlinedocs/gcc/Overall-Options.html#index-ffile-prefix-map

hebasto commented at 7:33 am on September 4, 2024:

Sure! The comment has been extended.

hebasto force-pushed on Sep 4, 2024

maflcko commented at 7:41 am on September 4, 2024: member

According to https://reproducible-builds.org/docs/build-path/ “-ffile-prefix-map=OLD=NEW is an alias for both -fdebug-prefix-map and -fmacro-prefix-map. (available since GCC 8 and Clang 10)”. Ref https://gcc.gnu.org/onlinedocs/gcc/Overall-Options.html#index-ffile-prefix-map and https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-ffile-prefix-map

review ACK 93a0c2da34b45aaf0aab23c5f1b66cb32df06507

maflcko added the label DrahtBot Guix build requested on Sep 4, 2024

DrahtBot commented at 6:02 pm on September 4, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 4835bba2cb1350259c20bf0faf852187203ba336(master)	commit 3c4b2350d8d9ca64a2cf67adff405a2bb3738735(master and this pull)
SHA256SUMS.part	`78d20f646eafaa88...`	`da70eef0f8609f86...`
*-aarch64-linux-gnu-debug.tar.gz	`d02ba5e3d8648cc9...`	`97837c402cecbf92...`
*-aarch64-linux-gnu.tar.gz	`a6ebfa98ce0de3da...`	`fd7aa68c21b1eb74...`
*-arm-linux-gnueabihf-debug.tar.gz	`af186067da838139...`	`d5b51832ca9fab7a...`
*-arm-linux-gnueabihf.tar.gz	`8298e07f334b9bee...`	`0eb791e19f395c75...`
*-arm64-apple-darwin-unsigned.tar.gz	`e41563ef32423f38...`	`ea92656fd016276a...`
*-arm64-apple-darwin-unsigned.zip	`6c1b25aef48f687c...`	`98668506c7ec700d...`
*-arm64-apple-darwin.tar.gz	`32b9cc93428696dd...`	`0472599e5127b7fe...`
*-powerpc64-linux-gnu-debug.tar.gz	`850bef88a9dc7b0a...`	`b911b01e58febfab...`
*-powerpc64-linux-gnu.tar.gz	`da72ffef016769a5...`	`a64af9eb695aed3b...`
*-riscv64-linux-gnu-debug.tar.gz	`ea775c037fadd66e...`	`8111475d4b0216dc...`
*-riscv64-linux-gnu.tar.gz	`c33f8b226ece66bf...`	`300f6c8f139000a5...`
*-x86_64-apple-darwin-unsigned.tar.gz	`d83e03380adf065a...`	`4a33849d4b10704e...`
*-x86_64-apple-darwin-unsigned.zip	`5b848a74156133ab...`	`17af57016e789b35...`
*-x86_64-apple-darwin.tar.gz	`3b3d9ba23f76ba21...`	`b2a453b325554ea2...`
*-x86_64-linux-gnu-debug.tar.gz	`e973d85c26ccfcbf...`	`7ead0e47e7b94693...`
*-x86_64-linux-gnu.tar.gz	`c5b7c0d81c3b4232...`	`e3a9507135ecfdb8...`
*.tar.gz	`fe44e94c04cb7dba...`	`737d25e54f8364f3...`
guix_build.log	`741268c610dc68eb...`	`862ebb09975b1090...`
guix_build.log.diff		`5e6264e6afb391cb...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 4, 2024

maflcko commented at 9:52 am on September 5, 2024: member

Upgrading my review with a logsourcelocations test on Linux (compiled and guix) binaries. I did not test macOS/Windows (compiled and guix) binaries.

However, ccache does not hit across two different build dirs, compiling the same commit.

in CMakeLists.txt:471 in 93a0c2da34 outdated

465@@ -466,6 +466,14 @@ configure_file(contrib/filter-lcov.py filter-lcov.py COPYONLY)
466 # Don't allow extended (non-ASCII) symbols in identifiers. This is easier for code review.
467 try_append_cxx_flags("-fno-extended-identifiers" TARGET core_interface SKIP_LINK)
468 
469+# Make builds location independent. This helps to:
470+#  1. Unify the -logsourcelocations format.
471+#  2. Improve ccache efficiency across different directories.

maflcko commented at 9:54 am on September 5, 2024:

Can you explain this. How would this be tested?

I tried with cmake -B ./bld-1-cmake and cmake -B ./bld-2-cmake and it did not work.

fanquake commented at 10:14 am on September 5, 2024:

I also tried testing. It doesn’t seem to work, because the -I argument passed to the compiler contains the full path/to/the/src directory, which means the compiler invocations differ, and ccache wont hit?

maflcko commented at 10:44 am on September 5, 2024:

Ah, thanks for testing. I guess this is a possible cmake regression, but I haven’t ever used different dirs with autotools, so I can’t say for sure.

Seems fine to fix here, or in a follow-up, as this pull request is an improvement already and this bug already exists in current master.

DrahtBot added the label CI failed on Sep 7, 2024

hebasto commented at 11:57 am on September 10, 2024: member

However, ccache does not hit across two different build dirs, compiling the same commit.

Fixed in #30861.

hebasto marked this as a draft on Sep 10, 2024

DrahtBot removed the label CI failed on Sep 13, 2024

fanquake commented at 10:31 am on October 30, 2024: member

I think you could just remove the doc block being added here, and then this can go ahead (also rebase). Doesn’t seem like it needs to be blocked on #30861, if that is why it was drafted.

build: Unify `-logsourcelocations` format 788c1324f3

hebasto force-pushed on Nov 4, 2024

hebasto commented at 11:33 am on November 4, 2024: member

Rebased.

Addressed #30811 (comment).

Undrafted.

hebasto marked this as ready for review on Nov 4, 2024

maflcko commented at 11:55 am on November 4, 2024: member

re-ACK 788c1324f3d840f7a39b8bc3537dcff26ca0b552

Only change is dropping doc blob.

Didn’t test locally.

maflcko added the label DrahtBot Guix build requested on Nov 4, 2024

DrahtBot added the label CI failed on Nov 4, 2024

DrahtBot removed the label CI failed on Nov 4, 2024

fanquake commented at 4:12 pm on November 5, 2024: member

Guix build:

 067b7e95e0f1d45debad8a8cac4c2d349e3e01efcf62e0b109345896f296758d9  guix-build-788c1324f3d8/output/aarch64-linux-gnu/SHA256SUMS.part
 1cd3c67eaa5f6fadf0a73cdb1aa03563d720fc7fdae1b59aa495a0eda9d2695af  guix-build-788c1324f3d8/output/aarch64-linux-gnu/bitcoin-788c1324f3d8-aarch64-linux-gnu-debug.tar.gz
 25c1eb4ff827336a9d113497459981e213844b87e232c33fc00317ce20302f761  guix-build-788c1324f3d8/output/aarch64-linux-gnu/bitcoin-788c1324f3d8-aarch64-linux-gnu.tar.gz
 3dd78923f8fb7410afbbb0f510510fadce022829a163c7399d977f925a9025694  guix-build-788c1324f3d8/output/arm-linux-gnueabihf/SHA256SUMS.part
 45eb0ae9e992184203b5c243ee1c7ba4d3e232c0c08f396f0f28d1a9e2a58b265  guix-build-788c1324f3d8/output/arm-linux-gnueabihf/bitcoin-788c1324f3d8-arm-linux-gnueabihf-debug.tar.gz
 576477f3dd1f1ee9f4382a5314620fb509ac0d235c6f0a4bea34acbbad333176e  guix-build-788c1324f3d8/output/arm-linux-gnueabihf/bitcoin-788c1324f3d8-arm-linux-gnueabihf.tar.gz
 67a0463a4e5378428d388cbc2ecec5ea25318e5f168c6e80c082600303f2e6043  guix-build-788c1324f3d8/output/arm64-apple-darwin/SHA256SUMS.part
 7ea2d0784f0cdedf9007794b319dc794715df3d01223e04c53b83d01c762b254c  guix-build-788c1324f3d8/output/arm64-apple-darwin/bitcoin-788c1324f3d8-arm64-apple-darwin-unsigned.tar.gz
 8a14b9148628d98768c9d843a6a9992956453f29e6958f7132a1475a07cfb784c  guix-build-788c1324f3d8/output/arm64-apple-darwin/bitcoin-788c1324f3d8-arm64-apple-darwin-unsigned.zip
 90908b08212f2c8042daf0faaecdd74e1ec07fd21bd015eb1711ef4ab130541ca  guix-build-788c1324f3d8/output/arm64-apple-darwin/bitcoin-788c1324f3d8-arm64-apple-darwin.tar.gz
10ea08a888a5e23ea6c3a76e62cb76283272cf421beeca1f69b03d8a4604ebd906  guix-build-788c1324f3d8/output/dist-archive/bitcoin-788c1324f3d8.tar.gz
1155c058bda5e9f3748f87ece901393f8f424a8d956a08b4c4694917ff315da8b1  guix-build-788c1324f3d8/output/powerpc64-linux-gnu/SHA256SUMS.part
12f9620301f158a7af67fe9d45c4ae232bedea46073f1561e4ea8c85a36644a237  guix-build-788c1324f3d8/output/powerpc64-linux-gnu/bitcoin-788c1324f3d8-powerpc64-linux-gnu-debug.tar.gz
134ff65ca3228a2ffa55896129e400b57dbe458bc9684ad9671f7d787816108504  guix-build-788c1324f3d8/output/powerpc64-linux-gnu/bitcoin-788c1324f3d8-powerpc64-linux-gnu.tar.gz
14958fd22f99a7c7a407f224966c9041322188ee7a2fdbaf708c6d8bbb2b30aca2  guix-build-788c1324f3d8/output/riscv64-linux-gnu/SHA256SUMS.part
1542c73ff53f72104256ec091ce4818d97c21ce0b8e66b6f2e56cea7b0fae3c2d1  guix-build-788c1324f3d8/output/riscv64-linux-gnu/bitcoin-788c1324f3d8-riscv64-linux-gnu-debug.tar.gz
164ea5c652c7cfc350357888d3b829ed7560fe8c88a20c15f605883fe207494ad4  guix-build-788c1324f3d8/output/riscv64-linux-gnu/bitcoin-788c1324f3d8-riscv64-linux-gnu.tar.gz
175a17a9d9bca5617c140d887730e6daffd63a02d42f00c228019bab71beaf7c60  guix-build-788c1324f3d8/output/x86_64-apple-darwin/SHA256SUMS.part
188db48ccd3e540ae3bbf4ef087f8780bfe6378906e16122b27017aeec048f7254  guix-build-788c1324f3d8/output/x86_64-apple-darwin/bitcoin-788c1324f3d8-x86_64-apple-darwin-unsigned.tar.gz
190b9f1c0da2162f43ee8ae781abb6e5d77efc3c32dde4f0e378e6affba33a06f6  guix-build-788c1324f3d8/output/x86_64-apple-darwin/bitcoin-788c1324f3d8-x86_64-apple-darwin-unsigned.zip
200e96d40336f04468624eb48d2fad58e7c44d7e5e778a48c8dd2e025adfa09f28  guix-build-788c1324f3d8/output/x86_64-apple-darwin/bitcoin-788c1324f3d8-x86_64-apple-darwin.tar.gz
2117ee609ec0abfa5f5446dd6fa44a8a04cec216ae593361ad1c8a9d21b149507b  guix-build-788c1324f3d8/output/x86_64-linux-gnu/SHA256SUMS.part
22199e1c788e9dc68214cd3695f5b26d3a71cdb2ed4ad05e2bf776cb4074aa1044  guix-build-788c1324f3d8/output/x86_64-linux-gnu/bitcoin-788c1324f3d8-x86_64-linux-gnu-debug.tar.gz
23da25e8cabf20faef5d9ad797bc47873bbf3489ebdccbe1213eff0e0762644df6  guix-build-788c1324f3d8/output/x86_64-linux-gnu/bitcoin-788c1324f3d8-x86_64-linux-gnu.tar.gz
24295cb7ff1823bad30d7b56a529391d7b63a72a7e0f5b2dc4afd44964900a5313  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/SHA256SUMS.part
250003e69d0eaa1163cd04a5f91a80330c5f135cf9cf7335b5c8677f42afee934f  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/bitcoin-788c1324f3d8-win64-debug.zip
26ba56e1abb5752b004e75073b8c487521472d6a3123716f781ef9bc023d10a183  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/bitcoin-788c1324f3d8-win64-setup-unsigned.exe
2728e401e60e27d306ce6c71818d34fc623e64e186124b33d09c2a387dd7ea6204  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/bitcoin-788c1324f3d8-win64-unsigned.tar.gz
287b415d6f14fb74fb6987615663c6c410bdf559f7d059a5616425a858e4095f95  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/bitcoin-788c1324f3d8-win64.zip

hebasto commented at 8:28 pm on November 5, 2024: member

My Guix build:

 0aarch64
 167b7e95e0f1d45debad8a8cac4c2d349e3e01efcf62e0b109345896f296758d9  guix-build-788c1324f3d8/output/aarch64-linux-gnu/SHA256SUMS.part
 2cd3c67eaa5f6fadf0a73cdb1aa03563d720fc7fdae1b59aa495a0eda9d2695af  guix-build-788c1324f3d8/output/aarch64-linux-gnu/bitcoin-788c1324f3d8-aarch64-linux-gnu-debug.tar.gz
 35c1eb4ff827336a9d113497459981e213844b87e232c33fc00317ce20302f761  guix-build-788c1324f3d8/output/aarch64-linux-gnu/bitcoin-788c1324f3d8-aarch64-linux-gnu.tar.gz
 4dd78923f8fb7410afbbb0f510510fadce022829a163c7399d977f925a9025694  guix-build-788c1324f3d8/output/arm-linux-gnueabihf/SHA256SUMS.part
 55eb0ae9e992184203b5c243ee1c7ba4d3e232c0c08f396f0f28d1a9e2a58b265  guix-build-788c1324f3d8/output/arm-linux-gnueabihf/bitcoin-788c1324f3d8-arm-linux-gnueabihf-debug.tar.gz
 676477f3dd1f1ee9f4382a5314620fb509ac0d235c6f0a4bea34acbbad333176e  guix-build-788c1324f3d8/output/arm-linux-gnueabihf/bitcoin-788c1324f3d8-arm-linux-gnueabihf.tar.gz
 77a0463a4e5378428d388cbc2ecec5ea25318e5f168c6e80c082600303f2e6043  guix-build-788c1324f3d8/output/arm64-apple-darwin/SHA256SUMS.part
 8ea2d0784f0cdedf9007794b319dc794715df3d01223e04c53b83d01c762b254c  guix-build-788c1324f3d8/output/arm64-apple-darwin/bitcoin-788c1324f3d8-arm64-apple-darwin-unsigned.tar.gz
 9a14b9148628d98768c9d843a6a9992956453f29e6958f7132a1475a07cfb784c  guix-build-788c1324f3d8/output/arm64-apple-darwin/bitcoin-788c1324f3d8-arm64-apple-darwin-unsigned.zip
100908b08212f2c8042daf0faaecdd74e1ec07fd21bd015eb1711ef4ab130541ca  guix-build-788c1324f3d8/output/arm64-apple-darwin/bitcoin-788c1324f3d8-arm64-apple-darwin.tar.gz
11ea08a888a5e23ea6c3a76e62cb76283272cf421beeca1f69b03d8a4604ebd906  guix-build-788c1324f3d8/output/dist-archive/bitcoin-788c1324f3d8.tar.gz
1255c058bda5e9f3748f87ece901393f8f424a8d956a08b4c4694917ff315da8b1  guix-build-788c1324f3d8/output/powerpc64-linux-gnu/SHA256SUMS.part
13f9620301f158a7af67fe9d45c4ae232bedea46073f1561e4ea8c85a36644a237  guix-build-788c1324f3d8/output/powerpc64-linux-gnu/bitcoin-788c1324f3d8-powerpc64-linux-gnu-debug.tar.gz
144ff65ca3228a2ffa55896129e400b57dbe458bc9684ad9671f7d787816108504  guix-build-788c1324f3d8/output/powerpc64-linux-gnu/bitcoin-788c1324f3d8-powerpc64-linux-gnu.tar.gz
15958fd22f99a7c7a407f224966c9041322188ee7a2fdbaf708c6d8bbb2b30aca2  guix-build-788c1324f3d8/output/riscv64-linux-gnu/SHA256SUMS.part
1642c73ff53f72104256ec091ce4818d97c21ce0b8e66b6f2e56cea7b0fae3c2d1  guix-build-788c1324f3d8/output/riscv64-linux-gnu/bitcoin-788c1324f3d8-riscv64-linux-gnu-debug.tar.gz
174ea5c652c7cfc350357888d3b829ed7560fe8c88a20c15f605883fe207494ad4  guix-build-788c1324f3d8/output/riscv64-linux-gnu/bitcoin-788c1324f3d8-riscv64-linux-gnu.tar.gz
185a17a9d9bca5617c140d887730e6daffd63a02d42f00c228019bab71beaf7c60  guix-build-788c1324f3d8/output/x86_64-apple-darwin/SHA256SUMS.part
198db48ccd3e540ae3bbf4ef087f8780bfe6378906e16122b27017aeec048f7254  guix-build-788c1324f3d8/output/x86_64-apple-darwin/bitcoin-788c1324f3d8-x86_64-apple-darwin-unsigned.tar.gz
200b9f1c0da2162f43ee8ae781abb6e5d77efc3c32dde4f0e378e6affba33a06f6  guix-build-788c1324f3d8/output/x86_64-apple-darwin/bitcoin-788c1324f3d8-x86_64-apple-darwin-unsigned.zip
210e96d40336f04468624eb48d2fad58e7c44d7e5e778a48c8dd2e025adfa09f28  guix-build-788c1324f3d8/output/x86_64-apple-darwin/bitcoin-788c1324f3d8-x86_64-apple-darwin.tar.gz
2217ee609ec0abfa5f5446dd6fa44a8a04cec216ae593361ad1c8a9d21b149507b  guix-build-788c1324f3d8/output/x86_64-linux-gnu/SHA256SUMS.part
23199e1c788e9dc68214cd3695f5b26d3a71cdb2ed4ad05e2bf776cb4074aa1044  guix-build-788c1324f3d8/output/x86_64-linux-gnu/bitcoin-788c1324f3d8-x86_64-linux-gnu-debug.tar.gz
24da25e8cabf20faef5d9ad797bc47873bbf3489ebdccbe1213eff0e0762644df6  guix-build-788c1324f3d8/output/x86_64-linux-gnu/bitcoin-788c1324f3d8-x86_64-linux-gnu.tar.gz
25295cb7ff1823bad30d7b56a529391d7b63a72a7e0f5b2dc4afd44964900a5313  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/SHA256SUMS.part
260003e69d0eaa1163cd04a5f91a80330c5f135cf9cf7335b5c8677f42afee934f  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/bitcoin-788c1324f3d8-win64-debug.zip
27ba56e1abb5752b004e75073b8c487521472d6a3123716f781ef9bc023d10a183  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/bitcoin-788c1324f3d8-win64-setup-unsigned.exe
2828e401e60e27d306ce6c71818d34fc623e64e186124b33d09c2a387dd7ea6204  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/bitcoin-788c1324f3d8-win64-unsigned.tar.gz
297b415d6f14fb74fb6987615663c6c410bdf559f7d059a5616425a858e4095f95  guix-build-788c1324f3d8/output/x86_64-w64-mingw32/bitcoin-788c1324f3d8-win64.zip

fanquake approved

fanquake commented at 9:52 am on November 6, 2024: member

ACK 788c1324f3d840f7a39b8bc3537dcff26ca0b552

fanquake merged this on Nov 6, 2024

fanquake closed this on Nov 6, 2024

hebasto deleted the branch on Nov 6, 2024

maflcko removed the label DrahtBot Guix build requested on Nov 6, 2024

DrahtBot commented at 6:25 pm on November 7, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 6463117a29294f6ddc9fafecfd1e9023956cc41b(master)	commit c26cbbff1de4f84f80cb09305e60f51986a0c653(master and this pull)
SHA256SUMS.part	`ba176c40e34dd39e...`	`9e50854d15137da4...`
*-aarch64-linux-gnu-debug.tar.gz	`9e86fceb6355fbb9...`	`4f5dfecc84772835...`
*-aarch64-linux-gnu.tar.gz	`9f8181bbf082caf2...`	`73309c9a625656d2...`
*-arm-linux-gnueabihf-debug.tar.gz	`22cb11dbea78abe7...`	`346ebbbc64627b8b...`
*-arm-linux-gnueabihf.tar.gz	`ed43dfb7234cd985...`	`8f0375359e270735...`
*-arm64-apple-darwin-unsigned.tar.gz	`e5d0c0192edaf6ec...`	`3dd64b4c0e447ef9...`
*-arm64-apple-darwin-unsigned.zip	`fe22dd290dd581d7...`	`aac00339c56e7ffb...`
*-arm64-apple-darwin.tar.gz	`fa7fdd3f4fe9aecb...`	`ef24d5eec05f0e89...`
*-powerpc64-linux-gnu-debug.tar.gz	`696996ab99955a79...`	`855270ba113ae621...`
*-powerpc64-linux-gnu.tar.gz	`22e6be9a6e0ff7b0...`	`8697bdca2c43088f...`
*-riscv64-linux-gnu-debug.tar.gz	`faee600cd7e456a1...`	`514a144e8faa9f70...`
*-riscv64-linux-gnu.tar.gz	`c2034b6c0ca2bb80...`	`f2787212c276686e...`
*-x86_64-apple-darwin-unsigned.tar.gz	`a357d2821acb2050...`	`3c99f95835e51d18...`
*-x86_64-apple-darwin-unsigned.zip	`a973b37a64453478...`	`635e2c85e89a4b57...`
*-x86_64-apple-darwin.tar.gz	`f27859648d4c2cef...`	`30aa9e6e74b662cb...`
*-x86_64-linux-gnu-debug.tar.gz	`9f8da143389f3e58...`	`85c2906778903845...`
*-x86_64-linux-gnu.tar.gz	`c46410301bfcab62...`	`94ed2b1a8a3e91c6...`
*.tar.gz	`70a26f8a24b01afa...`	`d9ef6ee4ea4c5f2b...`
guix_build.log	`576c884ba95856e2...`	`2f50385c7fed43a5...`
guix_build.log.diff		`be30760f3e7e08ec...`

TheCharlatan referenced this in commit a73b2bd0f0 on Nov 14, 2024

hebasto commented at 10:15 am on November 20, 2024: member

I suspect that this change broke OSS-Fuzz coverage build: https://issues.oss-fuzz.com/issues/379122777.

build: Unify -logsourcelocations format #30811

Code Coverage & Benchmarks

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

build: Unify `-logsourcelocations` format #30811