cmake: add USE_SOURCE_PERMISSIONS to all configure_file() usage #30823

1. 
   fanquake commented at 2:50 pm on September 5, 2024: member

   USE_SOURCE_PERMISSIONS is the default, so this should not change behaviour. However, being explicit makes it clear what we are doing.

   Related to #30815.

   See https://cmake.org/cmake/help/latest/command/configure_file.html#options.

2. 
   DrahtBot commented at 2:50 pm on September 5, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Build system on Sep 5, 2024
4. 
   hebasto commented at 2:52 pm on September 5, 2024: member

   Could variations in the source directory permissions actually cause #30815?
5. DrahtBot added the label CI failed on Sep 5, 2024
6. cmake: add USE_SOURCE_PERMISSIONS to all configure_file usage

   `USE_SOURCE_PERMISSIONS` is the default, so this should not change
   behaviour. However, being explicit makes it clear what we are doing.
   
   Related to #30815.
   
   See
   https://cmake.org/cmake/help/latest/command/configure_file.html#options.

   1f054eca4e
7. fanquake force-pushed on Sep 6, 2024
8. 
   fanquake commented at 2:46 pm on September 6, 2024: member

   Guix Build:

   0f2e883f15be3d30cc27f1e5ba96ccaa18a9201a242f6dfa7bc65595192249f47  guix-build-1f054eca4e77/output/arm64-apple-darwin/SHA256SUMS.part
   153379e0ac143a7c150563ac10973ee7af5dc827e53f96a8b2519cdf1992ece63  guix-build-1f054eca4e77/output/arm64-apple-darwin/bitcoin-1f054eca4e77-arm64-apple-darwin-unsigned.tar.gz
   28446ce177d54bac5b185faaecf7a7f34590b512b8ffc690f43d461418196f99c  guix-build-1f054eca4e77/output/arm64-apple-darwin/bitcoin-1f054eca4e77-arm64-apple-darwin-unsigned.zip
   38839217f2f97adf2ff5c6b88918bd07019dda003d697feb226d0c0a3bf98804e  guix-build-1f054eca4e77/output/arm64-apple-darwin/bitcoin-1f054eca4e77-arm64-apple-darwin.tar.gz
   4e77d11cd53af8b37a524ab3b649deb027f530e9ffb9a98ab1f5a276f9f8dcaac  guix-build-1f054eca4e77/output/dist-archive/bitcoin-1f054eca4e77.tar.gz
   

9. DrahtBot removed the label CI failed on Sep 6, 2024
10. 
    TheCharlatan commented at 7:26 pm on September 6, 2024: contributor

    Looks like this is not the solution for the reproducibility issue:

    0972bb22e9c3e5fc8858c8351dae323000604cc05dc1bb2b24a35c558d5c20c5d  guix-build-1f054eca4e77/output/arm64-apple-darwin/SHA256SUMS.part
    153379e0ac143a7c150563ac10973ee7af5dc827e53f96a8b2519cdf1992ece63  guix-build-1f054eca4e77/output/arm64-apple-darwin/bitcoin-1f054eca4e77-arm64-apple-darwin-unsigned.tar.gz
    234439d69eb914fb4e758af68f7ee543da1305409621ff34df0b95d785ba03ba3  guix-build-1f054eca4e77/output/arm64-apple-darwin/bitcoin-1f054eca4e77-arm64-apple-darwin-unsigned.zip
    38839217f2f97adf2ff5c6b88918bd07019dda003d697feb226d0c0a3bf98804e  guix-build-1f054eca4e77/output/arm64-apple-darwin/bitcoin-1f054eca4e77-arm64-apple-darwin.tar.gz
    4e77d11cd53af8b37a524ab3b649deb027f530e9ffb9a98ab1f5a276f9f8dcaac  guix-build-1f054eca4e77/output/dist-archive/bitcoin-1f054eca4e77.tar.gz
    

    Might be a good idea in any case though.

11. hebasto approved
12. 
    hebasto commented at 8:19 pm on September 6, 2024: member

    ACK 1f054eca4e779cfa5f9f6e9278071adf65e5eafe.

    Looks like this is not the solution for the reproducibility issue

    The PR description rightfully stated that “this should not change behaviour”.

13. TheCharlatan approved
14. 
    TheCharlatan commented at 8:26 pm on September 6, 2024: contributor

    ACK 1f054eca4e779cfa5f9f6e9278071adf65e5eafe
15. DrahtBot added the label CI failed on Sep 7, 2024
16. 
    hebasto commented at 11:39 am on September 7, 2024: member

    If #30838 happens to fix #30815, it seems reasonable to switch to NO_SOURCE_PERMISSIONS in all cases for consistency.
17. DrahtBot removed the label CI failed on Sep 9, 2024
18. 
    fanquake commented at 9:14 am on September 9, 2024: member

    If #30838 happens to fix #30815, it seems reasonable to switch to NO_SOURCE_PERMISSIONS in all cases for consistency.

    I’m going to merge this, and we can follow up in #30838, and decide if we to change all call sites, or just those needed for reproducibility. That PR will also need to be updated with an explantion of why this started happening, and the fix (I assume there should be no issue always using CMakes default permissions as opposed to our perms, but that should also be mentioned).

19. fanquake merged this on Sep 9, 2024
20. fanquake closed this on Sep 9, 2024

    ---

21. fanquake deleted the branch on Sep 9, 2024

Contributors
fanquake DrahtBot hebasto TheCharlatan

Labels
Build system