fuzz: reduce number of iterations in crypto_aeadchacha20poly1305 target #30826

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2024-09-fuzz-crypto-iterations changing 1 files +1 −1
  1. brunoerg commented at 8:59 pm on September 5, 2024: contributor

    By reducing the number of iterations we improve the performance of this target and may increase coverage.

    Running with -runs=100000 from qa-assets I noticed a significant performance improvement and an increase on cov: master:

    0[#100000](/bitcoin-bitcoin/100000/) DONE   cov: 567 ft: 4078 corp: 124/33Kb lim: 4096 exec/s: 793 rss: 499Mb
    

    PR:

    0[#100000](/bitcoin-bitcoin/100000/) DONE   cov: 568 ft: 3833 corp: 113/15188b lim: 1746 exec/s: 1250 rss: 544Mb
    
  2. fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target
    By reducing the number of iterations we improve the performance of
    this target and may increase coverage.
    f482d0e366
  3. DrahtBot commented at 8:59 pm on September 5, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK marcofleon, stratospher, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Sep 5, 2024
  5. fanquake requested review from dergoegge on Sep 6, 2024
  6. fanquake requested review from marcofleon on Sep 6, 2024
  7. marcofleon commented at 11:06 am on September 6, 2024: contributor
    Tested ACK f482d0e366a84008129913b442f0c955de79ac93. Saw the same slight increase in coverage. Executed 100,000 runs several times and total time went from 30-35 sec to 20-25 sec.
  8. stratospher commented at 10:25 am on September 13, 2024: contributor

    ACK f482d0e. saw similar coverage stats

    1. on branch #3002361 REDUCE cov: 568 ft: 3821 corp: 275/28Kb lim: 4096 exec/s: 1559 rss: 861Mb L: 154/867 MS: 4 InsertByte-EraseBytes-ShuffleBytes-ChangeBinInt-

    2. on master #3004483 REDUCE cov: 567 ft: 4067 corp: 270/47Kb lim: 4096 exec/s: 1917 rss: 842Mb L: 278/2782 MS: 1 EraseBytes-

  9. achow101 commented at 5:49 pm on September 20, 2024: member
    ACK f482d0e366a84008129913b442f0c955de79ac93
  10. achow101 merged this on Sep 20, 2024
  11. achow101 closed this on Sep 20, 2024

  12. brunoerg deleted the branch on Sep 20, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me