build: Use CMake’s default permissions in macOS deploy target #30838

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240906-permissions changing 1 files +2 −2
  1. hebasto commented at 8:23 pm on September 6, 2024: member

    This PR ensures that the file permissions in macOS zip archives are independent of the user’s umask value.

    Fixes #30815.

  2. hebasto added the label Build system on Sep 6, 2024
  3. DrahtBot commented at 8:23 pm on September 6, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake
    Concept ACK laanwj

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. TheCharlatan commented at 9:02 pm on September 6, 2024: contributor

    apple builds:

    0a4840ae0607332cb728e228023de4e77fbe2303d0d85df433ee39e9f2ab4e2e7  guix-build-31f4d1ce83a5/output/arm64-apple-darwin/SHA256SUMS.part
193ba6f8d2f3a849f7f2aa380a9996fc3685cebe1c09aea18a976ce7421622c45  guix-build-31f4d1ce83a5/output/arm64-apple-darwin/bitcoin-31f4d1ce83a5-arm64-apple-darwin-unsigned.tar.gz
247319f231c1fd4a74bfd52f7a62f012353df77762b46d9cc04c2f00001365da2  guix-build-31f4d1ce83a5/output/arm64-apple-darwin/bitcoin-31f4d1ce83a5-arm64-apple-darwin-unsigned.zip
36eeb6dc6f35a6c87503f757b2ad9f64d8d7788941981c75a983450b00ee17bda  guix-build-31f4d1ce83a5/output/arm64-apple-darwin/bitcoin-31f4d1ce83a5-arm64-apple-darwin.tar.gz
4e33843c4ab7a7f69aa1043c95c350b4d67ed3b431b27fec9b23e14cdfd876214  guix-build-31f4d1ce83a5/output/dist-archive/bitcoin-31f4d1ce83a5.tar.gz
5dd88b34f66df456085443567f019fce9eed10fce1175631a8ab109528e634a2b  guix-build-31f4d1ce83a5/output/x86_64-apple-darwin/SHA256SUMS.part
6f2ebea81dc92fe3e4c8f96a1ef319d549bad755d4baae259f400f8ad4f0a8e9f  guix-build-31f4d1ce83a5/output/x86_64-apple-darwin/bitcoin-31f4d1ce83a5-x86_64-apple-darwin-unsigned.tar.gz
7789b7639e24b15bf9b05e6075cadb437fae9b5da0cac40d209b2c549e8c42adc  guix-build-31f4d1ce83a5/output/x86_64-apple-darwin/bitcoin-31f4d1ce83a5-x86_64-apple-darwin-unsigned.zip
8f49aaf33f471ab153ed3a032b6f059d746ccda8a1c5c9f5568f469b9d490c01b  guix-build-31f4d1ce83a5/output/x86_64-apple-darwin/bitcoin-31f4d1ce83a5-x86_64-apple-darwin.tar.gz
  5. laanwj commented at 2:12 pm on September 8, 2024: member

    Concept ACK (will do guix builds)

    Output on both build machines (guix x86_64 and debian arm64) (matches @TheCharlatan):

    0a4840ae0607332cb728e228023de4e77fbe2303d0d85df433ee39e9f2ab4e2e7  guix-build-31f4d1ce83a5/output/arm64-apple-darwin/SHA256SUMS.part
193ba6f8d2f3a849f7f2aa380a9996fc3685cebe1c09aea18a976ce7421622c45  guix-build-31f4d1ce83a5/output/arm64-apple-darwin/bitcoin-31f4d1ce83a5-arm64-apple-darwin-unsigned.tar.gz
247319f231c1fd4a74bfd52f7a62f012353df77762b46d9cc04c2f00001365da2  guix-build-31f4d1ce83a5/output/arm64-apple-darwin/bitcoin-31f4d1ce83a5-arm64-apple-darwin-unsigned.zip
36eeb6dc6f35a6c87503f757b2ad9f64d8d7788941981c75a983450b00ee17bda  guix-build-31f4d1ce83a5/output/arm64-apple-darwin/bitcoin-31f4d1ce83a5-arm64-apple-darwin.tar.gz
4e33843c4ab7a7f69aa1043c95c350b4d67ed3b431b27fec9b23e14cdfd876214  guix-build-31f4d1ce83a5/output/dist-archive/bitcoin-31f4d1ce83a5.tar.gz
5dd88b34f66df456085443567f019fce9eed10fce1175631a8ab109528e634a2b  guix-build-31f4d1ce83a5/output/x86_64-apple-darwin/SHA256SUMS.part
6f2ebea81dc92fe3e4c8f96a1ef319d549bad755d4baae259f400f8ad4f0a8e9f  guix-build-31f4d1ce83a5/output/x86_64-apple-darwin/bitcoin-31f4d1ce83a5-x86_64-apple-darwin-unsigned.tar.gz
7789b7639e24b15bf9b05e6075cadb437fae9b5da0cac40d209b2c549e8c42adc  guix-build-31f4d1ce83a5/output/x86_64-apple-darwin/bitcoin-31f4d1ce83a5-x86_64-apple-darwin-unsigned.zip
8f49aaf33f471ab153ed3a032b6f059d746ccda8a1c5c9f5568f469b9d490c01b  guix-build-31f4d1ce83a5/output/x86_64-apple-darwin/bitcoin-31f4d1ce83a5-x86_64-apple-darwin.tar.gz
  6. fanquake commented at 11:37 am on September 9, 2024: member
    Concept ACK - looks like switching this to use CMakes default permissions, rather than ours, does fix the issue, but I guess could use more discussion given: #30815 (comment).
  7. build: Use CMake's default permissions in macOS `deploy` target 
    This change fixes reproducibility issue with macOS Guix builds.
    5ba03e7d35
  8. hebasto force-pushed on Sep 10, 2024
  9. hebasto marked this as ready for review on Sep 10, 2024
  10. fanquake commented at 3:21 pm on September 10, 2024: member

    Guix build (aarch64):

    08eeb195889318631934b31746dcbd04b26c2312e2aa29dbd7be9de9581a8b805  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/SHA256SUMS.part
105c10866f6972aa58a379935dbc4eb39a8e2abc54a27aa4fa2ce06a7443593ba  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin-unsigned.tar.gz
2f81ec9368bf068a373ec88428becdef08533e8984ad95a3b017f7f1a8cbbb5b1  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin-unsigned.zip
3cb7b4febe1ccfa7ece2cefaf36dc022a433747045ff0545d9f9fea2f930187ca  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin.tar.gz
45b64fd3adb8b1f8541636517d7a2014323197753ae22b4f1596769a8c2208b90  guix-build-5ba03e7d35e1/output/dist-archive/bitcoin-5ba03e7d35e1.tar.gz
5386c997bb64b79a59f06533c007f66b3739d640ef01b4faea23a2429bf876643  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/SHA256SUMS.part
650c4336a4904121aea252e4197f830bdaa1ca08d34ce35a22167725f686cd084  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin-unsigned.tar.gz
748b4331dc224bd578490b9576943fe41ae0e1ee725e3bd779578772ad744090d  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin-unsigned.zip
8291b31673f14c98ab7641cb25a996b98663acae7c83fc2904f974d5e0357714f  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin.tar.gz
  11. hebasto commented at 3:26 pm on September 10, 2024: member

    My Guix build (aarch64, for both umask=0002 and umask=0022):

    08eeb195889318631934b31746dcbd04b26c2312e2aa29dbd7be9de9581a8b805  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/SHA256SUMS.part
105c10866f6972aa58a379935dbc4eb39a8e2abc54a27aa4fa2ce06a7443593ba  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin-unsigned.tar.gz
2f81ec9368bf068a373ec88428becdef08533e8984ad95a3b017f7f1a8cbbb5b1  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin-unsigned.zip
3cb7b4febe1ccfa7ece2cefaf36dc022a433747045ff0545d9f9fea2f930187ca  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin.tar.gz
45b64fd3adb8b1f8541636517d7a2014323197753ae22b4f1596769a8c2208b90  guix-build-5ba03e7d35e1/output/dist-archive/bitcoin-5ba03e7d35e1.tar.gz
5386c997bb64b79a59f06533c007f66b3739d640ef01b4faea23a2429bf876643  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/SHA256SUMS.part
650c4336a4904121aea252e4197f830bdaa1ca08d34ce35a22167725f686cd084  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin-unsigned.tar.gz
748b4331dc224bd578490b9576943fe41ae0e1ee725e3bd779578772ad744090d  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin-unsigned.zip
8291b31673f14c98ab7641cb25a996b98663acae7c83fc2904f974d5e0357714f  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin.tar.gz

    UPD. Same hashes for x86_64.

  12. TheCharlatan commented at 8:55 pm on September 10, 2024: contributor

    Guix build (aarch64):

    08eeb195889318631934b31746dcbd04b26c2312e2aa29dbd7be9de9581a8b805  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/SHA256SUMS.part
105c10866f6972aa58a379935dbc4eb39a8e2abc54a27aa4fa2ce06a7443593ba  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin-unsigned.tar.gz
2f81ec9368bf068a373ec88428becdef08533e8984ad95a3b017f7f1a8cbbb5b1  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin-unsigned.zip
3cb7b4febe1ccfa7ece2cefaf36dc022a433747045ff0545d9f9fea2f930187ca  guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin.tar.gz
45b64fd3adb8b1f8541636517d7a2014323197753ae22b4f1596769a8c2208b90  guix-build-5ba03e7d35e1/output/dist-archive/bitcoin-5ba03e7d35e1.tar.gz
5386c997bb64b79a59f06533c007f66b3739d640ef01b4faea23a2429bf876643  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/SHA256SUMS.part
650c4336a4904121aea252e4197f830bdaa1ca08d34ce35a22167725f686cd084  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin-unsigned.tar.gz
748b4331dc224bd578490b9576943fe41ae0e1ee725e3bd779578772ad744090d  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin-unsigned.zip
8291b31673f14c98ab7641cb25a996b98663acae7c83fc2904f974d5e0357714f  guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin.tar.gz
  13. hebasto commented at 11:34 am on September 11, 2024: member

    Concept ACK - looks like switching this to use CMakes default permissions, rather than ours, does fix the issue, but I guess could use more discussion given: #30815 (comment).

    Continuation of the discussion:

  14. fanquake approved
  15. fanquake commented at 9:00 am on September 12, 2024: member
    ACK 5ba03e7d35e1b47ba864c9ae3c94af97cd3ae10b - I’m going to merge this now so we return to usable (comparable) guix builds.
  16. DrahtBot requested review from laanwj on Sep 12, 2024
  17. fanquake merged this on Sep 12, 2024
  18. fanquake closed this on Sep 12, 2024
  19. hebasto deleted the branch on Sep 12, 2024


hebasto DrahtBot TheCharlatan laanwj fanquake


laanwj

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me