Update libsecp256k1 subtree to latest master

hebasto commented at 5:22 pm on September 7, 2024: member

This PR updates the libsecp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/2f2ccc469540fde6495959cec061e95aab033148, which includes the following changes:

The latter is required for #30791.

Squashed 'src/secp256k1/' changes from 642c885b61..2f2ccc4695

2f2ccc4695 Merge bitcoin-core/secp256k1#1600: cmake: Introduce `SECP256K1_APPEND_LDFLAGS` variable
421ed1b46f cmake: Introduce `SECP256K1_APPEND_LDFLAGS` variable
1988855079 Merge bitcoin-core/secp256k1#1586: fix: remove duplicate 'the' from header file comment
b307614401 Merge bitcoin-core/secp256k1#1583: ci: Bump GCC_SNAPSHOT_MAJOR to 15
fa67b6752d refactor: Use array initialization for unterminated strings
9b0f37bff1 fix: remove duplicate 'the' from header file comment
e34b476730 ci: Bump GCC_SNAPSHOT_MAJOR to 15
3fdf146bad Merge bitcoin-core/secp256k1#1578: ci: Silent Homebrew's noisy reinstall warnings
f8c1b0e0e6 Merge bitcoin-core/secp256k1#1577: release cleanup: bump version after 0.5.1
7057d3c9af ci: Silent Homebrew's noisy reinstall warnings
c3e40d75db release cleanup: bump version after 0.5.1

git-subtree-dir: src/secp256k1
git-subtree-split: 2f2ccc469540fde6495959cec061e95aab033148

611562806c

Update secp256k1 subtree to latest master ff54395de4

DrahtBot commented at 5:22 pm on September 7, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	real-or-random, l0rinc, fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

maflcko added the label DrahtBot Guix build requested on Sep 9, 2024

l0rinc commented at 12:19 pm on September 9, 2024: contributor

Manually recopied https://github.com/bitcoin-core/secp256k1/commit/2f2ccc469540fde6495959cec061e95aab033148 into https://github.com/bitcoin/bitcoin/tree/ff54395de421fa1cbcf80ddbca4d71f0d2a4d12f/src/secp256k1 - seems to be done correctly, no changes detected by git.

utACK ff54395de421fa1cbcf80ddbca4d71f0d2a4d12f

real-or-random approved

real-or-random commented at 1:27 pm on September 9, 2024: contributor

utACK https://github.com/bitcoin/bitcoin/pull/30845/commits/ff54395de421fa1cbcf80ddbca4d71f0d2a4d12f no blockers from libsecp256k1 side, and these commits touch only build/docs/tests and are thus particularly harmless

fanquake commented at 2:04 pm on September 9, 2024: member

Guix Build (aarch64) note that macOS builds (probably) wont match:

 0d5dce4d500967a50a4f5717aabb50bac198ce3a1524b8d8bfdfc015a7bc2ddd4  guix-build-ff54395de421/output/aarch64-linux-gnu/SHA256SUMS.part
 190eaee7f778ed489884dccdc049341ee218372aaf782c6ed43a503d16433c34f  guix-build-ff54395de421/output/aarch64-linux-gnu/bitcoin-ff54395de421-aarch64-linux-gnu-debug.tar.gz
 210190f271c5181c9c956fd36aee9f22f36c80ca844a805902bbc0a078ca0fe56  guix-build-ff54395de421/output/aarch64-linux-gnu/bitcoin-ff54395de421-aarch64-linux-gnu.tar.gz
 335f94430d55bd123ae596d9bff0d462f8a77400a6c6ccb9a62d9d8982675e3ee  guix-build-ff54395de421/output/arm-linux-gnueabihf/SHA256SUMS.part
 4cd572b3235d4e66fb86faf25dba8ec8090221d1d4db8c8a2838aa61d1a3f66c8  guix-build-ff54395de421/output/arm-linux-gnueabihf/bitcoin-ff54395de421-arm-linux-gnueabihf-debug.tar.gz
 50c414fd388fda7cd2205164fa94abfd163bbd57b9730818caef2f75855c62c8b  guix-build-ff54395de421/output/arm-linux-gnueabihf/bitcoin-ff54395de421-arm-linux-gnueabihf.tar.gz
 6cced036865e79e75d36ad62738acc467385025d0aa91d745674c00cd3b0be78d  guix-build-ff54395de421/output/arm64-apple-darwin/SHA256SUMS.part
 7b4ffef0b84f538a95033d1eeda4fa4e223ed6be9d8bb62720358590d01021000  guix-build-ff54395de421/output/arm64-apple-darwin/bitcoin-ff54395de421-arm64-apple-darwin-unsigned.tar.gz
 8341bf83e49ad646d7b6744b536982e5c0f40a725572a013eda4050006b97a42a  guix-build-ff54395de421/output/arm64-apple-darwin/bitcoin-ff54395de421-arm64-apple-darwin-unsigned.zip
 969a9eb05ad9d6ff687362189d426d524af6d31c50a5bd8145045c537cd366378  guix-build-ff54395de421/output/arm64-apple-darwin/bitcoin-ff54395de421-arm64-apple-darwin.tar.gz
1095a70ae8782920877323de0e344e91c1cb778b9999852ac1be810ef90eaa1dd6  guix-build-ff54395de421/output/dist-archive/bitcoin-ff54395de421.tar.gz
11de831237199a4c8980aab130fef86ae5c0647757e8ad3278107d5740f9531bd1  guix-build-ff54395de421/output/powerpc64-linux-gnu/SHA256SUMS.part
1204ca26c738f1b19782734fd908ecbdab8a188f1496c8d96e3b3df69f0b86166e  guix-build-ff54395de421/output/powerpc64-linux-gnu/bitcoin-ff54395de421-powerpc64-linux-gnu-debug.tar.gz
13194381b632c9b12020b6353363b56ec96fd467c11901efca486cd5c54edb48a4  guix-build-ff54395de421/output/powerpc64-linux-gnu/bitcoin-ff54395de421-powerpc64-linux-gnu.tar.gz
14002e37350da040e7e22baaf1dfed1474429e0b4acfacc270c4299e874cc88f66  guix-build-ff54395de421/output/riscv64-linux-gnu/SHA256SUMS.part
15afe6f08b6973a5d648056c568fba3796367c86b999a776f189569771db624e68  guix-build-ff54395de421/output/riscv64-linux-gnu/bitcoin-ff54395de421-riscv64-linux-gnu-debug.tar.gz
161a0fb281f0ab69638a1ae4868efbab8e1666d126fc03f390144814e6fd5ba89e  guix-build-ff54395de421/output/riscv64-linux-gnu/bitcoin-ff54395de421-riscv64-linux-gnu.tar.gz
17b1864f7c70b34d0a6154dc0a494692f08aec212bc1421a31f46d1d23865a67cb  guix-build-ff54395de421/output/x86_64-apple-darwin/SHA256SUMS.part
18f2b098c21ff6c9713c2ca1063e8ae891e7ffd30d3a45f6b6b349747222a8aefc  guix-build-ff54395de421/output/x86_64-apple-darwin/bitcoin-ff54395de421-x86_64-apple-darwin-unsigned.tar.gz
192cf2eac670445fd1864ef5f1c9bc092dd32f1488fc95439edecc5531dfcc5d5f  guix-build-ff54395de421/output/x86_64-apple-darwin/bitcoin-ff54395de421-x86_64-apple-darwin-unsigned.zip
204cc72d5366de73b2e11df1d2316b615f33830c5ed6f2a132123d18ed72a53e8e  guix-build-ff54395de421/output/x86_64-apple-darwin/bitcoin-ff54395de421-x86_64-apple-darwin.tar.gz
215daa937b3b45df76c079b42279e4821b37174c62b8b88275bf86ae9426152498  guix-build-ff54395de421/output/x86_64-linux-gnu/SHA256SUMS.part
221d289cf7d0d8a1eb88ee24e7adddbdf34cc311cfd101823e4295b29fc575812d  guix-build-ff54395de421/output/x86_64-linux-gnu/bitcoin-ff54395de421-x86_64-linux-gnu-debug.tar.gz
23ce0b4fe88580acbe542f4b3915e99c125c8662dd839abae74df0349030c6d906  guix-build-ff54395de421/output/x86_64-linux-gnu/bitcoin-ff54395de421-x86_64-linux-gnu.tar.gz
24de17c7ceb6e274472064cc1242ea5ff6e9325a40ff2c25cf9bb6cae4771b489d  guix-build-ff54395de421/output/x86_64-w64-mingw32/SHA256SUMS.part
25bb477098c183c9417d73b5add7d04e557d7493e3b6a19c401890e2098c2bd9aa  guix-build-ff54395de421/output/x86_64-w64-mingw32/bitcoin-ff54395de421-win64-debug.zip
265a2e7e900230cbe790f3cc0f43075d9c8ab357fc2a836226ab5175502b68b99c  guix-build-ff54395de421/output/x86_64-w64-mingw32/bitcoin-ff54395de421-win64-setup-unsigned.exe
27f849bf4d0b458eda9b3b3990d33cea8dcb05e11bf261e81423813cab75e7d610  guix-build-ff54395de421/output/x86_64-w64-mingw32/bitcoin-ff54395de421-win64-unsigned.tar.gz
28f8fa42b5431e3cb1be86f25253be656196b9dd8ee8d9aa5bc4551a2ac367b460  guix-build-ff54395de421/output/x86_64-w64-mingw32/bitcoin-ff54395de421-win64.zip

fanquake approved

fanquake commented at 2:24 pm on September 9, 2024: member

ACK ff54395de421fa1cbcf80ddbca4d71f0d2a4d12f

fanquake merged this on Sep 9, 2024

fanquake closed this on Sep 9, 2024

hebasto deleted the branch on Sep 9, 2024

DrahtBot commented at 2:56 pm on September 9, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit a5fa90706addb3ebc4325b139cfebcf9d7ac3045(master)	commit 2744501df341d8f3280d47bc3d8cc050b3620e48(master and this pull)
SHA256SUMS.part	`fa0d293afde52d45...`	`c9517d4d7a49c7e6...`
*-aarch64-linux-gnu-debug.tar.gz	`fec098bea0434290...`	`152814da3181849b...`
*-aarch64-linux-gnu.tar.gz	`a253cad30a52012a...`	`034df81ebe98334c...`
*-arm-linux-gnueabihf-debug.tar.gz	`9810cebda0f7a462...`	`83d1c233c0535b2b...`
*-arm-linux-gnueabihf.tar.gz	`33c4d663ab410532...`	`dd3a7d00aab8731c...`
*-arm64-apple-darwin-unsigned.tar.gz	`47b748d942c4ec53...`	`120c2b2d0bca4827...`
*-arm64-apple-darwin-unsigned.zip	`176ce4b6e0cf4334...`	`e2ced845bb908513...`
*-arm64-apple-darwin.tar.gz	`34de19d918dc50c6...`	`82a96366014a23f0...`
*-powerpc64-linux-gnu-debug.tar.gz	`180fbbf24f7d0686...`	`9099c19e72355422...`
*-powerpc64-linux-gnu.tar.gz	`d92074c64fdc2c96...`	`e3370670f78bdc01...`
*-riscv64-linux-gnu-debug.tar.gz	`5f9f8a06db77f7f5...`	`d8f6ab77d3721302...`
*-riscv64-linux-gnu.tar.gz	`3333842d9b442910...`	`b04f89370693db48...`
*-x86_64-apple-darwin-unsigned.tar.gz	`0edf35855cf3c8d8...`	`309a1ad7326d9737...`
*-x86_64-apple-darwin-unsigned.zip	`9caf23691517e57d...`	`1eea512810172e13...`
*-x86_64-apple-darwin.tar.gz	`6eb75ed7c604a630...`	`c501beffbaa1d6cb...`
*-x86_64-linux-gnu-debug.tar.gz	`07703aaa81e28e25...`	`bc85b507f968fa7b...`
*-x86_64-linux-gnu.tar.gz	`4533e8eedda865d9...`	`e7b585969e689f91...`
*.tar.gz	`3cdc665057ab7612...`	`71a5cdc7cc619a79...`
guix_build.log	`d8e510ca445f2845...`	`86405757ef1b092e...`
guix_build.log.diff		`84cb1c20ad9bcde3...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 9, 2024

Update libsecp256k1 subtree to latest master #30845

Code Coverage

Reviews

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]