test: Drop no longer needed workarounds #30847

1. 
   hebasto commented at 8:14 am on September 8, 2024: member

   This PR deletes the workarounds introduced in #16564 and #15382, as ctest skips these cases gracefully: https://github.com/bitcoin/bitcoin/blob/5c80192ff6b982ee3a75be4142fe942b8206f2cd/src/test/CMakeLists.txt#L201-L203
2. test: Drop no longer needed workarounds

   `ctest` skips "no test cases matching filter" tests gracefully.

   5c80192ff6
3. hebasto added the label Tests on Sep 8, 2024
4. 
   DrahtBot commented at 8:14 am on September 8, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake, kevkevinpal

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot added the label CI failed on Sep 8, 2024
6. fanquake approved
7. 
   fanquake commented at 3:44 pm on September 10, 2024: member

   ACK 5c80192ff6b982ee3a75be4142fe942b8206f2cd. Looks correct:

    0cmake -B build -DENABLE_EXTERNAL_SIGNER=OFF (and commented out `EVENT_SET_MEM_FUNCTIONS_IMPLEMENTED` tests)
    1cmake --build build
    2<snip>
    3        Start  74: raii_event_tests
    4 63/133 Test  [#74](/bitcoin-bitcoin/74/): raii_event_tests .....................***Skipped   0.01 sec
    5        Start  99: system_tests
    6 88/133 Test  [#99](/bitcoin-bitcoin/99/): system_tests .........................***Skipped   0.01 sec
    7<snip>
    8Total Test time (real) =  80.97 sec
    9
   10The following tests did not run:
   11	 74 - raii_event_tests (Skipped)
   12	 99 - system_tests (Skipped)
   

8. 
   kevkevinpal commented at 11:00 pm on September 10, 2024: contributor

   ACK 5c80192

   cmake -B build -DENABLE_EXTERNAL_SIGNER=OFF (and commented out banman_tests) cmake --build build ctest --test-dir build

   Got the following snippit

    0<snip>
    1        Start  13: banman_tests
    2 13/133 Test  [#13](/bitcoin-bitcoin/13/): banman_tests .........................***Skipped   0.01 sec
    3 </snip>
    4 
    5 <snip>
    6         Start  99: system_tests
    7 99/133 Test  [#99](/bitcoin-bitcoin/99/): system_tests .........................***Skipped   0.01 sec
    8 </snip>
    9 
   10<snip>
   11The following tests did not run:
   12         13 - banman_tests (Skipped)
   13         99 - system_tests (Skipped)
   14</snip>
   

9. DrahtBot removed the label CI failed on Sep 11, 2024
10. 
    hebasto commented at 1:41 pm on September 11, 2024: member

    cc @maflcko
11. fanquake merged this on Sep 12, 2024
12. fanquake closed this on Sep 12, 2024

    ---

13. hebasto deleted the branch on Sep 12, 2024
14. in src/test/CMakeLists.txt:202 in 5c80192ff6

    198@@ -199,7 +199,7 @@ function(add_boost_test source_file)
    199       COMMAND test_bitcoin --run_test=${test_suite_name} --catch_system_error=no
    200     )
    201     set_property(TEST ${test_suite_name} PROPERTY
    202-      SKIP_REGULAR_EXPRESSION "no test cases matching filter" "Skipping"
    203+      SKIP_REGULAR_EXPRESSION "no test cases matching filter"
    

    ---

    ---

    

    maflcko commented at 12:38 pm on September 12, 2024:

    Just for reference. This never worked in the first place, because “Skipping” was never picked up, because logging was disabled until it was re-added in commit f03c9420958de31fdfecec5fa3e23134aac61803
15. 
    maflcko commented at 12:39 pm on September 12, 2024: member

    lgtm

Contributors
hebasto DrahtBot fanquake kevkevinpal maflcko

Labels
Tests