build: Fix `ENABLE_WALLET` option #30867

hebasto commented at 9:23 PM on September 10, 2024: member

The removed commands were left over from the transition from autodetection to explicit options in the CMake staging branch. These commands prevented the -DENABLE_WALLET=OFF option from being work properly when building with depends.

How to test:

$ make -C depends NO_QT=1

On the master branch @ c66c68345efb0bb3d5613ebac703cde779fa0f01:

$ rm -rf build && cmake -B build --toolchain depends/x86_64-pc-linux-gnu/toolchain.cmake -DENABLE_WALLET=OFF
< snip >
Optional features:
  wallet support ...................... ON
   - descriptor wallets (SQLite) ...... ON
   - legacy wallets (Berkeley DB) ..... ON
  external signer ..................... ON
< snip >

With this PR:

$ rm -rf build && cmake -B build --toolchain depends/x86_64-pc-linux-gnu/toolchain.cmake -DENABLE_WALLET=OFF
< snip >
Optional features:
  wallet support ...................... OFF
  external signer ..................... ON
< snip >

build: Fix `ENABLE_WALLET` option

The removed commands were left over from the transition from
autodetection to explicit options. These commands prevented the
`-DENABLE_WALLET=OFF` option from being work properly when building with
depends.

0037d53d1a

hebasto added the label Build system on Sep 10, 2024

DrahtBot commented at 9:23 PM on September 10, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	maflcko, kevkevinpal, pablomartin4btc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#28710 (Remove the legacy wallet and BDB dependency by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Oaksta85 approved

maflcko commented at 6:42 AM on September 11, 2024: member

review ACK 0037d53d1a21ec8a5a97a83ab716d68030446021

Just noting that the test config will be a bit confusing, albeit harmless:

$ grep -C1 USE_SQLITE ./bld-cmake/test/config.ini 
#ENABLE_WALLET=true
USE_SQLITE=true
#USE_BDB=true

maflcko added the label DrahtBot Guix build requested on Sep 11, 2024

DrahtBot added the label CI failed on Sep 11, 2024

kevkevinpal commented at 12:52 PM on September 11, 2024: contributor

ACK 0037d53

I was able to reproduce the steps in the description and it is now working fine

DrahtBot commented at 4:09 PM on September 11, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 0725a374941355349bb4bc8a79dad1affb27d3b9<br>(master)	commit b8467dd4717b1f8528a0d91e966d426e22ae8c38<br>(master and this pull)
SHA256SUMS.part	`a02d778ecea785cb...`	`046b1d1130e9976a...`
*-aarch64-linux-gnu-debug.tar.gz	`2f9b090610716543...`	`4a6bd2aa58f375e0...`
*-aarch64-linux-gnu.tar.gz	`cdddc2a011cbc71f...`	`2fe86a96b1400085...`
*-arm-linux-gnueabihf-debug.tar.gz	`3dc368c59f717ba5...`	`84cd9e522f7e31f1...`
*-arm-linux-gnueabihf.tar.gz	`25130ed715fb51dc...`	`8ad2c3c31b7bce01...`
*-arm64-apple-darwin-unsigned.tar.gz	`af2c8d808c67cf11...`	`8d1df5f11f87a414...`
*-arm64-apple-darwin-unsigned.zip	`f9b25947985c1303...`	`6a055e4601c66eba...`
*-arm64-apple-darwin.tar.gz	`7511aa736ffea54b...`	`afc74d31e54163b7...`
*-powerpc64-linux-gnu-debug.tar.gz	`e024d862e1d06449...`	`f6ee104f2650dad3...`
*-powerpc64-linux-gnu.tar.gz	`bd2e78a034cbf626...`	`d0f26ac3ed62c6ff...`
*-riscv64-linux-gnu-debug.tar.gz	`b3ee81fe9f44f0e8...`	`a3de5cce9e6e3c4a...`
*-riscv64-linux-gnu.tar.gz	`8406605d831d0a39...`	`98f3cc387b41a528...`
*-x86_64-apple-darwin-unsigned.tar.gz	`413c24a042a77e51...`	`0d24dd14d0d7c52e...`
*-x86_64-apple-darwin-unsigned.zip	`8aa62b3d181cb236...`	`8c91835498a4f566...`
*-x86_64-apple-darwin.tar.gz	`92c1741a2626021a...`	`c0e9772fc871ab17...`
*-x86_64-linux-gnu-debug.tar.gz	`4f05b270004745fa...`	`299c22345a403a0a...`
*-x86_64-linux-gnu.tar.gz	`5873429dcd6b0d7b...`	`c284103bf22a68ca...`
*.tar.gz	`2714f753f68195ae...`	`04f80aadc971997a...`
guix_build.log	`5c24a7305a189158...`	`16ee9ea64fc7ff1a...`
guix_build.log.diff		`6bde14e6c89e2af0...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 11, 2024

DrahtBot removed the label CI failed on Sep 11, 2024

pablomartin4btc approved

pablomartin4btc commented at 5:08 PM on September 11, 2024: member

tACK 0037d53d1a21ec8a5a97a83ab716d68030446021

Also checked building depends with NO_WALLET.

fanquake merged this on Sep 12, 2024

fanquake closed this on Sep 12, 2024

hebasto deleted the branch on Sep 12, 2024

TheCharlatan referenced this in commit 69282950aa on Sep 16, 2024

TheCharlatan referenced this in commit dfe0cd4ec5 on Sep 16, 2024

bitcoin locked this on Sep 12, 2025