Stop using the redundant ‘best invalid work’ record #3087

1. 
   sipa commented at 8:20 pm on October 13, 2013: member

   As block index entries have a flag for marking invalid blocks, the ‘best invalid work’ information can be derived from there. In addition, remove the global from main.h.

   Depends on #3077.

2. 
   sipa commented at 0:18 am on October 14, 2013: member

   Added a commit that makes some validation globals static (and private).
3. 
   jgarzik commented at 2:34 am on October 15, 2013: contributor

   ACK
4. 
   sipa commented at 8:25 pm on October 16, 2013: member

   @Diapolo removed the superfluous comment.
5. 
   gavinandresen commented at 2:44 am on October 23, 2013: contributor

   I think “we” should get Matt’s blockchain tester tool working with the pull-tester again before merging this.
6. 
   sipa commented at 11:20 pm on October 24, 2013: member

   @gavinandresen What is broken?
7. Do not use the redundant BestInvalidWork record in the block database.

   As block index entries have a flag for marking invalid blocks, the
   'best invalid work' information can be derived from there. In addition,
   remove the global from main.h

   85eb2cef33
8. Make some globals in main non-public.

   This means they are declared static, and their extern definition in
   main.h is removed. Also moved CBlockIndexWorkComparator to the .cpp
   file.

   caca6aa4eb
9. 
   sipa commented at 11:54 pm on October 31, 2013: member

   Rebased to trigger PullTester rerun.
10. 
    BitcoinPullTester commented at 0:30 am on November 1, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/caca6aa4eb54b71b5e4e9ccfa69341f985b178d9 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
11. 
    sipa commented at 1:56 pm on November 2, 2013: member

    Any objections?
12. 
    gmaxwell commented at 1:58 pm on November 2, 2013: contributor

    ACK. (Now that it has a comparison tool pass!)
13. sipa referenced this in commit 694c7c8161 on Nov 2, 2013
14. sipa merged this on Nov 2, 2013
15. sipa closed this on Nov 2, 2013

    ---

16. Bushstar referenced this in commit 0d126c2ae4 on Apr 8, 2020
17. DrahtBot locked this on Sep 8, 2021

Contributors
sipa jgarzik gavinandresen BitcoinPullTester gmaxwell