code style: update .editorconfig file #30877

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202409-update_editorconfig changing 1 files +6 −6
  1. theStack commented at 12:57 pm on September 12, 2024: contributor

    Updates the .editorconfig file, first introduced in 2021 (see PR #21123, commit 7a135d57) w.r.t. following changes:

    • consider Rust .rs files (relevant since #28076, commit bbbbdb0c)
    • reflect build system change to CMake (#30454, #30664)
    • add setting for bare Makefile still used for depends builds

    Can be tested e.g. by using the editorconfig-vim plugin (https://github.com/editorconfig/editorconfig-vim). The PR is made under the assumption that the file is still considered useful, especially for new contributors. If people feel like that’s not the case anymore, the alternative is to delete it, obviously.

  2. DrahtBot commented at 12:57 pm on September 12, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Stale ACK TheCharlatan, maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. TheCharlatan approved
  4. TheCharlatan commented at 2:00 pm on September 12, 2024: contributor
    ACK e118dde75ad3a8e08051b4189e1e75c172a98043
  5. in .editorconfig:16 in e118dde75a outdated
     9@@ -10,17 +10,17 @@ insert_final_newline = true
    10 trim_trailing_whitespace = true
    11 
    12 # Source code files
    13-[*.{h,cpp,py,sh}]
    14+[*.{h,cpp,rs,py,sh}]
    15 indent_size = 4
    16 
    17 # .cirrus.yml, .fuzzbuzz.yml, etc.
    


    maflcko commented at 2:01 pm on September 12, 2024:
    0# .cirrus.yml, etc.
    

    (the fuzzbuzz yaml was deleted a very long time ago)


    fanquake commented at 3:46 pm on September 13, 2024:
    @theStack did you want to push to take this, given this file is rarely touched?

    theStack commented at 3:56 pm on September 13, 2024:
    Yes good point, done.
  6. maflcko approved
  7. maflcko commented at 2:02 pm on September 12, 2024: member

    review ACK e118dde75ad3a8e08051b4189e1e75c172a98043

    Even if this isn’t used, it seems like a nice place to document the recommended formatting options.

  8. DrahtBot added the label CI failed on Sep 13, 2024
  9. DrahtBot removed the label CI failed on Sep 13, 2024
  10. code style: update .editorconfig file
    Updates the .editorconfig file, first introduced in 2021
    (see PR #21123, commit 7a135d57) w.r.t. following changes:
    - consider Rust .rs files (relevant since #28076, commit bbbbdb0c)
    - reflect build system change to CMake (#30454, #30664)
    - add setting for the bare Makefile still used for depends builds
    
    Can be tested e.g. by using the editorconfig-vim plugin
    (https://github.com/editorconfig/editorconfig-vim).
    95560616fb
  11. theStack force-pushed on Sep 13, 2024
  12. fanquake merged this on Sep 13, 2024
  13. fanquake closed this on Sep 13, 2024

  14. theStack deleted the branch on Sep 13, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-15 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me