Remove Autotools packages from CI (and depends doc) #30902
pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:240914-libtool changing 5 files +5 −5-
hebasto commented at 12:18 pm on September 14, 2024: memberThis PR is a follow-up to #30752 and addresses #30752 (review).
-
ci: Do not install Autotools packages b786449e66
-
hebasto added the label Docs on Sep 14, 2024
-
hebasto added the label Tests on Sep 14, 2024
-
DrahtBot commented at 12:18 pm on September 14, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK kevkevinpal If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
No conflicts as of last run.
-
in depends/packages.md:155 in 19729521d9 outdated
151@@ -152,16 +152,9 @@ Most autotools projects can be properly staged using: 152 153 ## Build outputs: 154 155-In general, the output of a depends package should not contain any libtool 156-archives. Instead, the package should output `.pc` (`pkg-config`) files where 157+In general, the package should output `.pc` (`pkg-config`) files where
fanquake commented at 12:22 pm on September 14, 2024:I don’t think this is correct. Given we still have depends packages that can output libtool archives (which we currently remove).
hebasto commented at 12:39 pm on September 14, 2024:Thanks! Reverted back. -
depends, doc: Do not install Autotools packages 712d105e09
-
doc: Fix comment in `contrib/devtools/check-deps.sh` script 7a8a6a0667
-
hebasto force-pushed on Sep 14, 2024
-
maflcko commented at 10:51 am on September 16, 2024: memberI think it is fine to do the CI/libtool changes separate. Looks like the other pull is still a draft/WIP anyway.
-
Sjors commented at 11:28 am on September 16, 2024: memberMaybe rename the PR to: “Remove Autotools packages from CI (and depends doc)”
-
hebasto renamed this:
Remove Autotools packages from depends and CI
Remove Autotools packages from CI (and depends doc)
on Sep 16, 2024 -
hebasto commented at 11:31 am on September 16, 2024: member
Maybe rename the PR to: “Remove Autotools packages from CI (and depends doc)”
Renamed.
-
kevkevinpal commented at 12:52 pm on September 16, 2024: contributor
I think it is fine to do the CI/libtool changes separate. Looks like the other pull is still a draft/WIP anyway.
yup agreed I can remove overlapping changes from this PR and https://github.com/bitcoin/bitcoin/pull/30875
-
kevkevinpal commented at 12:52 pm on September 16, 2024: contributorACK 7a8a6a0
-
jonatack commented at 2:27 pm on September 16, 2024: member
LGTM at 7a8a6a06676dcb4066cc81a4e6872281a09bb00d, this patch appears to correctly remove the packages that can be dropped while leaving a few remaining ones that are unrelated.
The changes are small enough that I found it easier to review them together and could be squashed.
-
fanquake merged this on Sep 17, 2024
-
fanquake closed this on Sep 17, 2024
-
hebasto deleted the branch on Sep 17, 2024