ci: Use ninja to build in macOS native CI job #30915

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240917-ci-ninja changing 2 files +2 −1
  1. hebasto commented at 12:13 pm on September 17, 2024: member

    This PR addresses this comment:

    I wonder if one CI task should be using Ninja (and cmake >= 3.27), if it isn’t too hard to implement. Otherwise this config will remain untested and errors may sneak in to the master branch, only being detected after merge.

  2. hebasto added the label Tests on Sep 17, 2024
  3. DrahtBot commented at 12:13 pm on September 17, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, theuni, jonatack, jarolrod

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. ci: Use `ninja` to build in macOS native CI job d01b85bfec
  5. hebasto force-pushed on Sep 17, 2024
  6. hebasto marked this as ready for review on Sep 17, 2024
  7. hebasto commented at 2:45 pm on September 17, 2024: member
  8. maflcko commented at 3:19 pm on September 17, 2024: member

    review ACK d01b85bfecbcf16ea16f90e2ade7537bf582269f

    Can’t hurt to test this in one task

  9. theuni approved
  10. theuni commented at 5:58 pm on September 17, 2024: member

    ACK d01b85bfecbcf16ea16f90e2ade7537bf582269f.

    I was going to suggest this as well :)

  11. jonatack commented at 6:17 pm on September 17, 2024: member
    Concept ACK in using https://ninja-build.org / https://github.com/ninja-build/ninja for a CI task as a point of comparison.
  12. jonatack commented at 6:20 pm on September 17, 2024: member

    LGTM but am new to CMake builds.

    ACK d01b85bfecbcf16ea16f90e2ade7537bf582269f

  13. jarolrod approved
  14. jarolrod commented at 9:18 pm on September 17, 2024: member
    ACK d01b85bfecbcf16ea16f90e2ade7537bf582269f
  15. fanquake merged this on Sep 18, 2024
  16. fanquake closed this on Sep 18, 2024

  17. laanwj commented at 9:30 am on September 18, 2024: member

    ACK d01b85bfecbcf16ea16f90e2ade7537bf582269f

    Good to test this in the CI, i prefer building using ninja.

  18. hebasto deleted the branch on Sep 18, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-08 16:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me