Intermittent failure in p2p_1p1c_network.py", line 58, in raise_network_minfee assert_greater_than(node.getmempoolinfo()['mempoolminfee'], FEERATE_1SAT_VB) ; AssertionError: 0.00001000 <= 0.00001000

maflcko commented at 2:33 pm on September 18, 2024: member

https://github.com/bitcoin/bitcoin/actions/runs/10923649833/job/30320807014?pr=30921#step:7:46110

 0node0 2024-09-18T14:10:27.733922Z [httpworker.2] [src/rpc/request.cpp:232] [parse] [rpc] ThreadRPCServer method=getmempoolinfo user=__cookie__ 
 1 test  2024-09-18T14:10:27.734000Z TestFramework (ERROR): Assertion failed 
 2                                   Traceback (most recent call last):
 3                                     File "/Users/runner/work/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
 4                                       self.run_test()
 5                                     File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64-apple-darwin23.6.0/test/functional/p2p_1p1c_network.py", line 137, in run_test
 6                                       self.raise_network_minfee()
 7                                     File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64-apple-darwin23.6.0/test/functional/p2p_1p1c_network.py", line 58, in raise_network_minfee
 8                                       assert_greater_than(node.getmempoolinfo()['mempoolminfee'], FEERATE_1SAT_VB)
 9                                     File "/Users/runner/work/bitcoin/bitcoin/test/functional/test_framework/util.py", line 82, in assert_greater_than
10                                       raise AssertionError("%s <= %s" % (str(thing1), str(thing2)))
11                                   AssertionError: 0.00001000 <= 0.00001000

maflcko added the label CI failed on Sep 18, 2024

Sjors commented at 4:35 pm on September 20, 2024: member

I saw this several times today as well.

E.g. https://github.com/bitcoin/bitcoin/actions/runs/10962755696/job/30442729104?pr=29346

mzumsande commented at 7:58 pm on September 20, 2024: contributor

I think that the problem is in how fill_mempool works with multiple nodes: If node0 submits transactions so fast that they are being evicted from the mempool before they could be sent out to other peers, then the other peers will never see them, admit (and later remove) them from their mempool and therefore won’t raise their minfee.

Not sure if this can be fixed within p2p_1p1c_network.py or if some sort of intermediate sync_mempool calls would need to be added to fill_mempool after the first couple of transactions.

tdb3 commented at 7:50 pm on September 22, 2024: contributor

Encountered this in PR #30946 as well.

 0test  2024-09-22T19:16:03.915000Z TestFramework (ERROR): Assertion failed 
 1                                   Traceback (most recent call last):
 2                                     File "/Users/runner/work/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
 3                                       self.run_test()
 4                                     File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64-apple-darwin23.6.0/test/functional/p2p_1p1c_network.py", line 137, in run_test
 5                                       self.raise_network_minfee()
 6                                     File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64-apple-darwin23.6.0/test/functional/p2p_1p1c_network.py", line 58, in raise_network_minfee
 7                                       assert_greater_than(node.getmempoolinfo()['mempoolminfee'], FEERATE_1SAT_VB)
 8                                     File "/Users/runner/work/bitcoin/bitcoin/test/functional/test_framework/util.py", line 82, in assert_greater_than
 9                                       raise AssertionError("%s <= %s" % (str(thing1), str(thing2)))
10                                   AssertionError: 0.00001000 <= 0.00001000

maflcko commented at 8:19 am on September 23, 2024: member

Thanks @mzumsande for the detailed analysis and suggested fix. I’ve submitted it as #30948 to address the intermittent failure sooner rather than later. I hope it is fine.

mzumsande commented at 5:03 pm on September 23, 2024: contributor

Of course, if I’d been planning on opening a fix myself I would have mentioned that. I wasn’t sure how to fix this best, see also my comment in the PR.

fanquake closed this on Sep 26, 2024

fanquake referenced this in commit fa7c2838a5 on Sep 26, 2024

Intermittent failure in p2p_1p1c_network.py", line 58, in raise_network_minfee assert_greater_than(node.getmempoolinfo()[‘mempoolminfee’], FEERATE_1SAT_VB) ; AssertionError: 0.00001000 <= 0.00001000 #30922