ci: Approximate MAKEJOBS in image build phase #30935

1. 
   maflcko commented at 8:51 am on September 20, 2024: member

   The MAKEJOBS env var is the default in image builds, which is fine, because it is only relevant when building msan (or iwyu) and only differs when setting MAKEJOBS to something other than nproc (currently used as an approximation).

   So the normal workflow of MAKEJOBS="-j$(nproc)" FILE_ENV="./ci/test/00_setup_env_native_msan.sh" ./ci/test_run_all.sh already works today.

   However, MAKEJOBS="-j1" FILE_ENV="./ci/test/00_setup_env_native_msan.sh" ./ci/test_run_all.sh does not.

   This is hard to fix, because making the env var a build arg means that changing it (and only it) requires a new (expensive and redundant) build.

   So add an option HAVE_CGROUP_CPUSET, which can be set to approximate MAKEJOBS a bit. Can be tested via:

   HAVE_CGROUP_CPUSET=yo MAKEJOBS="-j_something" FILE_ENV="./ci/test/00_setup_env_native_msan.sh" ./ci/test_run_all.sh

2. 
   DrahtBot commented at 8:52 am on September 20, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

3. DrahtBot added the label Tests on Sep 20, 2024
4. maflcko force-pushed on Sep 20, 2024
5. DrahtBot added the label CI failed on Sep 20, 2024
6. 
   DrahtBot commented at 8:58 am on September 20, 2024: contributor

   🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/30421850976

   Make sure to run all tests locally, according to the documentation.

   The failure may happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

7. maflcko force-pushed on Sep 20, 2024
8. DrahtBot removed the label CI failed on Sep 20, 2024
9. 
   maflcko commented at 12:39 pm on September 20, 2024: member

   (This is a follow-up to #28504)
10. DrahtBot added the label CI failed on Sep 29, 2024
11. DrahtBot removed the label CI failed on Sep 29, 2024
12. DrahtBot added the label Needs rebase on Sep 30, 2024
13. maflcko force-pushed on Oct 1, 2024
14. DrahtBot removed the label Needs rebase on Oct 1, 2024
15. 
    maflcko commented at 7:13 pm on October 1, 2024: member

    This may or may not be needed for #30852, but it could be useful even outside of that, if someone wanted to set MAKEJOBS when building the image.
16. ci: Approximate MAKEJOBS in image build phase fa71bedf86
17. maflcko force-pushed on Oct 8, 2024
18. 
    maflcko commented at 6:49 pm on October 8, 2024: member

    rebased
19. fanquake approved
20. 
    fanquake commented at 2:45 pm on October 22, 2024: member

    ACK fa71bedf8609f06618aa85342ea6f5c4d2c5fea0
21. fanquake merged this on Oct 22, 2024
22. fanquake closed this on Oct 22, 2024

    ---

23. maflcko deleted the branch on Oct 23, 2024

Contributors
maflcko DrahtBot fanquake

Labels
Tests