build: scripted-diff: drop config/ subdir for bitcoin-config.h

theStack commented at 11:13 am on September 20, 2024: contributor

This PR is a follow-up to #30856, as suggested in comment #30856 (comment). With the scripted diff, review should be fairly trivial, but it could still be seen as controversial due to the large number of files (78 in total) being touched.

DrahtBot commented at 11:13 am on September 20, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake
Stale ACK	hebasto, theuni, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#30860 (test: autogenerate bash completion by BrandonOdiwuor)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Refactoring on Sep 20, 2024

theStack renamed this:
~~scripted-diff: drop config/ subdir for bitcoin-config.h~~
build: scripted-diff: drop config/ subdir for bitcoin-config.h
on Sep 20, 2024

fanquake removed the label Refactoring on Sep 20, 2024

DrahtBot added the label Build system on Sep 20, 2024

hebasto commented at 9:16 am on September 23, 2024: member

Concept ACK, given the early stage of the current release cycle and the presence of only a single conflicting PR.

fanquake requested review from theuni on Sep 23, 2024

fanquake added the label DrahtBot Guix build requested on Sep 23, 2024

DrahtBot commented at 5:37 pm on September 23, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 33adc7521cc8bb24b941d959022b084002ba7c60(master)	commit 6fbeea9f8b3cdad6d6def1eeb5a884e6446a207e(master and this pull)
SHA256SUMS.part	`89575c9e7a506f16...`	`7d9eb64ae40835ea...`
*-aarch64-linux-gnu-debug.tar.gz	`83ab33a38bceb4ee...`	`41bc30119e8bc20b...`
*-aarch64-linux-gnu.tar.gz	`a232fbbe572e68ac...`	`614efa1d09263812...`
*-arm-linux-gnueabihf-debug.tar.gz	`a84d1b299dbf3220...`	`e4507ed5811fcdca...`
*-arm-linux-gnueabihf.tar.gz	`652caee91e88f2d5...`	`9a31cde0c8b9e7d5...`
*-arm64-apple-darwin-unsigned.tar.gz	`27cc00b2fdbc1374...`	`5e705ebce9c06c56...`
*-arm64-apple-darwin-unsigned.zip	`eddb4c85626a1831...`	`840d26cd3693c7f4...`
*-arm64-apple-darwin.tar.gz	`715c86a8f85d1d53...`	`4d64b0740d685f52...`
*-powerpc64-linux-gnu-debug.tar.gz	`55377f5b1dc78cf2...`	`0f9a98213352e252...`
*-powerpc64-linux-gnu.tar.gz	`120675f298ddd59f...`	`57ad0789c19df2be...`
*-riscv64-linux-gnu-debug.tar.gz	`57a64f32ea69220f...`	`4b40f2c8a64eb511...`
*-riscv64-linux-gnu.tar.gz	`a3a52fd585611a4d...`	`6dd7f9f8ef783a46...`
*-x86_64-apple-darwin-unsigned.tar.gz	`4d86d57f70cd9645...`	`1da632e8e3f95017...`
*-x86_64-apple-darwin-unsigned.zip	`d71ea11af306a495...`	`1fd0de4ac63ce56f...`
*-x86_64-apple-darwin.tar.gz	`e8792a381d01b322...`	`805a46c5e705a00f...`
*-x86_64-linux-gnu-debug.tar.gz	`e3f5849a37744ea5...`	`6be83655793a7da6...`
*-x86_64-linux-gnu.tar.gz	`8a648bbea3d3cf2a...`	`23e1ce0b57def6da...`
*.tar.gz	`30492a8d47e39455...`	`9d87da8057c0911a...`
guix_build.log	`a1cc625d9bfe4c01...`	`bc87f4ce5784f4d4...`
guix_build.log.diff		`9f924f275b69d8bb...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 23, 2024

theuni commented at 8:27 pm on September 23, 2024: member

Concept ACK, and scripted-diff lgtm ACK.

Bikeshed: How about bitcoin-build-config.h for symmetry with bitcoin-build-info.h?

theStack force-pushed on Sep 23, 2024

theStack commented at 10:52 pm on September 23, 2024: contributor

Bikeshed: How about bitcoin-build-config.h for symmetry with bitcoin-build-info.h?

Sounds good to me, done. Both the scripted diff and the patch are now a bit larger, as also some comments/strings have to be adapted, and the .h.in file needs to be renamed as well, but review should still be simple.

in test/lint/test_runner/src/main.rs:432 in 09b0161c4a outdated

428@@ -429,7 +429,7 @@ fn lint_includes_build_config() -> LintResult {
429                 ])
430                 .args(get_pathspecs_exclude_subtrees())
431                 .args([
432-                    // These are exceptions which don't use bitcoin-config.h, rather the Makefile.am adds
433+                    // These are exceptions which don't use bitcoin-build-config.h, rather the Makefile.am adds

hebasto commented at 10:26 am on September 24, 2024:

Not directly related to this PR change, but mentioning “Makefile.am” is outdated.

theStack commented at 10:42 am on October 10, 2024:

Fixed now.

hebasto approved

hebasto commented at 10:27 am on September 24, 2024: member

ACK 09b0161c4a2502564f50fa2b3ce9b19d8fc40d8b.

DrahtBot requested review from theuni on Sep 24, 2024

theuni approved

theuni commented at 7:59 pm on October 9, 2024: member

utACK 09b0161c4a2502564f50fa2b3ce9b19d8fc40d8b

TheCharlatan approved

TheCharlatan commented at 8:07 pm on October 9, 2024: contributor

ACK 09b0161c4a2502564f50fa2b3ce9b19d8fc40d8b

fanquake commented at 9:29 am on October 10, 2024: member

Guix Build

 0a78d6d030a78972bf2ebab6d3599a3ce8b325e5422e192ab97d65966f3ee0ae4  guix-build-09b0161c4a25/output/aarch64-linux-gnu/SHA256SUMS.part
 1a3ff2330715466bef18e536f5ef4c6c00c9a359e11f896b3afade7364b4e40eb  guix-build-09b0161c4a25/output/aarch64-linux-gnu/bitcoin-09b0161c4a25-aarch64-linux-gnu-debug.tar.gz
 2dcedb6cea8f7799d34d64b9a73deda40452887898a44e6b5a2048b7ebf304924  guix-build-09b0161c4a25/output/aarch64-linux-gnu/bitcoin-09b0161c4a25-aarch64-linux-gnu.tar.gz
 3aa2b1c6e8fc747872bdb1c2cbbf5622c96736781a98cc5e6209460d8c0454891  guix-build-09b0161c4a25/output/arm-linux-gnueabihf/SHA256SUMS.part
 41964e1c6a54a7dfe462a2f28bf7e4d05e66baf32b1193d8b3314989e5de129de  guix-build-09b0161c4a25/output/arm-linux-gnueabihf/bitcoin-09b0161c4a25-arm-linux-gnueabihf-debug.tar.gz
 5d2922f38049d5907ecc5120305673e0f4e3cd23b6a129bc5fd29b420e0f7e5aa  guix-build-09b0161c4a25/output/arm-linux-gnueabihf/bitcoin-09b0161c4a25-arm-linux-gnueabihf.tar.gz
 605d473e74b2707834f0147f3e42a8e328f40fe8ba0a2df31d3d3e36656a07296  guix-build-09b0161c4a25/output/arm64-apple-darwin/SHA256SUMS.part
 7ddeb1a9ef5ea95481aedf6eb6f3fda7829711cac5f4c0e36f8e977fc3391cda4  guix-build-09b0161c4a25/output/arm64-apple-darwin/bitcoin-09b0161c4a25-arm64-apple-darwin-unsigned.tar.gz
 8e502cee115489c03e0c38f76fde5dfeba72266046eb35bc9b1a0fbe72670fd51  guix-build-09b0161c4a25/output/arm64-apple-darwin/bitcoin-09b0161c4a25-arm64-apple-darwin-unsigned.zip
 966ab20ebf87a11b41149844ae1fc0c148d60059027917ee835547d853bb58b53  guix-build-09b0161c4a25/output/arm64-apple-darwin/bitcoin-09b0161c4a25-arm64-apple-darwin.tar.gz
10b7dad4ad285c4eecb11dab43e01435da206aeb3dbbd264a51575d0300b5bec6d  guix-build-09b0161c4a25/output/dist-archive/bitcoin-09b0161c4a25.tar.gz
11ad7c3270dfe8955b9a518b081d6c4c45322f8627742be111d95c1c7891aa34de  guix-build-09b0161c4a25/output/powerpc64-linux-gnu/SHA256SUMS.part
12434208f50ae66ce5eb9df81337586f4e69f39228fd620a8570390506eccacb45  guix-build-09b0161c4a25/output/powerpc64-linux-gnu/bitcoin-09b0161c4a25-powerpc64-linux-gnu-debug.tar.gz
1345fba4d2324a8bbe543e062802652aa2518475ae92a62bb053e94506231dc268  guix-build-09b0161c4a25/output/powerpc64-linux-gnu/bitcoin-09b0161c4a25-powerpc64-linux-gnu.tar.gz
14d09cddd15788c640c018c82d066386ed41b3a79f22b311ef5fab210afe06ca8a  guix-build-09b0161c4a25/output/riscv64-linux-gnu/SHA256SUMS.part
153f68083240793dc897c25a303748af989e87b99e3bae7cf6370339a42b2ff4b0  guix-build-09b0161c4a25/output/riscv64-linux-gnu/bitcoin-09b0161c4a25-riscv64-linux-gnu-debug.tar.gz
16c1c66255621ffe348113c7b57ff0432cd420a10dd008c3dfcc6c0caf787b7618  guix-build-09b0161c4a25/output/riscv64-linux-gnu/bitcoin-09b0161c4a25-riscv64-linux-gnu.tar.gz
1799988b30ae435a6e5155631f683f1934ee5f3e3e2d7655fb4034c9bea2537fd5  guix-build-09b0161c4a25/output/x86_64-apple-darwin/SHA256SUMS.part
185ce76d80d52e5b9c44599b7189276f81beda58137f0e232d9f22116e6a44289f  guix-build-09b0161c4a25/output/x86_64-apple-darwin/bitcoin-09b0161c4a25-x86_64-apple-darwin-unsigned.tar.gz
198c195e6ef2ef8a6073381d08e76746e9109b641041e7c7efd7f9843c88609160  guix-build-09b0161c4a25/output/x86_64-apple-darwin/bitcoin-09b0161c4a25-x86_64-apple-darwin-unsigned.zip
20851914c98027dbd4219d94b81d337e34f3509ae986a3dd2499f6844615e4f284  guix-build-09b0161c4a25/output/x86_64-apple-darwin/bitcoin-09b0161c4a25-x86_64-apple-darwin.tar.gz
21268ddadba8dd0e37e344e125ca2a37e6ee9945b5ab707968f65997031ce09990  guix-build-09b0161c4a25/output/x86_64-linux-gnu/SHA256SUMS.part
221e90e024edf115c25795d73ab1fd328bc4e65f32240ca3ac3a1f0b3299bb7960  guix-build-09b0161c4a25/output/x86_64-linux-gnu/bitcoin-09b0161c4a25-x86_64-linux-gnu-debug.tar.gz
23176429859b3f7cc295b7361a4692fe5f5927357f5762982c1cbb2bc412447cb4  guix-build-09b0161c4a25/output/x86_64-linux-gnu/bitcoin-09b0161c4a25-x86_64-linux-gnu.tar.gz
24786f56a48dda53fa3a6387114d131018e36e1955fc771ee33e61f7c4c85ff480  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/SHA256SUMS.part
2504eb6e213da49d1232ab6312e42c5b2f901dcad33f72d3cbc77e2310295cddbf  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/bitcoin-09b0161c4a25-win64-debug.zip
26bc2a8d194cd12afd801f8bde5f0d384006b66806705b8fa74f474a8777a1cdc9  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/bitcoin-09b0161c4a25-win64-setup-unsigned.exe
27af36eedcf415b94e8e6323fd897710d0ac51efdc6eddb580a85d38992abbced3  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/bitcoin-09b0161c4a25-win64-unsigned.tar.gz
28930a85398e43ee9e9af1d1cdccb1f1c472114167995cc15a8be1e3961cfe01e4  guix-build-09b0161c4a25/output/x86_64-w64-mingw32/bitcoin-09b0161c4a25-win64.zip

fanquake commented at 9:30 am on October 10, 2024: member

0bitcoin/src/common/netif.cpp:5:10: fatal error: 'config/bitcoin-config.h' file not found
1    5 | #include <config/bitcoin-config.h> // IWYU pragma: keep
2      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
31 error generated.

DrahtBot added the label CI failed on Oct 10, 2024

DrahtBot commented at 9:41 am on October 10, 2024: contributor

🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/30553100469

Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

Follow-up for PR #30856, commit 0dd66251.

-BEGIN VERIFY SCRIPT-
sed -i "s|config/bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l config/bitcoin-config\.h)
sed -i "s|bitcoin-config\.h|bitcoin-build-config.h|g" $(git grep -l "bitcoin-config\.h" ./src ./test ./cmake)
git mv ./cmake/bitcoin-config.h.in ./cmake/bitcoin-build-config.h.in
-END VERIFY SCRIPT-

1786be7b4a

doc: lint: correct outdated comment (s/Makefile.am/CMakeLists.txt/) 882f736d0a

theStack force-pushed on Oct 10, 2024

theStack commented at 10:41 am on October 10, 2024: contributor

Rebased on master and added another commit fixing the outdated comment in the linter (https://github.com/bitcoin/bitcoin/pull/30937#discussion_r1773075606).

DrahtBot removed the label CI failed on Oct 10, 2024

fanquake commented at 12:23 pm on October 10, 2024: member

Guix Build:

 09cf65a99fa046a1a3acbee14d6dec658b9fe7f4e55a4b6f50d063ebb4029e3eb  guix-build-882f736d0a60/output/aarch64-linux-gnu/SHA256SUMS.part
 146780332298b988bc9b4c2903d077f49978dc92250cf5221557ce4459383b18e  guix-build-882f736d0a60/output/aarch64-linux-gnu/bitcoin-882f736d0a60-aarch64-linux-gnu-debug.tar.gz
 272362b6f0394f4b8b1e69e4520c892d5b3e9f3d86788c8f0ee59f2b0d9e51717  guix-build-882f736d0a60/output/aarch64-linux-gnu/bitcoin-882f736d0a60-aarch64-linux-gnu.tar.gz
 3c4b5294efed908afb3458d1af340c9d2f77be84e0a9db93f626bad4590fe3fbe  guix-build-882f736d0a60/output/arm-linux-gnueabihf/SHA256SUMS.part
 4e9d201fc4f74fa77b038ca165858efde284f82e8e004301290c3c0d61875f1c1  guix-build-882f736d0a60/output/arm-linux-gnueabihf/bitcoin-882f736d0a60-arm-linux-gnueabihf-debug.tar.gz
 58cd166df49767e948a2f827e148ab16f57c6910a35fe6b39ff3373e9c46cb936  guix-build-882f736d0a60/output/arm-linux-gnueabihf/bitcoin-882f736d0a60-arm-linux-gnueabihf.tar.gz
 6f9ac382c47e7e17b4ed6a0e0666c894967dcda4289a139e9d41e88d78b4f8ee6  guix-build-882f736d0a60/output/arm64-apple-darwin/SHA256SUMS.part
 7cdfd080d9b6a2e8f9f83a6f51c8f7db0e77d97a3f3ed4ecd1aab6293805db664  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin-unsigned.tar.gz
 880f1a45978a17e72042e9e9cd02972ceb5eabfaa04b4a1dbbb83a8710cff64a0  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin-unsigned.zip
 97f11308b9981b417be87029eb0a04aad36335874f0c1e7e5101a2161f3d62d7c  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin.tar.gz
1032ee2152bf29b81e8c40dbd7c5821b646c498447f63d51ca9fbe414dc485bec0  guix-build-882f736d0a60/output/dist-archive/bitcoin-882f736d0a60.tar.gz
11530692b5ce8dd83150e838a6e2e4fa042662ee688db79d874e50110de23987f2  guix-build-882f736d0a60/output/powerpc64-linux-gnu/SHA256SUMS.part
1206810c70111b01ef998031a4fe1b5d661a7b89287f2f36e64e9991b38aac99e8  guix-build-882f736d0a60/output/powerpc64-linux-gnu/bitcoin-882f736d0a60-powerpc64-linux-gnu-debug.tar.gz
13fbefb433c08ea43f0ba3095307ed0981bd47e2954799eca23eb9f7e7bb78cfab  guix-build-882f736d0a60/output/powerpc64-linux-gnu/bitcoin-882f736d0a60-powerpc64-linux-gnu.tar.gz
14e605fcdfe071b4b504a9033c175f3d9651dffb3ef959fcc0f34082dd2815cc3d  guix-build-882f736d0a60/output/riscv64-linux-gnu/SHA256SUMS.part
151104a13281c11351b0672a8fee0384d9fd9b2becfe1adc168eda07c807edd5a8  guix-build-882f736d0a60/output/riscv64-linux-gnu/bitcoin-882f736d0a60-riscv64-linux-gnu-debug.tar.gz
16ef1c20cf3b798b9cd6d05a7ade98f4c3b8f0e7afb9a139e5975d204f8aa58985  guix-build-882f736d0a60/output/riscv64-linux-gnu/bitcoin-882f736d0a60-riscv64-linux-gnu.tar.gz
179eeb7155477ec4db1abd308a9a036945c442f11f7ed6aa52ea9a1b825babe57b  guix-build-882f736d0a60/output/x86_64-apple-darwin/SHA256SUMS.part
18c78b42f3aa52bb424e7e8aad650343e582a36ab00b5dc84c3e922c99470be7f7  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin-unsigned.tar.gz
1904f78c2e0674e9ff6a1358b4322b045489940925c37c504503c8a765b19a1603  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin-unsigned.zip
2066d5a64c486eefd899e37a29a1aabc53fb8ba33f46bb5cb83399db8135470ba9  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin.tar.gz
21f4d169df64d85d835b0baa46d12b2992dbf1a1bfdca5a136c94f7794b11df28a  guix-build-882f736d0a60/output/x86_64-linux-gnu/SHA256SUMS.part
2260c34fcd5b5fa08afcc3a7ee65a8d820820a1af9f42f731ec8422e6db458d616  guix-build-882f736d0a60/output/x86_64-linux-gnu/bitcoin-882f736d0a60-x86_64-linux-gnu-debug.tar.gz
2331135e0adbeb59f0abe78351a7c260aaf02d3206a40b26dfda4b20d8b6919627  guix-build-882f736d0a60/output/x86_64-linux-gnu/bitcoin-882f736d0a60-x86_64-linux-gnu.tar.gz
24c8e17374b9e6395215e1b2fba46087c6e1b662f5cae3cd6a532cebc0810ffcf9  guix-build-882f736d0a60/output/x86_64-w64-mingw32/SHA256SUMS.part
25ef9b885e8a28f02bf5fd904aaac1a6a855abe9a1c460f879d510e34e759bf18f  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-debug.zip
26f7f5d508293ab7981b32717285e34206acbf7d2aaac01460d6183f9ff767c877  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-setup-unsigned.exe
27af63e56853250b509ab4cdc63b24b195d176d4a4e943ec8bb04b58ca559bf750  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-unsigned.tar.gz
280b4810fea2c99c2c23bc2edea341b06df19070e9b4e31d47aa8ddf22ca98018f  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64.zip

fanquake approved

fanquake commented at 12:29 pm on October 10, 2024: member

ACK 882f736d0a607976ee5e3a6cbcb5385524bc72c6

DrahtBot requested review from theuni on Oct 10, 2024

DrahtBot requested review from TheCharlatan on Oct 10, 2024

DrahtBot requested review from hebasto on Oct 10, 2024

fanquake merged this on Oct 10, 2024

fanquake closed this on Oct 10, 2024

theStack deleted the branch on Oct 10, 2024

TheCharlatan commented at 1:57 pm on October 10, 2024: contributor

Post-merge ACK 882f736d0a60

Guix build (aarch64):

 09cf65a99fa046a1a3acbee14d6dec658b9fe7f4e55a4b6f50d063ebb4029e3eb  guix-build-882f736d0a60/output/aarch64-linux-gnu/SHA256SUMS.part
 146780332298b988bc9b4c2903d077f49978dc92250cf5221557ce4459383b18e  guix-build-882f736d0a60/output/aarch64-linux-gnu/bitcoin-882f736d0a60-aarch64-linux-gnu-debug.tar.gz
 272362b6f0394f4b8b1e69e4520c892d5b3e9f3d86788c8f0ee59f2b0d9e51717  guix-build-882f736d0a60/output/aarch64-linux-gnu/bitcoin-882f736d0a60-aarch64-linux-gnu.tar.gz
 3c4b5294efed908afb3458d1af340c9d2f77be84e0a9db93f626bad4590fe3fbe  guix-build-882f736d0a60/output/arm-linux-gnueabihf/SHA256SUMS.part
 4e9d201fc4f74fa77b038ca165858efde284f82e8e004301290c3c0d61875f1c1  guix-build-882f736d0a60/output/arm-linux-gnueabihf/bitcoin-882f736d0a60-arm-linux-gnueabihf-debug.tar.gz
 58cd166df49767e948a2f827e148ab16f57c6910a35fe6b39ff3373e9c46cb936  guix-build-882f736d0a60/output/arm-linux-gnueabihf/bitcoin-882f736d0a60-arm-linux-gnueabihf.tar.gz
 6f9ac382c47e7e17b4ed6a0e0666c894967dcda4289a139e9d41e88d78b4f8ee6  guix-build-882f736d0a60/output/arm64-apple-darwin/SHA256SUMS.part
 7cdfd080d9b6a2e8f9f83a6f51c8f7db0e77d97a3f3ed4ecd1aab6293805db664  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin-unsigned.tar.gz
 880f1a45978a17e72042e9e9cd02972ceb5eabfaa04b4a1dbbb83a8710cff64a0  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin-unsigned.zip
 97f11308b9981b417be87029eb0a04aad36335874f0c1e7e5101a2161f3d62d7c  guix-build-882f736d0a60/output/arm64-apple-darwin/bitcoin-882f736d0a60-arm64-apple-darwin.tar.gz
1032ee2152bf29b81e8c40dbd7c5821b646c498447f63d51ca9fbe414dc485bec0  guix-build-882f736d0a60/output/dist-archive/bitcoin-882f736d0a60.tar.gz
11530692b5ce8dd83150e838a6e2e4fa042662ee688db79d874e50110de23987f2  guix-build-882f736d0a60/output/powerpc64-linux-gnu/SHA256SUMS.part
1206810c70111b01ef998031a4fe1b5d661a7b89287f2f36e64e9991b38aac99e8  guix-build-882f736d0a60/output/powerpc64-linux-gnu/bitcoin-882f736d0a60-powerpc64-linux-gnu-debug.tar.gz
13fbefb433c08ea43f0ba3095307ed0981bd47e2954799eca23eb9f7e7bb78cfab  guix-build-882f736d0a60/output/powerpc64-linux-gnu/bitcoin-882f736d0a60-powerpc64-linux-gnu.tar.gz
14e605fcdfe071b4b504a9033c175f3d9651dffb3ef959fcc0f34082dd2815cc3d  guix-build-882f736d0a60/output/riscv64-linux-gnu/SHA256SUMS.part
151104a13281c11351b0672a8fee0384d9fd9b2becfe1adc168eda07c807edd5a8  guix-build-882f736d0a60/output/riscv64-linux-gnu/bitcoin-882f736d0a60-riscv64-linux-gnu-debug.tar.gz
16ef1c20cf3b798b9cd6d05a7ade98f4c3b8f0e7afb9a139e5975d204f8aa58985  guix-build-882f736d0a60/output/riscv64-linux-gnu/bitcoin-882f736d0a60-riscv64-linux-gnu.tar.gz
179eeb7155477ec4db1abd308a9a036945c442f11f7ed6aa52ea9a1b825babe57b  guix-build-882f736d0a60/output/x86_64-apple-darwin/SHA256SUMS.part
18c78b42f3aa52bb424e7e8aad650343e582a36ab00b5dc84c3e922c99470be7f7  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin-unsigned.tar.gz
1904f78c2e0674e9ff6a1358b4322b045489940925c37c504503c8a765b19a1603  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin-unsigned.zip
2066d5a64c486eefd899e37a29a1aabc53fb8ba33f46bb5cb83399db8135470ba9  guix-build-882f736d0a60/output/x86_64-apple-darwin/bitcoin-882f736d0a60-x86_64-apple-darwin.tar.gz
21f4d169df64d85d835b0baa46d12b2992dbf1a1bfdca5a136c94f7794b11df28a  guix-build-882f736d0a60/output/x86_64-linux-gnu/SHA256SUMS.part
2260c34fcd5b5fa08afcc3a7ee65a8d820820a1af9f42f731ec8422e6db458d616  guix-build-882f736d0a60/output/x86_64-linux-gnu/bitcoin-882f736d0a60-x86_64-linux-gnu-debug.tar.gz
2331135e0adbeb59f0abe78351a7c260aaf02d3206a40b26dfda4b20d8b6919627  guix-build-882f736d0a60/output/x86_64-linux-gnu/bitcoin-882f736d0a60-x86_64-linux-gnu.tar.gz
24c8e17374b9e6395215e1b2fba46087c6e1b662f5cae3cd6a532cebc0810ffcf9  guix-build-882f736d0a60/output/x86_64-w64-mingw32/SHA256SUMS.part
25ef9b885e8a28f02bf5fd904aaac1a6a855abe9a1c460f879d510e34e759bf18f  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-debug.zip
26f7f5d508293ab7981b32717285e34206acbf7d2aaac01460d6183f9ff767c877  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-setup-unsigned.exe
27af63e56853250b509ab4cdc63b24b195d176d4a4e943ec8bb04b58ca559bf750  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64-unsigned.tar.gz
280b4810fea2c99c2c23bc2edea341b06df19070e9b4e31d47aa8ddf22ca98018f  guix-build-882f736d0a60/output/x86_64-w64-mingw32/bitcoin-882f736d0a60-win64.zip

hebasto commented at 6:06 pm on October 11, 2024: member

Post-merge ACK 882f736d0a607976ee5e3a6cbcb5385524bc72c6.

build: scripted-diff: drop config/ subdir for bitcoin-config.h #30937

Code Coverage

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]