Description: While checking the previous releases, I figure out that the link to release 0.10.0 is broken. The link is updated now with the correct address.
No additional test is needed because there was no code change
Description: While checking the previous releases, I figure out that the link to release 0.10.0 is broken. The link is updated now with the correct address.
No additional test is needed because there was no code change
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process. A summary of reviews will appear here.
0@@ -1,6 +1,6 @@
1 Bitcoin Core version 0.10.0 is now available from:
2
3- https://bitcoin.org/bin/0.10.0/
4+ https://bitcoin.org/bin/bitcoin-core-0.10.0/
Shouldn’t this pont to https://bitcoin.org/bin/insecure/bitcoin-core-0.10.0
instead?
Please fix the rest of them as well with a scripted diff:
0-BEGIN VERIFY SCRIPT-
1sed -i --regexp-extended 's#(https://bitcoin\.org/bin/)([.0-9]+)#\1insecure/bitcoin-core-\2#g' ./doc/release-notes/*.md
2-END VERIFY SCRIPT-
Shouldn’t this pont to
https://bitcoin.org/bin/insecure/bitcoin-core-0.10.0
instead?Please fix the rest of them as well with a scripted diff:
0-BEGIN VERIFY SCRIPT- 1sed -i --regexp-extended 's#(https://bitcoin\.org/bin/)([.0-9]+)#\1insecure/bitcoin-core-\2#g' ./doc/release-notes/*.md 2-END VERIFY SCRIPT-
Hi @l0rinc, thanks for your suggestion. however I think the directory you provided (https://bitcoin.org/bin/insecure/) only includes limited releases that contain known security flaws and should not be used, according to the README. The original repository that I use (https://bitcoin.org/bin/) should include the full releases that all the other release notes have already correctly referred to. Only the link in 0.10.0 seems to be wrong.
Could you please check again?
https://bitcoin.org/bin/insecure/bitcoin-core-0.10.0 contains everything that https://bitcoin.org/bin/bitcoin-core-0.10.0 contains - and the rest of the <0.10.0 release links are also wrong and should be fixed.
Please squash the commits (we need a clean history) and fix all of them via a single scripted-diff commit.
Approach NACK