doc: fix broken link to release #30945

pull tsnob wants to merge 7 commits into bitcoin:master from tsnob:master changing 1 files +1 −1
  1. tsnob commented at 9:20 am on September 22, 2024: none

    Description: While checking the previous releases, I figure out that the link to release 0.10.0 is broken. The link is updated now with the correct address.

    No additional test is needed because there was no code change

  2. doc: fix broken link to release 1a6d26457b
  3. DrahtBot commented at 9:20 am on September 22, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label Docs on Sep 22, 2024
  5. in doc/release-notes/release-notes-0.10.0.md:3 in 1a6d26457b outdated
    0@@ -1,6 +1,6 @@
    1 Bitcoin Core version 0.10.0 is now available from:
    2 
    3-  https://bitcoin.org/bin/0.10.0/
    4+  https://bitcoin.org/bin/bitcoin-core-0.10.0/
    


    l0rinc commented at 9:46 am on September 22, 2024:

    Shouldn’t this pont to https://bitcoin.org/bin/insecure/bitcoin-core-0.10.0 instead?

    Please fix the rest of them as well with a scripted diff:

    0-BEGIN VERIFY SCRIPT-
    1sed -i --regexp-extended 's#(https://bitcoin\.org/bin/)([.0-9]+)#\1insecure/bitcoin-core-\2#g' ./doc/release-notes/*.md
    2-END VERIFY SCRIPT-
    

    tsnob commented at 10:35 am on September 22, 2024:

    Shouldn’t this pont to https://bitcoin.org/bin/insecure/bitcoin-core-0.10.0 instead?

    Please fix the rest of them as well with a scripted diff:

    0-BEGIN VERIFY SCRIPT-
    1sed -i --regexp-extended 's#(https://bitcoin\.org/bin/)([.0-9]+)#\1insecure/bitcoin-core-\2#g' ./doc/release-notes/*.md
    2-END VERIFY SCRIPT-
    

    Hi @l0rinc, thanks for your suggestion. however I think the directory you provided (https://bitcoin.org/bin/insecure/) only includes limited releases that contain known security flaws and should not be used, according to the README. The original repository that I use (https://bitcoin.org/bin/) should include the full releases that all the other release notes have already correctly referred to. Only the link in 0.10.0 seems to be wrong.

    Could you please check again?


    l0rinc commented at 11:24 am on September 22, 2024:

    https://bitcoin.org/bin/insecure/bitcoin-core-0.10.0 contains everything that https://bitcoin.org/bin/bitcoin-core-0.10.0 contains - and the rest of the <0.10.0 release links are also wrong and should be fixed.

    Please squash the commits (we need a clean history) and fix all of them via a single scripted-diff commit.

    Approach NACK

  6. l0rinc changes_requested
  7. docs: update correct link to corresponded release bd783328c9
  8. doc: update correct link to corresponded release 86c01aea25
  9. doc: update correct link to corresponded release 63c3d16e05
  10. doc: revert change d9a1387382
  11. doc: revert change b20ff2a5df
  12. Update link da97c6ca90
  13. fanquake commented at 11:22 am on September 22, 2024: member
    Thanks. However we generally don’t modify historical release notes.
  14. fanquake closed this on Sep 22, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-08 16:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me