doc: macOS 15 ships llvm 16 #30949

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2024/09/macos changing 1 files +1 −1
  1. Sjors commented at 7:58 am on September 23, 2024: member

    #30263 bumped the minimum clang to 16

    macOS versions before 15 ship older versions, see https://en.wikipedia.org/wiki/Xcode#Xcode_15.0_-_(since_visionOS_support)

    Updating macOS build instructions to reflect this.

  2. DrahtBot commented at 7:58 am on September 23, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  3. DrahtBot added the label Docs on Sep 23, 2024
  4. doc: macOS 15 ships llvm 16 c166df2a1e
  5. Sjors force-pushed on Sep 23, 2024
  6. maflcko commented at 8:09 am on September 23, 2024: member

    Are you sure?

    CI checks for this and passes, so you’ll have to explain why CI didn’t fail. Ideally, with exact steps to reproduce. Otherwise, it will be hard to follow.

    Also, keep in mind that the “Clang version string” inside XCode is completely made up by Apple. It does not correspond to the llvm versioning.

  7. fanquake commented at 8:26 am on September 23, 2024: member
    Yea, this isn’t correct. The Apple Clang that is installable with macOS 14.x work perfectly fine. No need to install a different LLVM toolchain.
  8. hebasto commented at 8:52 am on September 23, 2024: member
    https://en.wikipedia.org/wiki/Xcode#Toolchain_versions shows that Apple clang version 15.0.0 (clang-1500.0.40.1) used in the CI is based on LLVM 16.0.0.
  9. Sjors commented at 9:34 am on September 23, 2024: member

    The Github CI native macOS 14 build uses Xcode 15:

    https://github.com/bitcoin/bitcoin/blob/33adc7521cc8bb24b941d959022b084002ba7c60/.github/workflows/ci.yml#L81-L100

    macOS 14 supports Xcode 15: https://developer.apple.com/support/xcode/

    So it seems only macOS Ventura 13 needs the manual llvm install, but let me double-check that.

  10. Sjors commented at 9:37 am on September 23, 2024: member

    The latest point release 15.4 requires macOs 14, but Xcode 15.2 still works on macOS Ventura 13. It shipped with llvm 16 as well.

    So this PR is premature, closing.

  11. Sjors closed this on Sep 23, 2024

  12. Sjors deleted the branch on Sep 23, 2024
  13. Sjors commented at 10:57 am on September 23, 2024: member

    Just tested that after manually installing Xcode 15.2 on macOS 13.7 (the last supported version on my 27" iMac from 2017), picking it with xcode-select, I can still build the project. No need to install llvm via Homebrew.

    That’s the most recent version you can use. As @maflcko pointed out, Xcode 15.0 should work too, since the Github CI macOS 14 jobs picks it.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-08 16:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me