Currently, debugging where time is spent in the cirrus jobs feels annoying, e.g. trying to see where time may be spent in #30969
Enable timestamps in the logs for more information.
Currently, debugging where time is spent in the cirrus jobs feels annoying, e.g. trying to see where time may be spent in #30969
Enable timestamps in the logs for more information.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
review ACK f951f1fab258f782a88bb006b5ae4ea486705388
It may be a bit annoying when looking at functional test failures, which have a timestamp included and would then get a “wrong” timestamp, but this seems fine .
Code Review ACK f951f1fab258f782a88bb006b5ae4ea486705388 There are a few times I’ve wished these timestamps were present.
0[14:35:19.384] 127/137 Test [#132](/bitcoin-bitcoin/132/): wallet_crypto_tests .................. Passed 2.48 sec
1[14:35:19.385] Start 137: db_tests
2[14:35:19.572] 128/137 Test [#137](/bitcoin-bitcoin/137/): db_tests ............................. Passed 0.19 sec
3[14:35:19.993] 129/137 Test [#131](/bitcoin-bitcoin/131/): spend_tests .......................... Passed 3.13 sec
4[14:35:20.153] 130/137 Test [#31](/bitcoin-bitcoin/31/): coins_tests .......................... Passed 18.60 sec
5[14:35:23.036] 131/137 Test [#136](/bitcoin-bitcoin/136/): walletload_tests ..................... Passed 4.74 sec
6[14:35:24.703] 132/137 Test [#7](/bitcoin-bitcoin/7/): exhaustive_tests ..................... Passed 24.30 sec
7[14:35:25.469] 133/137 Test [#9](/bitcoin-bitcoin/9/): bench_sanity_check_high_priority ..... Passed 25.06 sec
8[14:35:31.233] 134/137 Test [#133](/bitcoin-bitcoin/133/): wallet_tests ......................... Passed 13.97 sec
9[14:35:58.775] 135/137 Test [#123](/bitcoin-bitcoin/123/): coinselector_tests ................... Passed 42.90 sec
10[14:37:41.666] 136/137 Test [#5](/bitcoin-bitcoin/5/): noverify_tests ....................... Passed 161.27 sec
11[14:41:14.403] 137/137 Test [#6](/bitcoin-bitcoin/6/): tests ................................ Passed 374.00 sec
It may be a bit annoying when looking at functional test failures, which have a timestamp included and would then get a “wrong” timestamp, but this seems fine .
Another thing that is a bit annoying is the iwyu output in the final full log, see e.g. #31011 (review)
But the output would need to be edited anyway, so this seems fine as well.