ci: add timestamps to cirrus jobs #30981

pull willcl-ark wants to merge 1 commits into bitcoin:master from willcl-ark:cirrus-timestamps changing 1 files +1 −0
  1. willcl-ark commented at 2:30 pm on September 26, 2024: member

    Currently, debugging where time is spent in the cirrus jobs feels annoying, e.g. trying to see where time may be spent in #30969

    Enable timestamps in the logs for more information.

  2. ci: add timestamps to cirrus jobs f951f1fab2
  3. DrahtBot commented at 2:30 pm on September 26, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, tdb3, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Sep 26, 2024
  5. maflcko commented at 2:39 pm on September 26, 2024: member

    review ACK f951f1fab258f782a88bb006b5ae4ea486705388

    It may be a bit annoying when looking at functional test failures, which have a timestamp included and would then get a “wrong” timestamp, but this seems fine .

  6. tdb3 approved
  7. tdb3 commented at 3:19 pm on September 26, 2024: contributor

    Code Review ACK f951f1fab258f782a88bb006b5ae4ea486705388 There are a few times I’ve wished these timestamps were present.

     0[14:35:19.384] 127/137 Test [#132](/bitcoin-bitcoin/132/): wallet_crypto_tests ..................   Passed    2.48 sec
     1[14:35:19.385]         Start 137: db_tests
     2[14:35:19.572] 128/137 Test [#137](/bitcoin-bitcoin/137/): db_tests .............................   Passed    0.19 sec
     3[14:35:19.993] 129/137 Test [#131](/bitcoin-bitcoin/131/): spend_tests ..........................   Passed    3.13 sec
     4[14:35:20.153] 130/137 Test  [#31](/bitcoin-bitcoin/31/): coins_tests ..........................   Passed   18.60 sec
     5[14:35:23.036] 131/137 Test [#136](/bitcoin-bitcoin/136/): walletload_tests .....................   Passed    4.74 sec
     6[14:35:24.703] 132/137 Test   [#7](/bitcoin-bitcoin/7/): exhaustive_tests .....................   Passed   24.30 sec
     7[14:35:25.469] 133/137 Test   [#9](/bitcoin-bitcoin/9/): bench_sanity_check_high_priority .....   Passed   25.06 sec
     8[14:35:31.233] 134/137 Test [#133](/bitcoin-bitcoin/133/): wallet_tests .........................   Passed   13.97 sec
     9[14:35:58.775] 135/137 Test [#123](/bitcoin-bitcoin/123/): coinselector_tests ...................   Passed   42.90 sec
    10[14:37:41.666] 136/137 Test   [#5](/bitcoin-bitcoin/5/): noverify_tests .......................   Passed  161.27 sec
    11[14:41:14.403] 137/137 Test   [#6](/bitcoin-bitcoin/6/): tests ................................   Passed  374.00 sec
    
  8. hebasto approved
  9. hebasto commented at 3:40 pm on September 26, 2024: member
    ACK f951f1fab258f782a88bb006b5ae4ea486705388.
  10. fanquake merged this on Sep 26, 2024
  11. fanquake closed this on Sep 26, 2024

  12. maflcko commented at 8:51 am on October 2, 2024: member

    It may be a bit annoying when looking at functional test failures, which have a timestamp included and would then get a “wrong” timestamp, but this seems fine .

    Another thing that is a bit annoying is the iwyu output in the final full log, see e.g. #31011 (review)

    But the output would need to be edited anyway, so this seems fine as well.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-08 16:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me