Related to #15774
This PR adds instructions to the release notes to tell users how to self sign bitcoin core binaries so they are executable on macOS.
Tested on
0Darwin Chriss-MacBook-Pro.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:46 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6031 arm64
These commands do not appear to require ‘phoning home’. I tested these commands when disconnected from a network connection and things worked.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Concept ACK | hebasto, RandyMcMillan, itornaza |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Remove link and clear up language
0@@ -0,0 +1,19 @@
1+How to Upgrade
I think you’d want to edit the template doc/release-notes-empty-template.md, because snippets are deleted.
Also, wasn’t the point that this no longer works on macOS Sequoia? Would be nice to test it there.
Moved to releae-notes-empty-template.md
Idk about Sequoia, that OS appears to have shipped 10 days ago. I think its safe to assume the majority of our macOS users will be encountering this issue when trying to use 28.0 (and older versions of bitcoin core).
Bitcoin-Qt.app, as I would think that might be what a lot (majority?) of MacOS users are downloading.
I think it might be good to also include instructions for signing a downloaded
Bitcoin-Qt.app, as I would think that might be what a lot (majority?) of MacOS users are downloading.
I presume this is the GUI? I’m not sure if assuming command line literacy makes sense for that.
I think it might be good to also include instructions for signing a downloaded
Bitcoin-Qt.app, as I would think that might be what a lot (majority?) of MacOS users are downloading.I presume this is the GUI? I’m not sure if assuming command line literacy makes sense for that.
Well, as the app does not work at all on macOS without that it seems better to me to at least provide the required steps, rather than nothing at all?
I think it might be good to also include instructions for signing a downloaded
Bitcoin-Qt.app, as I would think that might be what a lot (majority?) of MacOS users are downloading.I presume this is the GUI? I’m not sure if assuming command line literacy makes sense for that.
Well, as the app does not work at all on macOS without that it seems better to me to at least provide the required steps, rather than nothing at all?
That makes sense to me, but i’m not user of the .app. I’m unfamiliar with how it works and don’t know how to verify it works. I’ll let someone else contribute that in a different PR.
That makes sense to me, but i’m not user of the
.app. I’m unfamiliar with how it works and don’t know how to verify it works. I’ll let someone else contribute that in a different PR.
it’s the same instructions, just for the .app file
Concept ACK.
I’ve tested the content of the bitcoin-28.0rc2-x86_64-apple-darwin.tar.gz on macOS (Apple M1) Sequoia 15.0 (24A335).
The code sign -s - ... command is not required to run downloaded binaries. However, I didn’t test other maOS versions.
The code sign -s - … command is not required to run downloaded binaries.
How are the binaries running if they aren’t codesigned at all? If this isn’t an issue why are we adding these instructions?
The GUI users may be able to temporarily override their Mac security settings to open it (tested on the same machine for Bitcoin Core.app downloaded from https://bitcoincore.org/bin/bitcoin-core-28.0/test.rc2/bitcoin-28.0rc2-x86_64-apple-darwin.zip).
UPD. Also tested for https://bitcoincore.org/bin/bitcoin-core-28.0/test.rc2/bitcoin-28.0rc2-arm64-apple-darwin.zip.
Concept ACK.
I’ve tested the content of the
bitcoin-28.0rc2-x86_64-apple-darwin.tar.gzon macOS (Apple M1) Sequoia 15.0 (24A335).The
code sign -s - ...command is not required to run downloaded binaries. However, I didn’t test other maOS versions.
I certainly see an error and ask for it to be removed, also on 15.0
0~/Downloads
1$ tar xzvf bitcoin-28.0rc1-arm64-apple-darwin.tar.gz
2x bitcoin-28.0rc1/
3x bitcoin-28.0rc1/bin/
4x bitcoin-28.0rc1/bin/bitcoin-cli
5x bitcoin-28.0rc1/bin/bitcoin-qt
6x bitcoin-28.0rc1/bin/bitcoin-tx
7x bitcoin-28.0rc1/bin/bitcoin-util
8x bitcoin-28.0rc1/bin/bitcoin-wallet
9x bitcoin-28.0rc1/bin/bitcoind
10x bitcoin-28.0rc1/bin/test_bitcoin
11x bitcoin-28.0rc1/bitcoin.conf
12x bitcoin-28.0rc1/share/
13x bitcoin-28.0rc1/share/man/
14x bitcoin-28.0rc1/share/man/man1/
15x bitcoin-28.0rc1/share/man/man1/bitcoin-cli.1
16x bitcoin-28.0rc1/share/man/man1/bitcoin-qt.1
17x bitcoin-28.0rc1/share/man/man1/bitcoin-tx.1
18x bitcoin-28.0rc1/share/man/man1/bitcoin-util.1
19x bitcoin-28.0rc1/share/man/man1/bitcoin-wallet.1
20x bitcoin-28.0rc1/share/man/man1/bitcoind.1
21x bitcoin-28.0rc1/share/rpcauth/
22x bitcoin-28.0rc1/share/rpcauth/README.md
23x bitcoin-28.0rc1/share/rpcauth/rpcauth.py
24
25~/Downloads
26$ cd bitcoin-28.0rc1/
27
28~/Downloads/bitcoin-28.0rc1
29$ ./bin/bitcoind --version
30fish: Job 1, './bin/bitcoind --version' terminated by signal SIGKILL (Forced quit)
31
32~/Downloads/bitcoin-28.0rc1
33✗ cd bin
34
35…/Downloads/bitcoin-28.0rc1/bin
36$ xattr -d com.apple.quarantine bitcoin-cli bitcoin-qt bitcoin-tx bitcoin-util bitcoin-wallet bitcoind test_bitcoin
37
38…/Downloads/bitcoin-28.0rc1/bin
39$ ./bitcoind --version
40fish: Job 1, './bitcoind --version' terminated by signal SIGKILL (Forced quit)
41
42…/Downloads/bitcoin-28.0rc1/bin
43✗ codesign -fs will-clark-codesigning bitcoind
44
45…/Downloads/bitcoin-28.0rc1/bin
46$ ./bitcoind --version
47Bitcoin Core version v28.0.0rc1
48Copyright (C) 2009-2024 The Bitcoin Core developers
49
50Please contribute if you find Bitcoin Core useful. Visit
51<https://bitcoincore.org/> for further information about the software.
52The source code is available from <https://github.com/bitcoin/bitcoin>.
53
54This is experimental software.
55Distributed under the MIT software license, see the accompanying file COPYING
56or <https://opensource.org/licenses/MIT>
x86_64 arch on arm64 machine. They were using the Rosetta framework.
I downloaded binaries for
x86_64arch onarm64machine. They were using the Rosetta framework.
A very sneaky undocumented workaround!
Concept ACK.
I can also verify that the steps described in the pr work properly on macOS Sequoia 15.0 (24A335).
I think it might be good to also include instructions for signing a downloaded
Bitcoin-Qt.app, as I would think that might be what a lot (majority?) of macOS users are downloading.
In my view, users who download the app directly can always be referenced to the standard Apple procedure for installing unknown developer apps https://support.apple.com/guide/mac-help/open-a-mac-app-from-an-unknown-developer-mh40616/mac. This should not be an issue for them as it is a very common thing. Otherwise, the steps described in the pr can be easily adapted and applied to the Bitcoin Core.app as well.