doc/build-osx.md:brew relinking note #30993

pull RandyMcMillan wants to merge 1 commits into bitcoin:master from bitcoincore-dev:2001/863168/294116/d812cf1189/1e0e06f98d changing 1 files +11 −0

RandyMcMillan commented at 3:17 AM on September 28, 2024: contributor

No description provided.
DrahtBot commented at 3:17 AM on September 28, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
in doc/build-osx.md:205 in 1e0e06f98d outdated
```
 201 | @@ -202,6 +202,12 @@ If `sqlite` or `qt` are not installed, this will throw an error.
 202 |  cmake -B build -DBUILD_GUI=ON
 203 |  ```
 204 |  
 205 | +### **If cmake is not detecting brew installed dependencies - try relinking them.**
```
hebasto commented at 9:11 AM on September 28, 2024:

Is this issue CMake specific?

RandyMcMillan commented at 6:18 PM on September 28, 2024:

good point - i will move it to the end of the "brew install" list and make a more general instruction.

-thanks
DrahtBot added the label CI failed on Sep 28, 2024
DrahtBot removed the label CI failed on Sep 29, 2024
doc/build-osx.md:brew relinking note e2e915677a
RandyMcMillan force-pushed on Sep 29, 2024
in doc/build-osx.md:190 in e2e915677a
```
 185 | +
 186 | +#### ***Try relinking brew installed dependencies - if they are not detected when building.***
 187 | +##### Example:
 188 | +
 189 | +```bash
 190 | +brew unlink qrencode && brew link qrencode
```
l0rinc commented at 11:15 AM on September 30, 2024:

Is this related to https://github.com/bitcoin/bitcoin/pull/30454/files#r1709145204?

l0rinc on Aug 8 👍 GUI is working with cmake, but I had to execute a brew link qt5 --force as well after brew install qt@5 (applies to Autotools as well)

RandyMcMillan commented at 12:58 AM on October 2, 2024:

This PR isn't in response to any issue or comment. I just noticed it may be useful to have a note about relinking.

fanquake commented at 9:46 AM on October 2, 2024:

This PR isn't in response to any issue or comment. I just noticed it may be useful to have a note about relinking.

We don't really add general things to our build instructions that "may" be useful, especially if they aren't addressing a problem someone has encountered. In any case, in this instance, if your package manager is broken, or incorrectly installing dependencies such that they are broken, that isn't a Bitcoin Core issue, and I don't think we need to add anything here.

RandyMcMillan commented at 12:47 PM on October 3, 2024:

In scenarios like this - the build just fails - a few extra lines for someone actually using the build instructions "may" find it useful.

Additionally a similar note "may" be useful in a scenarios where linuxbrew is being used.

I dont see much downside in trying to make build instructions a little more friendly to users - with minimal experience - building from source.

I'd like to think it is encouraged.
RandyMcMillan closed this on Oct 3, 2024
bitcoin locked this on Oct 3, 2025

Contributors

doc/build-osx.md:brew relinking note #30993

Code Coverage

Reviews