testnet4
config section header documentation for the config file.
doc: add testnet4 section header for config file #31007
pull MarnixCroes wants to merge 1 commits into bitcoin:master from MarnixCroes:testnet4-conf-doc changing 2 files +5 −2-
MarnixCroes commented at 12:04 pm on October 1, 2024: contributorThis PR adds the missing
-
DrahtBot commented at 12:04 pm on October 1, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK Sjors, pablomartin4btc, fjahr, tdb3 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Docs on Oct 1, 2024
-
in doc/bitcoin-conf.md:34 in a7b75f2803 outdated
30@@ -31,7 +31,7 @@ Comments may appear in two ways: 31 ### Network specific options 32 33 Network specific options can be: 34-- placed into sections with headers `[main]` (not `[mainnet]`), `[test]` (not `[testnet]`), `[signet]` or `[regtest]`; 35+- placed into sections with headers `[main]` (not `[mainnet]`), `[test]` (not `[testnet]`, for testnet3), `testnet4`, `[signet]` or `[regtest]`;
maflcko commented at 1:01 pm on October 1, 2024:0- placed into sections with headers `[main]` (not `[mainnet]`), `[test]` (not `[testnet]`, for testnet3), `[testnet4]`, `[signet]` or `[regtest]`;
It would be
[testnet4]
, nottestnet4
.
MarnixCroes commented at 1:19 pm on October 1, 2024:fixed, my bad…doc: add testnet4 section header for config file 61cdb1c9d8MarnixCroes force-pushed on Oct 1, 2024Sjors commented at 2:22 pm on October 1, 2024: memberACK 61cdb1c9d83778b95f4f9596f34617b7a191d0a5pablomartin4btc commented at 6:02 pm on October 1, 2024: memberACK 61cdb1c9d83778b95f4f9596f34617b7a191d0a5
BUILDDIR
would need to be updated incontrib/devtools/gen-bitcoin-conf.sh
, otherwisebitcoind
won’t be found.fjahr commented at 9:44 pm on October 1, 2024: contributorACK 61cdb1c9d83778b95f4f9596f34617b7a191d0a5tdb3 approvedtdb3 commented at 0:43 am on October 2, 2024: contributorACK 61cdb1c9d83778b95f4f9596f34617b7a191d0a5
Good find. Thanks.
fanquake merged this on Oct 2, 2024fanquake closed this on Oct 2, 2024
MarnixCroes deleted the branch on Oct 3, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 15:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me