doc: add testnet4 section header for config file #31007

pull MarnixCroes wants to merge 1 commits into bitcoin:master from MarnixCroes:testnet4-conf-doc changing 2 files +5 −2
  1. MarnixCroes commented at 12:04 pm on October 1, 2024: contributor
    This PR adds the missing testnet4 config section header documentation for the config file.
  2. DrahtBot commented at 12:04 pm on October 1, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK Sjors, pablomartin4btc, fjahr, tdb3

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Oct 1, 2024
  4. Sjors commented at 12:55 pm on October 1, 2024: member
    ~utACK a7b75f28039324859d180606512c5fa7cb124428~ (see @maflcko’s comment below)
  5. in doc/bitcoin-conf.md:34 in a7b75f2803 outdated
    30@@ -31,7 +31,7 @@ Comments may appear in two ways:
    31 ### Network specific options
    32 
    33 Network specific options can be:
    34-- placed into sections with headers `[main]` (not `[mainnet]`), `[test]` (not `[testnet]`), `[signet]` or `[regtest]`;
    35+- placed into sections with headers `[main]` (not `[mainnet]`), `[test]` (not `[testnet]`, for testnet3), `testnet4`, `[signet]` or `[regtest]`;
    


    maflcko commented at 1:01 pm on October 1, 2024:
    0- placed into sections with headers `[main]` (not `[mainnet]`), `[test]` (not `[testnet]`, for testnet3), `[testnet4]`, `[signet]` or `[regtest]`;
    

    It would be [testnet4], not testnet4.


    MarnixCroes commented at 1:19 pm on October 1, 2024:
    fixed, my bad…
  6. doc: add testnet4 section header for config file 61cdb1c9d8
  7. MarnixCroes force-pushed on Oct 1, 2024
  8. Sjors commented at 2:22 pm on October 1, 2024: member
    ACK 61cdb1c9d83778b95f4f9596f34617b7a191d0a5
  9. pablomartin4btc commented at 6:02 pm on October 1, 2024: member

    ACK 61cdb1c9d83778b95f4f9596f34617b7a191d0a5

    BUILDDIR would need to be updated in contrib/devtools/gen-bitcoin-conf.sh, otherwise bitcoind won’t be found.

  10. fjahr commented at 9:44 pm on October 1, 2024: contributor
    ACK 61cdb1c9d83778b95f4f9596f34617b7a191d0a5
  11. tdb3 approved
  12. tdb3 commented at 0:43 am on October 2, 2024: contributor

    ACK 61cdb1c9d83778b95f4f9596f34617b7a191d0a5

    Good find. Thanks.

  13. fanquake merged this on Oct 2, 2024
  14. fanquake closed this on Oct 2, 2024

  15. MarnixCroes deleted the branch on Oct 3, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-08 16:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me