test: enhance p2p_orphan_handling #31037

1. 
   tdb3 commented at 5:10 pm on October 5, 2024: contributor

   Previously, p2p_orphan_handling relied on checking the debug log for orphanage changes. This updates the tests to reduce debug log checking and add checks using tx_in_orphanage() and getorphantxs introduced in #30793.
2. 
   DrahtBot commented at 5:10 pm on October 5, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31037.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	glozow, rkrux, danielabrozzoni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Oct 5, 2024
4. test: reduce assert_debug_log reliance

   p2p_orphan_handling now uses tx_in_orphanage
   to more directly check for inclusion/exclusion
   in the orphanage.

   33af14b62e
5. test: enhance p2p_orphan_handling

   Increases test robustness by adding
   checks for orphanage size and presence
   of orphans in the orphanage

   9de9c858d5
6. tdb3 force-pushed on Oct 26, 2024
7. tdb3 marked this as ready for review on Oct 26, 2024
8. 
   glozow commented at 7:32 pm on October 28, 2024: member

   light code review ACK 9de9c858d5aa412e1c6086e564fbe85984a4f2d5
9. rkrux approved
10. 
    rkrux commented at 7:25 am on October 29, 2024: none

    tACK 9de9c858d5aa412e1c6086e564fbe85984a4f2d5

    Successful make and all functional tests. This is my preference as well to use the getorphantxs RPC for asserting over searching in the debug logs.

11. danielabrozzoni approved
12. 
    danielabrozzoni commented at 6:49 pm on November 8, 2024: contributor

    ACK 9de9c858d5aa412e1c6086e564fbe85984a4f2d5
13. glozow merged this on Nov 12, 2024
14. glozow closed this on Nov 12, 2024

    ---

15. 
    instagibbs commented at 5:51 pm on November 12, 2024: member

    nice cleanup :+1:

Contributors
tdb3 DrahtBot glozow rkrux danielabrozzoni instagibbs

Labels
Tests