test: enhance p2p_orphan_handling #31037

pull tdb3 wants to merge 2 commits into bitcoin:master from tdb3:enhance_p2p_orphan_handling changing 1 files +27 −13

tdb3 commented at 5:10 PM on October 5, 2024: contributor

Previously, p2p_orphan_handling relied on checking the debug log for orphanage changes. This updates the tests to reduce debug log checking and add checks using tx_in_orphanage() and getorphantxs introduced in #30793.
DrahtBot commented at 5:10 PM on October 5, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31037.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK glozow, rkrux, danielabrozzoni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Oct 5, 2024

Type	Reviewers
ACK	glozow, rkrux, danielabrozzoni

test: reduce assert_debug_log reliance

p2p_orphan_handling now uses tx_in_orphanage
to more directly check for inclusion/exclusion
in the orphanage.

33af14b62e

test: enhance p2p_orphan_handling

Increases test robustness by adding
checks for orphanage size and presence
of orphans in the orphanage

9de9c858d5

tdb3 marked this as ready for review on Oct 26, 2024
glozow commented at 7:32 PM on October 28, 2024: member

light code review ACK 9de9c858d5aa412e1c6086e564fbe85984a4f2d5
rkrux approved
rkrux commented at 7:25 AM on October 29, 2024: contributor

tACK 9de9c858d5aa412e1c6086e564fbe85984a4f2d5

Successful make and all functional tests. This is my preference as well to use the getorphantxs RPC for asserting over searching in the debug logs.
danielabrozzoni approved
danielabrozzoni commented at 6:49 PM on November 8, 2024: member

ACK 9de9c858d5aa412e1c6086e564fbe85984a4f2d5
glozow merged this on Nov 12, 2024
glozow closed this on Nov 12, 2024
instagibbs commented at 5:51 PM on November 12, 2024: member

nice cleanup :+1:
TheCharlatan referenced this in commit a73b2bd0f0 on Nov 14, 2024
bug-castercv502 referenced this in commit fdcc066ca0 on Sep 28, 2025
bitcoin locked this on Nov 12, 2025

Contributors

Labels