lint: markdown check linting build outputs #31044

1. 
   fanquake commented at 10:03 am on October 7, 2024: member

   Running the linter locally I see this output:

    0DOCKER_BUILDKIT=1 docker build -t bitcoin-linter --file "./ci/lint_imagefile" ./ && docker run --rm -v $(pwd):/bitcoin -it bitcoin-linter
    1<snip>
    2One or more markdown links are broken.
    3
    4Relative links are preferred (but not required) as jumping to file works natively within Emacs.
    5
    6Markdown link errors found:
    7[Err ] ./depends/work/build/x86_64-apple-darwin/qt/6.7.2-b49980c3ba7/qtbase/tests/auto/corelib/serialization/qxmlstream/XML-Test-Suite/xmlconf/xmlconf-20031030.htm (90, 1) => xmlts20031030.zip - Target filename not found.
    8[Err ] ./depends/work/build/x86_64-apple-darwin/qt/6.7.2-b49980c3ba7/qtbase/tests/auto/corelib/serialization/qxmlstream/XML-Test-Suite/xmlconf/xmlconf-20031030.htm (39, 55) => /Member/#confidential - Target not found.
    9[Err ] ./depends/work/build/x86_64-apple-darwin/qt/6.7.2-b49980c3ba7/qtbase/tests/auto/corelib/serialization/qxmlstream/XML-Test-Suite/xmlconf/xmlconf-20020521.htm (39, 55) => /Member/#confidential - Target not found.
   10[Err ] ./depends/work/build/x86_64-apple-darwin/qt/6.7.2-b49980c3ba7/qtbase/tests/auto/corelib/serialization/qxmlstream/XML-Test-Suite/xmlconf/xmlconf-20031030.htm (95, 1) => xmlts20031030.tar - Target filename not found.
   11[Err ] ./depends/work/build/x86_64-apple-darwin/qt/6.7.2-b49980c3ba7/qtbase/tests/auto/corelib/serialization/qxmlstream/XML-Test-Suite/xmlconf/xmlconf-20031030.htm (77, 1) => xmlconf-20020606.htm - Target filename not found.
   12
   13                
   14^---- ⚠️ Failure generated from lint check 'markdown'!
   15Check that markdown links resolve
   16All checks passed!
   17src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
   18src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
   19GOOD
   20<snip>
   

   The output is somewhat confusing because it seems to simultaneously claim that things are broken, but that all checks passed? In any case, the linter should not be running on files that are not our source code, or is gitignored. i.e here it’s running on Qt build outputs, but it shouldn’t be linting anything under depends/work/, depends/built/, depends/${host}/ etc.

2. 
   maflcko commented at 10:17 am on October 7, 2024: member

   simultaneously claim that things are broken, but that all checks passed?

   Some lint checks print output on success, so that may be confusing. I think the only relevant information for errors is the presence of ⚠️, which should exactly correlate with a non-zero exit status. Could you check echo $??

   The mlc issue is tracked in https://www.github.com/becheran/mlc/pull/96

3. maflcko added the label Tests on Oct 7, 2024
4. 
   willcl-ark commented at 10:59 am on November 29, 2024: member

   The mlc issue is tracked in github.com/becheran/mlc/pull/96

   This PR has been merged, but we would ideally wait for it to be included in a tagged release so we can download pre-build binaries.

   I have asked in the PR if a new tag can be released, and will update here.

Contributors
fanquake maflcko willcl-ark

Labels
Tests