build: Bump minimum supported macOS to 13.0

hebasto commented at 1:12 pm on October 7, 2024: member

Running Bitcoin Core on unsupported OSes may expose users to security issues.

macOS Monterey 12 received its final security update (12.7.6) on July 2024. Apple classifies the hardware that can run macOS 12 at most as “obsolete worldwide”.

hebasto added the label Build system on Oct 7, 2024

hebasto added this to the milestone 29.0 on Oct 7, 2024

DrahtBot commented at 1:12 pm on October 7, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	maflcko, m3dwards, itornaza
Concept ACK	Sjors, theuni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#30997 (build: Switch to Qt 6 by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Sjors commented at 1:40 pm on October 7, 2024: member

Concept ACK. See #30997 (comment)

maflcko commented at 2:06 pm on October 7, 2024: member

You’ll also have to remove doc/build-osx.md:54:For macOS 11 (Big Sur) and 12 (Monterey) you need to install a more recent version of llvm., no?

maflcko added the label DrahtBot Guix build requested on Oct 7, 2024

hebasto force-pushed on Oct 7, 2024

hebasto commented at 2:11 pm on October 7, 2024: member

You’ll also have to remove doc/build-osx.md:54:For macOS 11 (Big Sur) and 12 (Monterey) you need to install a more recent version of llvm., no?

Thanks! Updated.

theuni commented at 2:53 pm on October 7, 2024: member

Concept ACK.

DrahtBot added the label CI failed on Oct 7, 2024

DrahtBot removed the label CI failed on Oct 7, 2024

Sjors commented at 5:35 pm on October 7, 2024: member

Trying to test if this still works on macOS 13.7 I got stuck. Most likely unrelated to the changes here, but see #31050.

DrahtBot commented at 8:53 pm on October 7, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 62e4516722115c2d5aeb6c197abc73ca7c078b23(master)	commit 84043640367e22d9cc0f895a1507af274530c146(master and this pull)
SHA256SUMS.part	`f2d49fb72517ef0c...`	`ea00720274b7ade5...`
*-aarch64-linux-gnu-debug.tar.gz	`d37cbe26a25f7540...`	`31627ee1bae0ca1f...`
*-aarch64-linux-gnu.tar.gz	`42b4d4db0c531caf...`	`0610a075236ff01e...`
*-arm-linux-gnueabihf-debug.tar.gz	`63eddcf3cfdb6c32...`	`139e4c2cf275d86c...`
*-arm-linux-gnueabihf.tar.gz	`fd2eb3904357b5f4...`	`dab9bc493d7d2d06...`
*-arm64-apple-darwin-unsigned.tar.gz	`71a08c8f938313cf...`	`f650d56db68268ff...`
*-arm64-apple-darwin-unsigned.zip	`ed11994d8f055418...`	`bbb0fd5d2b37cd09...`
*-arm64-apple-darwin.tar.gz	`0c11a002f4f3030c...`	`020931cb9a685625...`
*-powerpc64-linux-gnu-debug.tar.gz	`a76483c3abcddcc1...`	`750cda9554a3c00c...`
*-powerpc64-linux-gnu.tar.gz	`335ec17b370a19d5...`	`cdc4269095d92a51...`
*-riscv64-linux-gnu-debug.tar.gz	`8494e354e088382e...`	`596a2fb0713f8d2d...`
*-riscv64-linux-gnu.tar.gz	`457df2421685bdda...`	`be553844e572e74c...`
*-x86_64-apple-darwin-unsigned.tar.gz	`3cedc5861a78c8a5...`	`a425d7f297a2eb58...`
*-x86_64-apple-darwin-unsigned.zip	`19b332dccbc792b4...`	`f64d2d63e0a0fba7...`
*-x86_64-apple-darwin.tar.gz	`54c6788eb266f818...`	`4822b479baf275b4...`
*-x86_64-linux-gnu-debug.tar.gz	`a761c3712ed00392...`	`ab5604282d2259fa...`
*-x86_64-linux-gnu.tar.gz	`fceda20d8f50b5ab...`	`c89972e7b17e6da1...`
*.tar.gz	`38978a4be1a7c7eb...`	`29b72a670e9115bb...`
guix_build.log	`b4092f80775416ae...`	`dccca0efc3ea6e12...`
guix_build.log.diff		`b0f55603405b25ef...`

DrahtBot removed the label DrahtBot Guix build requested on Oct 7, 2024

hebasto commented at 4:07 pm on October 8, 2024: member

Qt 6.8 LTS dropped support for macOS 11.

itornaza approved

itornaza commented at 6:11 pm on October 9, 2024: contributor

Concept ACK

jarolrod commented at 3:04 am on October 10, 2024: member

concept ack

maflcko commented at 6:28 am on October 10, 2024: member

review ACK 05d25304bc4e0c3058c8ee8a89448ce63ac77304

Didn’t test, because I don’t use or have a macos.

DrahtBot requested review from Sjors on Oct 10, 2024

DrahtBot requested review from theuni on Oct 10, 2024

DrahtBot requested review from itornaza on Oct 10, 2024

itornaza approved

itornaza commented at 8:08 am on October 10, 2024: contributor

tested ACK 05d25304bc4e0c3058c8ee8a89448ce63ac77304

Run all tests including the functional and extended on macOS 15.0.1 and everything checks out ok.

Unfortunately, I could not test on macOS previous to 12, as I have converted all my older macs to run Linux.

fanquake commented at 10:11 am on October 10, 2024: member

Running Bitcoin Core on unsupported OSes may expose users to security issues. macOS Big Sur 11 received its last security update (11.7.10) over a year ago.

If this is the reasoning we are going to use, shouldn’t this be bumping to 10.13, given 10.12 is also “unsupported” in terms of security updates?

theuni commented at 3:57 pm on October 11, 2024: member

Running Bitcoin Core on unsupported OSes may expose users to security issues. macOS Big Sur 11 received its last security update (11.7.10) over a year ago.

If this is the reasoning we are going to use, shouldn’t this be bumping to 10.13, given 10.12 is also “unsupported” in terms of security updates?

Yes, good point. I didn’t realize 12.0 was eol’d. We shouldn’t let qt dictate what we support.

Agree that 13 would make more sense, especially considering v29 won’t be tagged for quite a while.

maflcko commented at 3:17 pm on October 14, 2024: member

Doing it for 11 seemed obvious and uncontroversial, but dropping 12 seems fine as well. Either here, or in a follow-up.

hebasto commented at 8:58 am on October 15, 2024: member

Running Bitcoin Core on unsupported OSes may expose users to security issues. macOS Big Sur 11 received its last security update (11.7.10) over a year ago.

If this is the reasoning we are going to use, shouldn’t this be bumping to 10.13, given 10.12 is also “unsupported” in terms of security updates?

You mean “13.0” and “12.0”, right?

For the reference, macOS 12 was last updated on 2024-07-29. The three most recent Apple updates did not affect macOS 12.

hebasto commented at 9:07 am on October 15, 2024: member

If we raise the minimum supported macOS version to 13.0, it would mean dropping support for hardware like MacBook Pro (15-inch, 2016) and older, which Apple classifies as “obsolete worldwide”.

I’ll update this PR shortly.

build: Bump minimum supported macOS to 13.0

Running Bitcoin Core on unsupported OSes may expose users to security
issues.

macOS Monterey 12 received its final security update (12.7.6) on July
2024. Apple classifies the hardware that can run macOS 12 at most as
"obsolete worldwide".

a0e089a71d

hebasto renamed this:
~~build: Bump minimum supported macOS to 12.0~~
build: Bump minimum supported macOS to 13.0
on Oct 15, 2024

hebasto force-pushed on Oct 15, 2024

hebasto commented at 9:21 am on October 15, 2024: member

Running Bitcoin Core on unsupported OSes may expose users to security issues. macOS Big Sur 11 received its last security update (11.7.10) over a year ago.

If this is the reasoning we are going to use, shouldn’t this be bumping to 10.13, given 10.12 is also “unsupported” in terms of security updates?

Yes, good point. I didn’t realize 12.0 was eol’d. We shouldn’t let qt dictate what we support.

Agree that 13 would make more sense, especially considering v29 won’t be tagged for quite a while.

Done.

The PR description has been updated.

maflcko commented at 9:24 am on October 15, 2024: member

lgtm ACK a0e089a71dc449f4cc177d6eb3050400e63f4b3f

Didn’t test, because I don’t use or have a macos.

DrahtBot requested review from itornaza on Oct 15, 2024

m3dwards commented at 9:39 am on October 15, 2024: contributor

ACK a0e089a71dc449f4cc177d6eb3050400e63f4b3f

Tested on ARM Mac 14.6

maflcko added the label DrahtBot Guix build requested on Oct 15, 2024

itornaza approved

itornaza commented at 9:46 am on October 15, 2024: contributor

reACK a0e089a71dc449f4cc177d6eb3050400e63f4b3f

maflcko removed review request from Sjors on Oct 15, 2024

maflcko requested review from Sjors on Oct 15, 2024

hebasto commented at 10:01 am on October 15, 2024: member

My Guix build:

0aarch64
111dcf8e401c3cf7a911bf08cf801d354b53d8f4266b139625ef12f502050ee4f  guix-build-a0e089a71dc4/output/arm64-apple-darwin/SHA256SUMS.part
2d00bfbd05b870fdd4a1b7626bc0e851a88a3b958a1ff78d6822ed85f743c7c8a  guix-build-a0e089a71dc4/output/arm64-apple-darwin/bitcoin-a0e089a71dc4-arm64-apple-darwin-unsigned.tar.gz
3fc0dcd590d775f6e565ec6d7a005e525891b90b5afdd1f6d429d9f615792ca2b  guix-build-a0e089a71dc4/output/arm64-apple-darwin/bitcoin-a0e089a71dc4-arm64-apple-darwin-unsigned.zip
4a16791436c034c7f84eb9acdc11ddb5a6f95d173af0b73146ac3d9239028be7d  guix-build-a0e089a71dc4/output/arm64-apple-darwin/bitcoin-a0e089a71dc4-arm64-apple-darwin.tar.gz
50d70a5e514d93f44dc02794b604e37ee5a7f30952c2561d79e3141806e2eabff  guix-build-a0e089a71dc4/output/dist-archive/bitcoin-a0e089a71dc4.tar.gz
620b48785ebc782acc4aabd59944e4e923d6c484f000f39d601747f10b3269242  guix-build-a0e089a71dc4/output/x86_64-apple-darwin/SHA256SUMS.part
7fd35b25569b68d3df1a50777a60bc370694b61a1073300db113118d583811af8  guix-build-a0e089a71dc4/output/x86_64-apple-darwin/bitcoin-a0e089a71dc4-x86_64-apple-darwin-unsigned.tar.gz
8b8e88abb78526371fac9756c5edfd8d0a6ccc44a62a3dd4502337c0390ff6c2c  guix-build-a0e089a71dc4/output/x86_64-apple-darwin/bitcoin-a0e089a71dc4-x86_64-apple-darwin-unsigned.zip
930cb693d61e12dca42c23395b9e29fc31d2002d36d7955e35163bac083b33089  guix-build-a0e089a71dc4/output/x86_64-apple-darwin/bitcoin-a0e089a71dc4-x86_64-apple-darwin.tar.gz

DrahtBot commented at 9:13 pm on October 15, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 0ca1d1bf69ca364393e924cf41becfde1b68126c(master)	commit 0b38563a13647a10379547a57d75f4e8aafa4d17(master and this pull)
SHA256SUMS.part	`4cea7595159b6144...`	`81844a69a7cfe2fb...`
*-aarch64-linux-gnu-debug.tar.gz	`78b8e827f16422d2...`	`d95a1411e2376165...`
*-aarch64-linux-gnu.tar.gz	`258288fe29be2b80...`	`0958e292d256725b...`
*-arm-linux-gnueabihf-debug.tar.gz	`ef1b3ba7c2de3f87...`	`bc8290740783ccc4...`
*-arm-linux-gnueabihf.tar.gz	`11bbd9331a382f6f...`	`958f5256ff294024...`
*-arm64-apple-darwin-unsigned.tar.gz	`95544c8d9e21c1c1...`	`5d19b3f985d2a981...`
*-arm64-apple-darwin-unsigned.zip	`f48e72cb8060eeae...`	`3955bf2e799c555f...`
*-arm64-apple-darwin.tar.gz	`ffd61732ed887b6c...`	`f101521557dafa08...`
*-powerpc64-linux-gnu-debug.tar.gz	`e29dfb26e3ccd8cc...`	`fbb9f858f66727ff...`
*-powerpc64-linux-gnu.tar.gz	`9bca089def76b885...`	`0c8fb196b6a38d20...`
*-riscv64-linux-gnu-debug.tar.gz	`4341a2a5227e72ba...`	`01c31dcc69684f4b...`
*-riscv64-linux-gnu.tar.gz	`50b0fcc5f0eaa717...`	`3df8b371bab0afe4...`
*-x86_64-apple-darwin-unsigned.tar.gz	`a1069f87839e5424...`	`ff843abe3cf39152...`
*-x86_64-apple-darwin-unsigned.zip	`201317deef3be88d...`	`bae934ff8ab8c7d3...`
*-x86_64-apple-darwin.tar.gz	`328357128a7f32d8...`	`336dcc784ba54180...`
*-x86_64-linux-gnu-debug.tar.gz	`ce319080e65ba8cf...`	`1024cecd38505782...`
*-x86_64-linux-gnu.tar.gz	`1d1cd929dbc2ec71...`	`abce840ba0c0b1d6...`
*.tar.gz	`69761c49736801f9...`	`1336562635a05ae7...`
guix_build.log	`8b5eff9374d86ad5...`	`057f13096d8c567b...`
guix_build.log.diff		`8fce7c45d0ca7d30...`

DrahtBot removed the label DrahtBot Guix build requested on Oct 15, 2024

fanquake commented at 10:33 am on October 16, 2024: member

Guix Build

 0d454a81e02e24f26f4d163f27ee2b16b83c8f1dfcfe0384ab544b704e27fed09  guix-build-a0e089a71dc4/output/aarch64-linux-gnu/SHA256SUMS.part
 1f5b3771bbb5e2c14e6d91d6a76711df0a9b8ab1b66e118eb6c5aba5686c91902  guix-build-a0e089a71dc4/output/aarch64-linux-gnu/bitcoin-a0e089a71dc4-aarch64-linux-gnu-debug.tar.gz
 2229f0eef5808a7266ac48b9b02dd84b7a7960353125ed7052510a8014074c0da  guix-build-a0e089a71dc4/output/aarch64-linux-gnu/bitcoin-a0e089a71dc4-aarch64-linux-gnu.tar.gz
 30dc7197f0284cf783f7ed5cb4ad15aaceb94588b72d08800cfe35c813b44706d  guix-build-a0e089a71dc4/output/arm-linux-gnueabihf/SHA256SUMS.part
 41e7b8584b2b3e741ad51d2c6776ac0a0ab2940aa9ca30f88158fbf911c80dcaa  guix-build-a0e089a71dc4/output/arm-linux-gnueabihf/bitcoin-a0e089a71dc4-arm-linux-gnueabihf-debug.tar.gz
 54dc1d6e7113a27842ff032719e3c200e2f49f06de3ba1736980a3c64e5503923  guix-build-a0e089a71dc4/output/arm-linux-gnueabihf/bitcoin-a0e089a71dc4-arm-linux-gnueabihf.tar.gz
 611dcf8e401c3cf7a911bf08cf801d354b53d8f4266b139625ef12f502050ee4f  guix-build-a0e089a71dc4/output/arm64-apple-darwin/SHA256SUMS.part
 7d00bfbd05b870fdd4a1b7626bc0e851a88a3b958a1ff78d6822ed85f743c7c8a  guix-build-a0e089a71dc4/output/arm64-apple-darwin/bitcoin-a0e089a71dc4-arm64-apple-darwin-unsigned.tar.gz
 8fc0dcd590d775f6e565ec6d7a005e525891b90b5afdd1f6d429d9f615792ca2b  guix-build-a0e089a71dc4/output/arm64-apple-darwin/bitcoin-a0e089a71dc4-arm64-apple-darwin-unsigned.zip
 9a16791436c034c7f84eb9acdc11ddb5a6f95d173af0b73146ac3d9239028be7d  guix-build-a0e089a71dc4/output/arm64-apple-darwin/bitcoin-a0e089a71dc4-arm64-apple-darwin.tar.gz
100d70a5e514d93f44dc02794b604e37ee5a7f30952c2561d79e3141806e2eabff  guix-build-a0e089a71dc4/output/dist-archive/bitcoin-a0e089a71dc4.tar.gz
1141969cf3a3a7b4ed98daf9f4bd008c68dafc9e0da4f5b57819b5468b9a3e3c83  guix-build-a0e089a71dc4/output/powerpc64-linux-gnu/SHA256SUMS.part
123ca12ebb1b4e7137ad310c20e5b65a739eef4d8b08d00d9e781558140b3a80f6  guix-build-a0e089a71dc4/output/powerpc64-linux-gnu/bitcoin-a0e089a71dc4-powerpc64-linux-gnu-debug.tar.gz
13d3c1eeef5825646424c981e95a0fdc928503bdd667ae08a116e419184c51fd6d  guix-build-a0e089a71dc4/output/powerpc64-linux-gnu/bitcoin-a0e089a71dc4-powerpc64-linux-gnu.tar.gz
1439c9ef33d879ced0256bd02d838204413196d636cef5ba3a608b2c46be0a1a24  guix-build-a0e089a71dc4/output/riscv64-linux-gnu/SHA256SUMS.part
15cd416eeece2e8d8630f75866b5509156be378a22874e23a5085d60571a98be46  guix-build-a0e089a71dc4/output/riscv64-linux-gnu/bitcoin-a0e089a71dc4-riscv64-linux-gnu-debug.tar.gz
165099b45320db47873a72d733f4bf85effb2ce20627735458ed8b516aae78615f  guix-build-a0e089a71dc4/output/riscv64-linux-gnu/bitcoin-a0e089a71dc4-riscv64-linux-gnu.tar.gz
1720b48785ebc782acc4aabd59944e4e923d6c484f000f39d601747f10b3269242  guix-build-a0e089a71dc4/output/x86_64-apple-darwin/SHA256SUMS.part
18fd35b25569b68d3df1a50777a60bc370694b61a1073300db113118d583811af8  guix-build-a0e089a71dc4/output/x86_64-apple-darwin/bitcoin-a0e089a71dc4-x86_64-apple-darwin-unsigned.tar.gz
19b8e88abb78526371fac9756c5edfd8d0a6ccc44a62a3dd4502337c0390ff6c2c  guix-build-a0e089a71dc4/output/x86_64-apple-darwin/bitcoin-a0e089a71dc4-x86_64-apple-darwin-unsigned.zip
2030cb693d61e12dca42c23395b9e29fc31d2002d36d7955e35163bac083b33089  guix-build-a0e089a71dc4/output/x86_64-apple-darwin/bitcoin-a0e089a71dc4-x86_64-apple-darwin.tar.gz
218c5ab300a7c536e1072f0b202277a7b93d4300a25ab0305e6895db5776ffdecb  guix-build-a0e089a71dc4/output/x86_64-linux-gnu/SHA256SUMS.part
22bae293398fe25c846259ee2dbb5853bf6df811b164f7f290e333d8375a8fd48a  guix-build-a0e089a71dc4/output/x86_64-linux-gnu/bitcoin-a0e089a71dc4-x86_64-linux-gnu-debug.tar.gz
2387cc2f80cc91e281bcf87e71b4d1d3d804a5e0f12f8db83f0beb4334674f5b39  guix-build-a0e089a71dc4/output/x86_64-linux-gnu/bitcoin-a0e089a71dc4-x86_64-linux-gnu.tar.gz
24e1c64c75acea77c614fcdad5e78e2c50d9ff40ee195ea8c6192d61ecd014c277  guix-build-a0e089a71dc4/output/x86_64-w64-mingw32/SHA256SUMS.part
253e7bc074f58551740fafa6a962346b363a051cc90f26a87b0c22654fe5bb9e59  guix-build-a0e089a71dc4/output/x86_64-w64-mingw32/bitcoin-a0e089a71dc4-win64-debug.zip
265eced49cd17792112a1ad580b7d7d861808549c0242773c20412f3878211caea  guix-build-a0e089a71dc4/output/x86_64-w64-mingw32/bitcoin-a0e089a71dc4-win64-setup-unsigned.exe
2792273a7aa4a99a5cbfd64284c4d6739d68646f8c35d3b8747b4d132b3118bb4e  guix-build-a0e089a71dc4/output/x86_64-w64-mingw32/bitcoin-a0e089a71dc4-win64-unsigned.tar.gz
28d3d26599cdf3497862e5c218061d81d50f4bfa908826a0f6b5ced1a1dca4946e  guix-build-a0e089a71dc4/output/x86_64-w64-mingw32/bitcoin-a0e089a71dc4-win64.zip

fanquake merged this on Oct 16, 2024

fanquake closed this on Oct 16, 2024

hebasto deleted the branch on Oct 16, 2024

in doc/build-osx.md:56 in a0e089a71d

50@@ -51,8 +51,6 @@ To install, run the following from your terminal:
51 brew install cmake boost pkg-config libevent
52 ```
53 
54-For macOS 11 (Big Sur) and 12 (Monterey) you need to install a more recent version of llvm.
55-
56 ``` bash
57 brew install llvm
58 ```

maflcko commented at 12:40 pm on October 16, 2024:

Shouldn’t this be removed? C.f. 22574046c90c0662f3aa9b1baea074aff54f92a9 ?

Sjors commented at 12:59 pm on October 16, 2024:

Yes that should be removed, along with the rest of the paragraph below.

fanquake commented at 1:23 pm on October 16, 2024:

Removed in #31099.

fanquake referenced this in commit 99e041f86f on Oct 16, 2024

build: Bump minimum supported macOS to 13.0 #31048

Code Coverage

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]