cmake, qt, test: Remove problematic code #31147

1. 
   hebasto commented at 10:31 am on October 24, 2024: member

   Split from #30997.

   The removed code aimed to make Qt’s minimal integration plugin DLL available for test_bitcoin-qt.exe on Windows.

   However, there are two issues:

   1. The code is broken because the destination directory must end with a trailing slash (/).
   2. It is unnecessary because Qt’s minimal integration plugin is not used on Windows. For more details, please refer to the following code:https://github.com/bitcoin/bitcoin/blob/fb46d57d4e7263495c007f4a499a349bff2b21e0/src/qt/test/CMakeLists.txt#L38-L44

   As a side effect, this PR fixes https://github.com/bitcoin-core/gui/issues/842.

2. cmake, qt, test: Remove problematic code

   The removed code aimed to make Qt's minimal integration plugin DLL
   available for `test_bitcoin-qt.exe` on Windows.
   
   However, there are two issues:
   1. The code is broken because the destination directory must end with a
      trailing slash (`/`).
   2. It is unnecessary because Qt's minimal integration plugin is not
      used on Windows. For more details, please refer to the following
      code.

   fb46d57d4e
3. hebasto added the label Build system on Oct 24, 2024
4. hebasto added the label Tests on Oct 24, 2024
5. 
   DrahtBot commented at 10:31 am on October 24, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake, TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. maflcko added this to the milestone 29.0 on Oct 24, 2024
7. 
   fanquake commented at 12:57 pm on October 24, 2024: member

   As a side effect, this PR fixes https://github.com/bitcoin-core/gui/issues/842.

   Tested that this fixes building bitocin-qt on Tumbleweed. -DWITH_QRENCODE=OFF is required, but that seems to be another issue, probably with the libqrencode package on that distro.

   I take it this code has been dead/broken since it was introduced? 975d67369b8f3a33a21fd7618c299c0ec138292c

8. 
   hebasto commented at 1:00 pm on October 24, 2024: member

   I take it this code has been dead/broken since it was introduced? 975d673

   Correct.

9. fanquake approved
10. 
    fanquake commented at 1:01 pm on October 24, 2024: member

    ACK fb46d57d4e7263495c007f4a499a349bff2b21e0
11. TheCharlatan approved
12. 
    TheCharlatan commented at 1:53 pm on October 24, 2024: contributor

    ACK fb46d57d4e7263495c007f4a499a349bff2b21e0
13. fanquake merged this on Oct 24, 2024
14. fanquake closed this on Oct 24, 2024

    ---

15. hebasto deleted the branch on Oct 24, 2024

Contributors
hebasto DrahtBot fanquake TheCharlatan

Labels
Build system Tests

Milestone
29.0