cmake: Revamp FindLibevent module #31181

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:241029-libevent changing 10 files +45 −90
  1. hebasto commented at 7:02 am on October 30, 2024: member

    This PR generalizes the use of find_package / pkg_check_modules, prioritizing the former.

    Addresses #30903 (comment):

    We should also follow up with refactoring the libevent module, to more generically use CMake/pkg-config, rather than restricting the CMake usage to vcpkg. At that point, we’d likely be able to dump pkg-config for the depends path entirely.

    Similar to #30903.

  2. hebasto added the label Build system on Oct 30, 2024
  3. DrahtBot commented at 7:02 am on October 30, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31181.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake
    Concept ACK laanwj

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. hebasto force-pushed on Oct 30, 2024
  5. DrahtBot commented at 7:34 am on October 30, 2024: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/32262273163

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  6. DrahtBot added the label CI failed on Oct 30, 2024
  7. DrahtBot removed the label CI failed on Oct 30, 2024
  8. fanquake commented at 10:51 am on October 30, 2024: member
    Concept ACK - we don’t have to restrict CMake usage to vcpkg, and this will let us make more cleanups.
  9. laanwj commented at 11:50 am on October 30, 2024: member
    Concept ACK
  10. fanquake added this to the milestone 29.0 on Nov 2, 2024
  11. fanquake commented at 12:12 pm on November 6, 2024: member
    Can you rebase this.
  12. hebasto force-pushed on Nov 6, 2024
  13. hebasto commented at 12:50 pm on November 6, 2024: member

    Can you rebase this.

    Sure. Rebased.

  14. hebasto commented at 2:08 pm on November 6, 2024: member

    My Guix build:

     0aarch64
     1c448a9c8d6d436350846ccb998e6a5e2bb66ac519e3539188c4792c6a88f4a1c  guix-build-a6a3cab235cf/output/aarch64-linux-gnu/SHA256SUMS.part
     2613ef63f92fdf0422179fdedad230a7b8c5eb1530c892745bd2d5e76e8fb580c  guix-build-a6a3cab235cf/output/aarch64-linux-gnu/bitcoin-a6a3cab235cf-aarch64-linux-gnu-debug.tar.gz
     32d77932ce9f8808f9673420320faaf9b20d910595f3d3d65687b5cbc55cb84dd  guix-build-a6a3cab235cf/output/aarch64-linux-gnu/bitcoin-a6a3cab235cf-aarch64-linux-gnu.tar.gz
     473019d4fb0f4e54828f70383c769d578112e85c028892ae9bcffa64e0a744a98  guix-build-a6a3cab235cf/output/arm-linux-gnueabihf/SHA256SUMS.part
     5cb1d13753ef47508cfd8b06c95668580c6c17cc64c852f05379eb0523fbfbf5e  guix-build-a6a3cab235cf/output/arm-linux-gnueabihf/bitcoin-a6a3cab235cf-arm-linux-gnueabihf-debug.tar.gz
     647d5a87c465dbfbf1ebc94ac45ad54b8ce12bced200ed8e9d1a3a0b9e10029d3  guix-build-a6a3cab235cf/output/arm-linux-gnueabihf/bitcoin-a6a3cab235cf-arm-linux-gnueabihf.tar.gz
     72bcd4e7933c0a2492714b336d1a71abfef159663e0be24df62513841bdd1e8dc  guix-build-a6a3cab235cf/output/arm64-apple-darwin/SHA256SUMS.part
     8c2ea0008a1eec8d321d9fe1d3444a1c94168e26925b4f9aeb602e781d2f277c4  guix-build-a6a3cab235cf/output/arm64-apple-darwin/bitcoin-a6a3cab235cf-arm64-apple-darwin-unsigned.tar.gz
     9296f22f2abd6b87aebe37957073adf6527e92349ef76c973a0015455cb645738  guix-build-a6a3cab235cf/output/arm64-apple-darwin/bitcoin-a6a3cab235cf-arm64-apple-darwin-unsigned.zip
    109c53fe999e9c8cb392273cec4052e6ba0e1a4d926058ffb1dfb2f79d96f9f61a  guix-build-a6a3cab235cf/output/arm64-apple-darwin/bitcoin-a6a3cab235cf-arm64-apple-darwin.tar.gz
    117ac751b56e8820478c17c7701ed46a9291a642317d7dc5226712f14037442681  guix-build-a6a3cab235cf/output/dist-archive/bitcoin-a6a3cab235cf.tar.gz
    125bc0ce74d6baaed0b9a71edd2142c12c51af50e49e4a3e561ca574630c15c1f7  guix-build-a6a3cab235cf/output/powerpc64-linux-gnu/SHA256SUMS.part
    1308bee7dc7a9b3afe0e8cd277b9647056b39bec94e868265f935b41b2c8bdad54  guix-build-a6a3cab235cf/output/powerpc64-linux-gnu/bitcoin-a6a3cab235cf-powerpc64-linux-gnu-debug.tar.gz
    1429595c9dfe155009ffaf6e5d4701e52c6e735f6bb8dbe7f1a939604ea1c0d72d  guix-build-a6a3cab235cf/output/powerpc64-linux-gnu/bitcoin-a6a3cab235cf-powerpc64-linux-gnu.tar.gz
    159177685189978221038172865d0d7560ebee5f8a856908d7e955e2c4016fdffb  guix-build-a6a3cab235cf/output/riscv64-linux-gnu/SHA256SUMS.part
    1680ed63afed14e7183e11ae6d214288ded481853f1c25377986145a6aa9a8ea29  guix-build-a6a3cab235cf/output/riscv64-linux-gnu/bitcoin-a6a3cab235cf-riscv64-linux-gnu-debug.tar.gz
    17e3415ba90273004c8c0faf11cf96570b838d2b4aa04e5c3e2e74b85e1507bfc3  guix-build-a6a3cab235cf/output/riscv64-linux-gnu/bitcoin-a6a3cab235cf-riscv64-linux-gnu.tar.gz
    1807ae8d18a95806e8061aa9e29151c8c6f786a8c9e0ee2c8c3f91c88fafb54d65  guix-build-a6a3cab235cf/output/x86_64-apple-darwin/SHA256SUMS.part
    19f39dd6779d72b4054a6467c2c5cd88d7e9971604a851501c2a5d809b531a2f11  guix-build-a6a3cab235cf/output/x86_64-apple-darwin/bitcoin-a6a3cab235cf-x86_64-apple-darwin-unsigned.tar.gz
    20891e34c0d16b538d5817fc71e50746b0a09aa083f7edc5d3a744a668f582fb2a  guix-build-a6a3cab235cf/output/x86_64-apple-darwin/bitcoin-a6a3cab235cf-x86_64-apple-darwin-unsigned.zip
    21dab234ff1e2838a50a08b78d53a5542d535890603737cf41a7946709591aba74  guix-build-a6a3cab235cf/output/x86_64-apple-darwin/bitcoin-a6a3cab235cf-x86_64-apple-darwin.tar.gz
    221786396653240ff3cf1125f8c50ddf606135717514bf1a8a612de04483df5854  guix-build-a6a3cab235cf/output/x86_64-linux-gnu/SHA256SUMS.part
    23945a49f969ad8da9efbf86c2c5f228c4872eebff3dd494f9712c074eba2003dd  guix-build-a6a3cab235cf/output/x86_64-linux-gnu/bitcoin-a6a3cab235cf-x86_64-linux-gnu-debug.tar.gz
    24461c91b543a1590a492249c3f72f9317ece3c31545c04b8b5f6f184c1155c5f9  guix-build-a6a3cab235cf/output/x86_64-linux-gnu/bitcoin-a6a3cab235cf-x86_64-linux-gnu.tar.gz
    25a0f23a0bd73f6a8a101613296b7a0d60151fe5333904658c13f70d8ce611d663  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/SHA256SUMS.part
    2622e92eb5929864f666940ac3342b3eef5ee11b9b96adc45397f8c2708903e0a5  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64-debug.zip
    27df3e31e1c644fc027cc884171b2f4454a895b09917df89b02357c9a6e1da99b3  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64-setup-unsigned.exe
    2877b454372ccec46833b7be52c240a21b3e694cf05e7f6d23a37d95d12369e05f  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64-unsigned.tar.gz
    2905b1385a21d2c1b48cb80e9c97c0c221fca5e341dd4838f03f8abe4fdb7b7b0b  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64.zip
    
  15. fanquake commented at 2:57 pm on November 6, 2024: member

    Guix build:

     0c448a9c8d6d436350846ccb998e6a5e2bb66ac519e3539188c4792c6a88f4a1c  guix-build-a6a3cab235cf/output/aarch64-linux-gnu/SHA256SUMS.part
     1613ef63f92fdf0422179fdedad230a7b8c5eb1530c892745bd2d5e76e8fb580c  guix-build-a6a3cab235cf/output/aarch64-linux-gnu/bitcoin-a6a3cab235cf-aarch64-linux-gnu-debug.tar.gz
     22d77932ce9f8808f9673420320faaf9b20d910595f3d3d65687b5cbc55cb84dd  guix-build-a6a3cab235cf/output/aarch64-linux-gnu/bitcoin-a6a3cab235cf-aarch64-linux-gnu.tar.gz
     373019d4fb0f4e54828f70383c769d578112e85c028892ae9bcffa64e0a744a98  guix-build-a6a3cab235cf/output/arm-linux-gnueabihf/SHA256SUMS.part
     4cb1d13753ef47508cfd8b06c95668580c6c17cc64c852f05379eb0523fbfbf5e  guix-build-a6a3cab235cf/output/arm-linux-gnueabihf/bitcoin-a6a3cab235cf-arm-linux-gnueabihf-debug.tar.gz
     547d5a87c465dbfbf1ebc94ac45ad54b8ce12bced200ed8e9d1a3a0b9e10029d3  guix-build-a6a3cab235cf/output/arm-linux-gnueabihf/bitcoin-a6a3cab235cf-arm-linux-gnueabihf.tar.gz
     62bcd4e7933c0a2492714b336d1a71abfef159663e0be24df62513841bdd1e8dc  guix-build-a6a3cab235cf/output/arm64-apple-darwin/SHA256SUMS.part
     7c2ea0008a1eec8d321d9fe1d3444a1c94168e26925b4f9aeb602e781d2f277c4  guix-build-a6a3cab235cf/output/arm64-apple-darwin/bitcoin-a6a3cab235cf-arm64-apple-darwin-unsigned.tar.gz
     8296f22f2abd6b87aebe37957073adf6527e92349ef76c973a0015455cb645738  guix-build-a6a3cab235cf/output/arm64-apple-darwin/bitcoin-a6a3cab235cf-arm64-apple-darwin-unsigned.zip
     99c53fe999e9c8cb392273cec4052e6ba0e1a4d926058ffb1dfb2f79d96f9f61a  guix-build-a6a3cab235cf/output/arm64-apple-darwin/bitcoin-a6a3cab235cf-arm64-apple-darwin.tar.gz
    107ac751b56e8820478c17c7701ed46a9291a642317d7dc5226712f14037442681  guix-build-a6a3cab235cf/output/dist-archive/bitcoin-a6a3cab235cf.tar.gz
    115bc0ce74d6baaed0b9a71edd2142c12c51af50e49e4a3e561ca574630c15c1f7  guix-build-a6a3cab235cf/output/powerpc64-linux-gnu/SHA256SUMS.part
    1208bee7dc7a9b3afe0e8cd277b9647056b39bec94e868265f935b41b2c8bdad54  guix-build-a6a3cab235cf/output/powerpc64-linux-gnu/bitcoin-a6a3cab235cf-powerpc64-linux-gnu-debug.tar.gz
    1329595c9dfe155009ffaf6e5d4701e52c6e735f6bb8dbe7f1a939604ea1c0d72d  guix-build-a6a3cab235cf/output/powerpc64-linux-gnu/bitcoin-a6a3cab235cf-powerpc64-linux-gnu.tar.gz
    149177685189978221038172865d0d7560ebee5f8a856908d7e955e2c4016fdffb  guix-build-a6a3cab235cf/output/riscv64-linux-gnu/SHA256SUMS.part
    1580ed63afed14e7183e11ae6d214288ded481853f1c25377986145a6aa9a8ea29  guix-build-a6a3cab235cf/output/riscv64-linux-gnu/bitcoin-a6a3cab235cf-riscv64-linux-gnu-debug.tar.gz
    16e3415ba90273004c8c0faf11cf96570b838d2b4aa04e5c3e2e74b85e1507bfc3  guix-build-a6a3cab235cf/output/riscv64-linux-gnu/bitcoin-a6a3cab235cf-riscv64-linux-gnu.tar.gz
    1707ae8d18a95806e8061aa9e29151c8c6f786a8c9e0ee2c8c3f91c88fafb54d65  guix-build-a6a3cab235cf/output/x86_64-apple-darwin/SHA256SUMS.part
    18f39dd6779d72b4054a6467c2c5cd88d7e9971604a851501c2a5d809b531a2f11  guix-build-a6a3cab235cf/output/x86_64-apple-darwin/bitcoin-a6a3cab235cf-x86_64-apple-darwin-unsigned.tar.gz
    19891e34c0d16b538d5817fc71e50746b0a09aa083f7edc5d3a744a668f582fb2a  guix-build-a6a3cab235cf/output/x86_64-apple-darwin/bitcoin-a6a3cab235cf-x86_64-apple-darwin-unsigned.zip
    20dab234ff1e2838a50a08b78d53a5542d535890603737cf41a7946709591aba74  guix-build-a6a3cab235cf/output/x86_64-apple-darwin/bitcoin-a6a3cab235cf-x86_64-apple-darwin.tar.gz
    211786396653240ff3cf1125f8c50ddf606135717514bf1a8a612de04483df5854  guix-build-a6a3cab235cf/output/x86_64-linux-gnu/SHA256SUMS.part
    22945a49f969ad8da9efbf86c2c5f228c4872eebff3dd494f9712c074eba2003dd  guix-build-a6a3cab235cf/output/x86_64-linux-gnu/bitcoin-a6a3cab235cf-x86_64-linux-gnu-debug.tar.gz
    23461c91b543a1590a492249c3f72f9317ece3c31545c04b8b5f6f184c1155c5f9  guix-build-a6a3cab235cf/output/x86_64-linux-gnu/bitcoin-a6a3cab235cf-x86_64-linux-gnu.tar.gz
    24a0f23a0bd73f6a8a101613296b7a0d60151fe5333904658c13f70d8ce611d663  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/SHA256SUMS.part
    2522e92eb5929864f666940ac3342b3eef5ee11b9b96adc45397f8c2708903e0a5  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64-debug.zip
    26df3e31e1c644fc027cc884171b2f4454a895b09917df89b02357c9a6e1da99b3  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64-setup-unsigned.exe
    2777b454372ccec46833b7be52c240a21b3e694cf05e7f6d23a37d95d12369e05f  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64-unsigned.tar.gz
    2805b1385a21d2c1b48cb80e9c97c0c221fca5e341dd4838f03f8abe4fdb7b7b0b  guix-build-a6a3cab235cf/output/x86_64-w64-mingw32/bitcoin-a6a3cab235cf-win64.zip
    
  16. fanquake commented at 3:36 pm on November 6, 2024: member

    Tested on Arch, which is one of the few distros that ship CMake config files for libevent-dev. You could add this diff:

     0diff --git a/doc/build-unix.md b/doc/build-unix.md
     1index a5ad4df11d..4f04b4fd9f 100644
     2--- a/doc/build-unix.md
     3+++ b/doc/build-unix.md
     4@@ -182,7 +182,7 @@ Setup and Build Example: Arch Linux
     5 -----------------------------------
     6 This example lists the steps necessary to setup and build a command line only distribution of the latest changes on Arch Linux:
     7 
     8-    pacman --sync --needed cmake boost gcc git libevent make pkgconf python sqlite
     9+    pacman --sync --needed cmake boost gcc git libevent make python sqlite
    10     git clone https://github.com/bitcoin/bitcoin.git
    11     cd bitcoin/
    12     cmake -B build
    
  17. cmake: Revamp `FindLibevent` module
    This change generalizes the use of `find_package` / `pkg_check_modules`,
    prioritizing the former.
    b619bdc330
  18. cmake, refactor: Move `HAVE_EVHTTP_...` to `libevent` interface ffda355b5a
  19. depends, libevent: Do not install *.pc files and remove patches for them 5a96767e3f
  20. hebasto force-pushed on Nov 6, 2024
  21. hebasto commented at 3:41 pm on November 6, 2024: member

    Tested on Arch, which is one of the few distros that ship CMake config files for libevent-dev. You could add this diff:

     0diff --git a/doc/build-unix.md b/doc/build-unix.md
     1index a5ad4df11d..4f04b4fd9f 100644
     2--- a/doc/build-unix.md
     3+++ b/doc/build-unix.md
     4@@ -182,7 +182,7 @@ Setup and Build Example: Arch Linux
     5 -----------------------------------
     6 This example lists the steps necessary to setup and build a command line only distribution of the latest changes on Arch Linux:
     7 
     8-    pacman --sync --needed cmake boost gcc git libevent make pkgconf python sqlite
     9+    pacman --sync --needed cmake boost gcc git libevent make python sqlite
    10     git clone https://github.com/bitcoin/bitcoin.git
    11     cd bitcoin/
    12     cmake -B build
    

    Thanks! Updated.

  22. fanquake requested review from theuni on Nov 6, 2024
  23. hebasto commented at 4:55 pm on November 6, 2024: member

    My Guix build:

     0aarch64
     1b526b46943f39780cb2a204cd64159f7dd4f502e482256ba78371c82d717a591  guix-build-5a96767e3f53/output/aarch64-linux-gnu/SHA256SUMS.part
     277714a2034b96c572598342da2147a638abd626b29e4ccecfe786f53dbf72a4e  guix-build-5a96767e3f53/output/aarch64-linux-gnu/bitcoin-5a96767e3f53-aarch64-linux-gnu-debug.tar.gz
     3a32ce8d85863ec00f75b37ab7b10bfc37e85efd3a1016ed66ce6cbd0024d018a  guix-build-5a96767e3f53/output/aarch64-linux-gnu/bitcoin-5a96767e3f53-aarch64-linux-gnu.tar.gz
     4751eba9ba4c9c2432018854a9064bcc24a7cde4236247da7ecf0c09d6ad4d998  guix-build-5a96767e3f53/output/arm-linux-gnueabihf/SHA256SUMS.part
     5e5c5d79fe4da7183009207e4c229a0da6d10da8b293c7309ff45b99b2d18dd78  guix-build-5a96767e3f53/output/arm-linux-gnueabihf/bitcoin-5a96767e3f53-arm-linux-gnueabihf-debug.tar.gz
     6258f63b89ef5cb5f425fd3c1e979e355608ab40272304fd04314acdf1f07397d  guix-build-5a96767e3f53/output/arm-linux-gnueabihf/bitcoin-5a96767e3f53-arm-linux-gnueabihf.tar.gz
     76b79c89ce6e36cc46db4a50e1635e42751e2323227ae3b0b2f4012ce8fa40489  guix-build-5a96767e3f53/output/arm64-apple-darwin/SHA256SUMS.part
     8e8bd0927f1986eda76ff8da3ac966b8df5a847936fe15f6fe1ad2565ccf81de7  guix-build-5a96767e3f53/output/arm64-apple-darwin/bitcoin-5a96767e3f53-arm64-apple-darwin-unsigned.tar.gz
     96705d70f0318d146aa4e264dd561eda53166d6ebacc60602f96a02549b0f8971  guix-build-5a96767e3f53/output/arm64-apple-darwin/bitcoin-5a96767e3f53-arm64-apple-darwin-unsigned.zip
    10a5feee710b316d2f2f6b43bfd55d4712d3513e5f56dd80d823b63fb90e74e52f  guix-build-5a96767e3f53/output/arm64-apple-darwin/bitcoin-5a96767e3f53-arm64-apple-darwin.tar.gz
    11e2d8c8b6f14bc44086cc6e152d80dd7fe9af4f501038dcffefded43f60c0c78b  guix-build-5a96767e3f53/output/dist-archive/bitcoin-5a96767e3f53.tar.gz
    123e87fe8a89bd6ed809ca4ab77308999f84a3eb4cc4aa97a3de67925e93f193de  guix-build-5a96767e3f53/output/powerpc64-linux-gnu/SHA256SUMS.part
    135de169c0431a5dd1efab9ea88dd5fc87c5f985adf1a87c796e6eaa154d241fdb  guix-build-5a96767e3f53/output/powerpc64-linux-gnu/bitcoin-5a96767e3f53-powerpc64-linux-gnu-debug.tar.gz
    1478333296ce7fc88882a71b1a2b03d8544ee9413516f322aa685e2e3c9c47abbe  guix-build-5a96767e3f53/output/powerpc64-linux-gnu/bitcoin-5a96767e3f53-powerpc64-linux-gnu.tar.gz
    1502e5ec367182a54814509f2c640cb8951341b63a7a510e2fe12f3c98f5829f8e  guix-build-5a96767e3f53/output/riscv64-linux-gnu/SHA256SUMS.part
    16239329403da2775bb5b3b8b73bd1fa9613a19852b30801e819cb39e5700ce495  guix-build-5a96767e3f53/output/riscv64-linux-gnu/bitcoin-5a96767e3f53-riscv64-linux-gnu-debug.tar.gz
    177d9bf2f6c19455bfe8a94770ad10d71d73cabe3833e511b84e4da2b2bec9fa4d  guix-build-5a96767e3f53/output/riscv64-linux-gnu/bitcoin-5a96767e3f53-riscv64-linux-gnu.tar.gz
    18ba16d9bbbbafe29f39d8b733fe090725c24ae8a095a6454bfaaea8be2103025d  guix-build-5a96767e3f53/output/x86_64-apple-darwin/SHA256SUMS.part
    19a8907b52a882730062f2312e349c52e399215b76c6cff231ad550214ae52b807  guix-build-5a96767e3f53/output/x86_64-apple-darwin/bitcoin-5a96767e3f53-x86_64-apple-darwin-unsigned.tar.gz
    20e963cd3623bee1e79e7de260cc5347d203926a5a7da51dab97650ef8f3597f49  guix-build-5a96767e3f53/output/x86_64-apple-darwin/bitcoin-5a96767e3f53-x86_64-apple-darwin-unsigned.zip
    216e6194b28563fb4bfa2840265ee783e282684df08b773919d4b78cd88e37ce78  guix-build-5a96767e3f53/output/x86_64-apple-darwin/bitcoin-5a96767e3f53-x86_64-apple-darwin.tar.gz
    22f84f236918aaae68c7a036bfcc4cd6e643b449ace6812f8fcb2ad3e6aa60fd89  guix-build-5a96767e3f53/output/x86_64-linux-gnu/SHA256SUMS.part
    23a35b69c56c97b8aa308a2893471712200646ec4b0d469828506059668044e05d  guix-build-5a96767e3f53/output/x86_64-linux-gnu/bitcoin-5a96767e3f53-x86_64-linux-gnu-debug.tar.gz
    24d8daf3cb7bf4e6a18e1312bedc0383b5a1676c16c723330f187c1cf2cccdf4e1  guix-build-5a96767e3f53/output/x86_64-linux-gnu/bitcoin-5a96767e3f53-x86_64-linux-gnu.tar.gz
    254b7790e70a57d5d9c8dd167ebde956be0e8fd8819ff3374866869619fad5deea  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/SHA256SUMS.part
    261c051bbe9f6958f2cd91cb20e47fc0778a8e3877f034fd97b37b6a78f22b64ea  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64-debug.zip
    27b00ef4ad4fcad2da810b7900834256d8b56a575705f6a5ee5e124075ee9ce3ec  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64-setup-unsigned.exe
    287f6bb43d931a8a62a5cfdd3d7a55b46bace525441e973563dacc71c34fc0aa10  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64-unsigned.tar.gz
    29122fb77cbc223ca67bfecdeef3709dbac291e1df0bbf082d87d94777292d9399  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64.zip
    
  24. fanquake commented at 2:57 pm on November 11, 2024: member

    Guix Build

     0b526b46943f39780cb2a204cd64159f7dd4f502e482256ba78371c82d717a591  guix-build-5a96767e3f53/output/aarch64-linux-gnu/SHA256SUMS.part
     177714a2034b96c572598342da2147a638abd626b29e4ccecfe786f53dbf72a4e  guix-build-5a96767e3f53/output/aarch64-linux-gnu/bitcoin-5a96767e3f53-aarch64-linux-gnu-debug.tar.gz
     2a32ce8d85863ec00f75b37ab7b10bfc37e85efd3a1016ed66ce6cbd0024d018a  guix-build-5a96767e3f53/output/aarch64-linux-gnu/bitcoin-5a96767e3f53-aarch64-linux-gnu.tar.gz
     3751eba9ba4c9c2432018854a9064bcc24a7cde4236247da7ecf0c09d6ad4d998  guix-build-5a96767e3f53/output/arm-linux-gnueabihf/SHA256SUMS.part
     4e5c5d79fe4da7183009207e4c229a0da6d10da8b293c7309ff45b99b2d18dd78  guix-build-5a96767e3f53/output/arm-linux-gnueabihf/bitcoin-5a96767e3f53-arm-linux-gnueabihf-debug.tar.gz
     5258f63b89ef5cb5f425fd3c1e979e355608ab40272304fd04314acdf1f07397d  guix-build-5a96767e3f53/output/arm-linux-gnueabihf/bitcoin-5a96767e3f53-arm-linux-gnueabihf.tar.gz
     66b79c89ce6e36cc46db4a50e1635e42751e2323227ae3b0b2f4012ce8fa40489  guix-build-5a96767e3f53/output/arm64-apple-darwin/SHA256SUMS.part
     7e8bd0927f1986eda76ff8da3ac966b8df5a847936fe15f6fe1ad2565ccf81de7  guix-build-5a96767e3f53/output/arm64-apple-darwin/bitcoin-5a96767e3f53-arm64-apple-darwin-unsigned.tar.gz
     86705d70f0318d146aa4e264dd561eda53166d6ebacc60602f96a02549b0f8971  guix-build-5a96767e3f53/output/arm64-apple-darwin/bitcoin-5a96767e3f53-arm64-apple-darwin-unsigned.zip
     9a5feee710b316d2f2f6b43bfd55d4712d3513e5f56dd80d823b63fb90e74e52f  guix-build-5a96767e3f53/output/arm64-apple-darwin/bitcoin-5a96767e3f53-arm64-apple-darwin.tar.gz
    10e2d8c8b6f14bc44086cc6e152d80dd7fe9af4f501038dcffefded43f60c0c78b  guix-build-5a96767e3f53/output/dist-archive/bitcoin-5a96767e3f53.tar.gz
    113e87fe8a89bd6ed809ca4ab77308999f84a3eb4cc4aa97a3de67925e93f193de  guix-build-5a96767e3f53/output/powerpc64-linux-gnu/SHA256SUMS.part
    125de169c0431a5dd1efab9ea88dd5fc87c5f985adf1a87c796e6eaa154d241fdb  guix-build-5a96767e3f53/output/powerpc64-linux-gnu/bitcoin-5a96767e3f53-powerpc64-linux-gnu-debug.tar.gz
    1378333296ce7fc88882a71b1a2b03d8544ee9413516f322aa685e2e3c9c47abbe  guix-build-5a96767e3f53/output/powerpc64-linux-gnu/bitcoin-5a96767e3f53-powerpc64-linux-gnu.tar.gz
    1402e5ec367182a54814509f2c640cb8951341b63a7a510e2fe12f3c98f5829f8e  guix-build-5a96767e3f53/output/riscv64-linux-gnu/SHA256SUMS.part
    15239329403da2775bb5b3b8b73bd1fa9613a19852b30801e819cb39e5700ce495  guix-build-5a96767e3f53/output/riscv64-linux-gnu/bitcoin-5a96767e3f53-riscv64-linux-gnu-debug.tar.gz
    167d9bf2f6c19455bfe8a94770ad10d71d73cabe3833e511b84e4da2b2bec9fa4d  guix-build-5a96767e3f53/output/riscv64-linux-gnu/bitcoin-5a96767e3f53-riscv64-linux-gnu.tar.gz
    17ba16d9bbbbafe29f39d8b733fe090725c24ae8a095a6454bfaaea8be2103025d  guix-build-5a96767e3f53/output/x86_64-apple-darwin/SHA256SUMS.part
    18a8907b52a882730062f2312e349c52e399215b76c6cff231ad550214ae52b807  guix-build-5a96767e3f53/output/x86_64-apple-darwin/bitcoin-5a96767e3f53-x86_64-apple-darwin-unsigned.tar.gz
    19e963cd3623bee1e79e7de260cc5347d203926a5a7da51dab97650ef8f3597f49  guix-build-5a96767e3f53/output/x86_64-apple-darwin/bitcoin-5a96767e3f53-x86_64-apple-darwin-unsigned.zip
    206e6194b28563fb4bfa2840265ee783e282684df08b773919d4b78cd88e37ce78  guix-build-5a96767e3f53/output/x86_64-apple-darwin/bitcoin-5a96767e3f53-x86_64-apple-darwin.tar.gz
    21f84f236918aaae68c7a036bfcc4cd6e643b449ace6812f8fcb2ad3e6aa60fd89  guix-build-5a96767e3f53/output/x86_64-linux-gnu/SHA256SUMS.part
    22a35b69c56c97b8aa308a2893471712200646ec4b0d469828506059668044e05d  guix-build-5a96767e3f53/output/x86_64-linux-gnu/bitcoin-5a96767e3f53-x86_64-linux-gnu-debug.tar.gz
    23d8daf3cb7bf4e6a18e1312bedc0383b5a1676c16c723330f187c1cf2cccdf4e1  guix-build-5a96767e3f53/output/x86_64-linux-gnu/bitcoin-5a96767e3f53-x86_64-linux-gnu.tar.gz
    244b7790e70a57d5d9c8dd167ebde956be0e8fd8819ff3374866869619fad5deea  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/SHA256SUMS.part
    251c051bbe9f6958f2cd91cb20e47fc0778a8e3877f034fd97b37b6a78f22b64ea  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64-debug.zip
    26b00ef4ad4fcad2da810b7900834256d8b56a575705f6a5ee5e124075ee9ce3ec  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64-setup-unsigned.exe
    277f6bb43d931a8a62a5cfdd3d7a55b46bace525441e973563dacc71c34fc0aa10  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64-unsigned.tar.gz
    28122fb77cbc223ca67bfecdeef3709dbac291e1df0bbf082d87d94777292d9399  guix-build-5a96767e3f53/output/x86_64-w64-mingw32/bitcoin-5a96767e3f53-win64.zip
    
  25. fanquake approved
  26. fanquake commented at 3:05 pm on November 11, 2024: member
    ACK 5a96767e3f531ba9e8a676eec47727421f9f589f
  27. DrahtBot requested review from laanwj on Nov 11, 2024
  28. fanquake merged this on Nov 11, 2024
  29. fanquake closed this on Nov 11, 2024

  30. fanquake referenced this in commit c64ab1b155 on Nov 12, 2024
  31. TheCharlatan referenced this in commit a73b2bd0f0 on Nov 14, 2024
  32. hebasto deleted the branch on Nov 16, 2024


hebasto DrahtBot fanquake laanwj


laanwj theuni

Labels
Build system

Milestone
29.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me