We should also follow up with refactoring the libevent module, to more generically use CMake/pkg-config, rather than restricting the CMake usage to vcpkg. At that point, we’d likely be able to dump pkg-config for the depends path entirely.
Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
DrahtBot added the label
CI failed
on Oct 30, 2024
DrahtBot removed the label
CI failed
on Oct 30, 2024
fanquake
commented at 10:51 am on October 30, 2024:
member
Concept ACK - we don’t have to restrict CMake usage to vcpkg, and this will let us make more cleanups.
laanwj
commented at 11:50 am on October 30, 2024:
member
Concept ACK
fanquake added this to the milestone 29.0
on Nov 2, 2024
fanquake
commented at 12:12 pm on November 6, 2024:
member
Can you rebase this.
hebasto force-pushed
on Nov 6, 2024
hebasto
commented at 12:50 pm on November 6, 2024:
member
Can you rebase this.
Sure. Rebased.
hebasto
commented at 2:08 pm on November 6, 2024:
member
fanquake
commented at 3:36 pm on November 6, 2024:
member
Tested on Arch, which is one of the few distros that ship CMake config files for libevent-dev. You could add this diff:
0diff --git a/doc/build-unix.md b/doc/build-unix.md
1index a5ad4df11d..4f04b4fd9f 100644
2--- a/doc/build-unix.md
3+++ b/doc/build-unix.md
4@@ -182,7 +182,7 @@ Setup and Build Example: Arch Linux
5 -----------------------------------
6 This example lists the steps necessary to setup and build a command line only distribution of the latest changes on Arch Linux:
7 8- pacman --sync --needed cmake boost gcc git libevent make pkgconf python sqlite
9+ pacman --sync --needed cmake boost gcc git libevent make python sqlite
10 git clone https://github.com/bitcoin/bitcoin.git
11 cd bitcoin/
12 cmake -B build
cmake: Revamp `FindLibevent` module
This change generalizes the use of `find_package` / `pkg_check_modules`,
prioritizing the former.
b619bdc330
cmake, refactor: Move `HAVE_EVHTTP_...` to `libevent` interfaceffda355b5a
depends, libevent: Do not install *.pc files and remove patches for them5a96767e3f
hebasto force-pushed
on Nov 6, 2024
hebasto
commented at 3:41 pm on November 6, 2024:
member
Tested on Arch, which is one of the few distros that ship CMake config files for libevent-dev. You could add this diff:
0diff --git a/doc/build-unix.md b/doc/build-unix.md
1index a5ad4df11d..4f04b4fd9f 100644
2--- a/doc/build-unix.md
3+++ b/doc/build-unix.md
4@@ -182,7 +182,7 @@ Setup and Build Example: Arch Linux
5 -----------------------------------
6 This example lists the steps necessary to setup and build a command line only distribution of the latest changes on Arch Linux:
7 8- pacman --sync --needed cmake boost gcc git libevent make pkgconf python sqlite
9+ pacman --sync --needed cmake boost gcc git libevent make python sqlite
10 git clone https://github.com/bitcoin/bitcoin.git
11 cd bitcoin/
12 cmake -B build
Thanks! Updated.
fanquake requested review from theuni
on Nov 6, 2024
hebasto
commented at 4:55 pm on November 6, 2024:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-12-21 15:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me