Revert “Introduce g_fuzzing global for fuzzing checks” #31189

1. 
   dergoegge commented at 12:08 pm on October 31, 2024: member

   Assume’s should not be compiled in for production builds. #31093 broke that property of Assume.

   Closes #31178

2. Revert "Introduce `g_fuzzing` global for fuzzing checks"

   This reverts commit 9f243cd7fa6654e3b71ba6bff82cceed547c5d53.

   4d9a1c501a
3. 
   DrahtBot commented at 12:08 pm on October 31, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. 
   dergoegge commented at 12:09 pm on October 31, 2024: member

   CI will fail and we’ll probably need to reconsider #31057 and #31073
5. 
   maflcko commented at 12:17 pm on October 31, 2024: member

   It would be good to make it constexpr instead #31178 (comment) and use that to fix the issues. Happy to do it myself, but I think it should be part of one pull request. Otherwise you’ll just switch one issue for another and a follow-up has to be created anyway.
6. 
   dergoegge commented at 12:21 pm on October 31, 2024: member

   I don’t think the approach described in #31178 (comment) would fix the ci issues? If we make it a compile time option we’ll see the timeouts in p2p_headers_presync for the macos and windows CI either way.
7. 
   maflcko commented at 12:26 pm on October 31, 2024: member

   Yeah, I am saying that the fix should be a complete one, at least when it comes to the ./src directory. Otherwise it will have to be touched again. I am happy to submit a pull, or review one. But I think there have been enough issue and pull request threads about this topic and it would be good to wrap it up in at most one or two pulls.
8. 
   dergoegge commented at 12:28 pm on October 31, 2024: member

   I am happy to submit a pull

   Yes please

9. dergoegge closed this on Oct 31, 2024

   ---

Contributors
dergoegge DrahtBot maflcko