Assume's should not be compiled in for production builds. #31093 broke that property of Assume.
Closes #31178
This reverts commit 9f243cd7fa6654e3b71ba6bff82cceed547c5d53.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process. A summary of reviews will appear here.
It would be good to make it constexpr instead #31178 (comment) and use that to fix the issues. Happy to do it myself, but I think it should be part of one pull request. Otherwise you'll just switch one issue for another and a follow-up has to be created anyway.
I don't think the approach described in #31178 (comment) would fix the ci issues? If we make it a compile time option we'll see the timeouts in p2p_headers_presync for the macos and windows CI either way.
Yeah, I am saying that the fix should be a complete one, at least when it comes to the ./src directory. Otherwise it will have to be touched again. I am happy to submit a pull, or review one. But I think there have been enough issue and pull request threads about this topic and it would be good to wrap it up in at most one or two pulls.
I am happy to submit a pull
Yes please