Update secp256k1 subtree to v0.6.0

achow101 commented at 8:02 pm on November 4, 2024: member

v0.6.0 was just released, main change is that it has the musig module which #29675 needs.

Squashed 'src/secp256k1/' changes from 2f2ccc46954..0cdc758a563

0cdc758a563 Merge bitcoin-core/secp256k1#1631: release: prepare for 0.6.0
39d5dfd542a release: prepare for 0.6.0
df2eceb2790 build: add ellswift.md and musig.md to release tarball
a306bb7e903 tools: fix check-abi.sh after cmake out locations were changed
145868a84d2 Do not export `secp256k1_musig_nonce_gen_internal`
b161bffb8bf Merge bitcoin-core/secp256k1#1579: Clear sensitive memory without getting optimized out (revival of #636)
a38d879a1a6 Merge bitcoin-core/secp256k1#1628: Name public API structs
7d48f5ed02e Merge bitcoin-core/secp256k1#1581: test, ci: Lower default iteration count to 16
694342fdb71 Name public API structs
0f73caf7c62 test, ci: Lower default iteration count to 16
9a8db52f4e9 Merge bitcoin-core/secp256k1#1582: cmake, test: Add `secp256k1_` prefix to test names
765ef53335a Clear _gej instances after point multiplication to avoid potential leaks
349e6ab916b Introduce separate _clear functions for hash module
99cc9fd6d01 Don't rely on memset to set signed integers to 0
97c57f42ba8 Implement various _clear() functions with secp256k1_memclear()
9bb368d1466 Use secp256k1_memclear() to clear stack memory instead of memset()
e3497bbf001 Separate between clearing memory and setting to zero in tests
d79a6ccd43a Separate secp256k1_fe_set_int( . , 0 ) from secp256k1_fe_clear()
1c081262227 Add secp256k1_memclear() for clearing secret data
1464f15c812 Merge bitcoin-core/secp256k1#1625: util: Remove unused (u)int64_t formatting macros
980c08df80a util: Remove unused (u)int64_t formatting macros
9b7c59cbb90 Merge bitcoin-core/secp256k1#1624: ci: Update macOS image
096e3e23f63 ci: Update macOS image
e7d384488e8 Don't clear secrets in pippenger implementation
68b55209f1b Merge bitcoin-core/secp256k1#1619: musig: ctimetests: fix _declassify range for generated nonce points
f0868a9b3d8 Merge bitcoin-core/secp256k1#1595: build: 45839th attempt to fix symbol visibility on Windows
1fae76f50c0 Merge bitcoin-core/secp256k1#1620: Remove unused scratch space from API
8be3839fb2e Remove unused scratch space from API
57eda3ba300 musig: ctimetests: fix _declassify range for generated nonce points
87384f5c0f2 cmake, test: Add `secp256k1_` prefix to test names
e59158b6eb7 Merge bitcoin-core/secp256k1#1553: cmake: Set top-level target output locations
18f9b967c25 Merge bitcoin-core/secp256k1#1616: examples: do not retry generating seckey randomness in musig
5bab8f6d3c4 examples: make key generation doc consistent
e8908221a45 examples: do not retry generating seckey randomness in musig
70b6be1834e extrakeys: improve doc of keypair_create (don't suggest retry)
01b5893389e Merge bitcoin-core/secp256k1#1599: #1570 improve examples: remove key generation loop
cd4f84f3ba8 Improve examples/documentation: remove key generation loops
a88aa935063 Merge bitcoin-core/secp256k1#1603: f can never equal -m
3660fe5e2a9 Merge bitcoin-core/secp256k1#1479: Add module "musig" that implements MuSig2 multi-signatures (BIP 327)
168c92011f5 build: allow enabling the musig module in cmake
f411841a46b Add module "musig" that implements MuSig2 multi-signatures (BIP 327)
0be79660f38 util: add constant-time is_zero_array function
c8fbdb1b972 group: add ge_to_bytes_ext and ge_from_bytes_ext
ef7ff03407f f can never equal -m
c232486d84e Revert "cmake: Set `ENVIRONMENT` property for examples on Windows"
26e4a7c2146 cmake: Set top-level target output locations
4c57c7a5a95 Merge bitcoin-core/secp256k1#1554: cmake: Clean up testing code
447334cb06d include: Avoid visibility("default") on Windows
472faaa8ee6 Merge bitcoin-core/secp256k1#1604: doc: fix typos in `secp256k1_ecdsa_{recoverable_,}signature` API description
292310fbb24 doc: fix typos in `secp256k1_ecdsa_{recoverable_,}signature` API description
85e224dd97f group: add ge_to_bytes and ge_from_bytes
7c987ec89e6 cmake: Call `enable_testing()` unconditionally
6aa576515ef cmake: Delete `CTest` module

git-subtree-dir: src/secp256k1
git-subtree-split: 0cdc758a56360bf58a851fe91085a327ec97685a

2d46a89386

Update secp256k1 subtree to v0.6.0 0ba680d41b

DrahtBot commented at 8:02 pm on November 4, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31216.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, laanwj

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

maflcko added the label DrahtBot Guix build requested on Nov 5, 2024

hebasto commented at 10:54 am on November 5, 2024: member

v0.6.0 was just released, main change is that it has the musig module which #29675 needs.

Should we disable the musig module in this PR and enable it only when it is needed?

sipa commented at 1:32 pm on November 5, 2024: member

Another included benefit is that the default test iteration count for the secp256k1 tests binary has been reduced, which means Bitcoin Core’s ctest run should speed up (the tests binary is the single longest running task currently); see https://github.com/bitcoin-core/secp256k1/pull/1581.

hebasto commented at 2:13 pm on November 5, 2024: member

Another included benefit is that the default test iteration count for the secp256k1 tests binary has been reduced, which means Bitcoin Core’s ctest run should speed up (the tests binary is the single longest running task currently); see bitcoin-core/secp256k1#1581.

Additionally, the subtree tests can now match ctest regex options, such as -E or -R:

0$ ctest --test-dir build -j 16 -R secp256k1

build: Disable secp256k1 musig module

The musig module is currently unused so disable it.

97235c446e

achow101 commented at 8:09 pm on November 5, 2024: member

Should we disable the musig module in this PR and enable it only when it is needed?

Done

hebasto approved

hebasto commented at 8:30 pm on November 5, 2024: member

ACK 97235c446e9986ecca09c2a4b78d6c6239853fdb, verified by updating the secp256k1 subtree locally.

laanwj approved

laanwj commented at 11:06 am on November 6, 2024: member

ACK 97235c446e9986ecca09c2a4b78d6c6239853fdb good to have the secp256k1_memclear commits

fanquake commented at 11:08 am on November 6, 2024: member

Guix Build:

 0df8b274bbadabebfc2ec3d28591f6f66a983f2500779fb95016aaef8c728ad8d  guix-build-97235c446e99/output/aarch64-linux-gnu/SHA256SUMS.part
 126aeeb60bf02b1d6e1c072a5c42a3ec14165f208efb5f17992f1716c2db7b826  guix-build-97235c446e99/output/aarch64-linux-gnu/bitcoin-97235c446e99-aarch64-linux-gnu-debug.tar.gz
 2043e16b13eed1ff5b3a1c4ce67309d595fffbdbbd0cd6800221a9eabb84a35eb  guix-build-97235c446e99/output/aarch64-linux-gnu/bitcoin-97235c446e99-aarch64-linux-gnu.tar.gz
 33f2b606211c543d8e5639bfdb9cba817bc05aa7dcf5d1a2efe42736c54325a81  guix-build-97235c446e99/output/arm-linux-gnueabihf/SHA256SUMS.part
 4c869e44c1341e300e6c8f1f0b24ecb1a6961b15b7df18eeb063d216e64cccfde  guix-build-97235c446e99/output/arm-linux-gnueabihf/bitcoin-97235c446e99-arm-linux-gnueabihf-debug.tar.gz
 512086906b844d777c0b41e6a1ebc13708bb88b4d624bdc7016d78b92a72c40fa  guix-build-97235c446e99/output/arm-linux-gnueabihf/bitcoin-97235c446e99-arm-linux-gnueabihf.tar.gz
 6028cdc0410919855767f3719f6765c1de3c3e070fca06031979e192e67608ef4  guix-build-97235c446e99/output/arm64-apple-darwin/SHA256SUMS.part
 79b6794e45c8059b31031aed8a46ca5cb6b69bba7a8f52a061da5dac6f44e17c9  guix-build-97235c446e99/output/arm64-apple-darwin/bitcoin-97235c446e99-arm64-apple-darwin-unsigned.tar.gz
 88f81e7782059c51bba90f2315042ebb11db47fc8593fc87a0a69891bad3117c9  guix-build-97235c446e99/output/arm64-apple-darwin/bitcoin-97235c446e99-arm64-apple-darwin-unsigned.zip
 95b44e06b28f9b74a95af6c3f5b84611be71a89dfe96b13ba828c777950da01bc  guix-build-97235c446e99/output/arm64-apple-darwin/bitcoin-97235c446e99-arm64-apple-darwin.tar.gz
1090a64bd370ab497dd7df62054f35df418a29b4f3da1eefee812371a32a93c8ca  guix-build-97235c446e99/output/dist-archive/bitcoin-97235c446e99.tar.gz
1108c71713cdcbdc7a4f555ff2c9ac5ffc8d8502a94a91c1a2ace840032f16b238  guix-build-97235c446e99/output/powerpc64-linux-gnu/SHA256SUMS.part
126b60a37a7fe2374463d98ada79e5995e0b0b49f39c5674b33bdd54519aa85dab  guix-build-97235c446e99/output/powerpc64-linux-gnu/bitcoin-97235c446e99-powerpc64-linux-gnu-debug.tar.gz
13ad07922d16815e795513c530c61c98a639252dc1a9fb167a24a5ea474a29c6c2  guix-build-97235c446e99/output/powerpc64-linux-gnu/bitcoin-97235c446e99-powerpc64-linux-gnu.tar.gz
14a33458431a23769fb5a256700d4a7a8b28e250c9ee0b1084e911e2ffdfdc7c03  guix-build-97235c446e99/output/riscv64-linux-gnu/SHA256SUMS.part
15c3eb0152e2e4ff672e18b218735c6108b6cf5534dccde7fc6f449d62ccd528e8  guix-build-97235c446e99/output/riscv64-linux-gnu/bitcoin-97235c446e99-riscv64-linux-gnu-debug.tar.gz
162f857cf68d0911a736634336d0b95a785effad143c9b13c2996fd45a42de9037  guix-build-97235c446e99/output/riscv64-linux-gnu/bitcoin-97235c446e99-riscv64-linux-gnu.tar.gz
1792abee9de44018885f083f3c0160f31a1b243e7dc681a8012436107796f978b8  guix-build-97235c446e99/output/x86_64-apple-darwin/SHA256SUMS.part
18b234bde1f0cbd12c150b5d6a0e8b8f4e20e10fd3df5ea7b1bd352182dd9bb1bb  guix-build-97235c446e99/output/x86_64-apple-darwin/bitcoin-97235c446e99-x86_64-apple-darwin-unsigned.tar.gz
19135da97d62b6a3de0fea0487b7c636d3c893d3b4d7c79ef8fa0f9cfc345d9841  guix-build-97235c446e99/output/x86_64-apple-darwin/bitcoin-97235c446e99-x86_64-apple-darwin-unsigned.zip
20d4edd28b01ce906428305dcb533c0df1176a8c39f4654003340a7d6635cedee1  guix-build-97235c446e99/output/x86_64-apple-darwin/bitcoin-97235c446e99-x86_64-apple-darwin.tar.gz
21095fa14e84931c98682f0a87a13c554deff943d947b6eee411326a843dea9e3a  guix-build-97235c446e99/output/x86_64-linux-gnu/SHA256SUMS.part
226fe94b66164c88f6ade3295944ef51150dfe1c00d58499f5cd2a7c1112a57a09  guix-build-97235c446e99/output/x86_64-linux-gnu/bitcoin-97235c446e99-x86_64-linux-gnu-debug.tar.gz
23e417cab3b7cc210137135ebbac66de859019db805f19d0f417b7c9f751967e3a  guix-build-97235c446e99/output/x86_64-linux-gnu/bitcoin-97235c446e99-x86_64-linux-gnu.tar.gz
245efc23bfc17c69bfddacf42fc08a4ce88e41f5cc7c53d83840d0b22b6c6e2249  guix-build-97235c446e99/output/x86_64-w64-mingw32/SHA256SUMS.part
251b9809ff08e1cfa42587a39299a0d57f39b4af4b5177c624ef079f32640d003f  guix-build-97235c446e99/output/x86_64-w64-mingw32/bitcoin-97235c446e99-win64-debug.zip
261b04b7c1548ea26531d79b1855d186d550c699702543dffe8ec9a2db8c62260c  guix-build-97235c446e99/output/x86_64-w64-mingw32/bitcoin-97235c446e99-win64-setup-unsigned.exe
27769fa743cc56fa9966b6b01b069afb134e451b22ef24fd2c39101bb4b369d5a4  guix-build-97235c446e99/output/x86_64-w64-mingw32/bitcoin-97235c446e99-win64-unsigned.tar.gz
280267008bd2c22ed8bbfb52a889152e96136897c3b5c25827f2f95d96c04c44e1  guix-build-97235c446e99/output/x86_64-w64-mingw32/bitcoin-97235c446e99-win64.zip

fanquake merged this on Nov 6, 2024

fanquake closed this on Nov 6, 2024

maflcko removed the label DrahtBot Guix build requested on Nov 6, 2024

Update secp256k1 subtree to v0.6.0 #31216

Code Coverage & Benchmarks

Reviews