ci: add second_deadlock_stack=1 to TSAN options #31232

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:tsan_second_deadlock_stack changing 1 files +1 −1
  1. fanquake commented at 11:15 am on November 6, 2024: member

    This is mentioned in the developer notes, but isn’t present in TSAN_OPTIONS, resulting in:

    0WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=60508)
    1  Cycle in lock order graph: M0 (0xffff98e02208) => M1 (0xffff98e0cbe8) => M2 (0xffff98e0cd98) => M0
    2<snip>
    3
    4  Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative warning message
    

    Add it, for (potentially) more informative output, when failures occur. Checked that adding does output more information.

  2. ci: add second_deadlock_stack=1 to TSAN options
    This is mentioned in the developer notes, but isn't present in
    `TSAN_OPTIONS`, resulting in:
    ```bash
    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=60508)
      Cycle in lock order graph: M0 (0xffff98e02208) => M1 (0xffff98e0cbe8) => M2 (0xffff98e0cd98) => M0
    <snip>
    
      Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative warning message
    ```
    
    Add it, for (potentially) more informative output, when failures
    occur. Checked that adding does output more information.
    5161c2618c
  3. DrahtBot commented at 11:15 am on November 6, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31232.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Nov 6, 2024
  5. hebasto approved
  6. hebasto commented at 12:53 pm on November 6, 2024: member
    ACK 5161c2618cd36cd2d64c64d42d6f6d3b1929cb28.
  7. maflcko commented at 1:43 pm on November 6, 2024: member
    lgtm ACK 5161c2618cd36cd2d64c64d42d6f6d3b1929cb28
  8. fanquake merged this on Nov 6, 2024
  9. fanquake closed this on Nov 6, 2024

  10. fanquake deleted the branch on Nov 6, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me